All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Andreas Ehmanns <universeiii@gmx.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tftpd: add include of config file to init script
Date: Thu, 28 Apr 2022 17:45:49 +0200	[thread overview]
Message-ID: <20220428154549.GE3624965@scaer> (raw)
In-Reply-To: <20220428134207.16521-1-universeiii@gmx.de>

Andreas, All,

On 2022-04-28 15:42 +0200, Andreas Ehmanns spake thusly:
> HPA's tftp server init script does not support include of a
> configuration file. So changing daemon parameters would cause
> a modification of the init script.
> Similar to NFS, dropbear, DHCP, SNMP and other network services
> in buildroot, this patch adds an include of /etc/default/tftpd
> to the init script. So any user can change the default behaviour
> by adding its own configuration file instead of changing the init
> script.
> 
> Signed-off-by: Andreas Ehmanns <universeiii@gmx.de>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/tftpd/S80tftpd-hpa | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/tftpd/S80tftpd-hpa b/package/tftpd/S80tftpd-hpa
> index 4e8361faa7..8ae15150a1 100644
> --- a/package/tftpd/S80tftpd-hpa
> +++ b/package/tftpd/S80tftpd-hpa
> @@ -11,6 +11,8 @@ DAEMON=/usr/sbin/$NAME
>  PIDFILE=/var/run/$NAME.pid
>  SCRIPTNAME=/etc/init.d/S80tftpd-hpa
> 
> +[ -r "/etc/default/$NAME" ] && . "/etc/default/$NAME"
> +
>  #
>  #	Function that starts the daemon/service.
>  #
> --
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-04-28 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 13:42 [Buildroot] [PATCH 1/1] package/tftpd: add include of config file to init script Andreas Ehmanns
2022-04-28 15:45 ` Yann E. MORIN [this message]
2022-05-27  9:43 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428154549.GE3624965@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=universeiii@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.