[Buildroot] [PATCH 1/1] package/tftpd: add include of config file to init script

[Buildroot] [PATCH 1/1] package/tftpd: add include of config file to init script

[Andreas Ehmanns]

HPA's tftp server init script does not support include of a
configuration file. So changing daemon parameters would cause
a modification of the init script.
Similar to NFS, dropbear, DHCP, SNMP and other network services
in buildroot, this patch adds an include of /etc/default/tftpd
to the init script. So any user can change the default behaviour
by adding its own configuration file instead of changing the init
script.

Signed-off-by: Andreas Ehmanns <universeiii@gmx.de>
---
 package/tftpd/S80tftpd-hpa | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/tftpd/S80tftpd-hpa b/package/tftpd/S80tftpd-hpa
index 4e8361faa7..8ae15150a1 100644
--- a/package/tftpd/S80tftpd-hpa
+++ b/package/tftpd/S80tftpd-hpa
@@ -11,6 +11,8 @@ DAEMON=/usr/sbin/$NAME
 PIDFILE=/var/run/$NAME.pid
 SCRIPTNAME=/etc/init.d/S80tftpd-hpa

+[ -r "/etc/default/$NAME" ] && . "/etc/default/$NAME"
+
 #
 #	Function that starts the daemon/service.
 #
--
2.26.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tftpd: add include of config file to init script

[Yann E. MORIN]

Andreas, All,

On 2022-04-28 15:42 +0200, Andreas Ehmanns spake thusly:
> HPA's tftp server init script does not support include of a
> configuration file. So changing daemon parameters would cause
> a modification of the init script.
> Similar to NFS, dropbear, DHCP, SNMP and other network services
> in buildroot, this patch adds an include of /etc/default/tftpd
> to the init script. So any user can change the default behaviour
> by adding its own configuration file instead of changing the init
> script.
> 
> Signed-off-by: Andreas Ehmanns <universeiii@gmx.de>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/tftpd/S80tftpd-hpa | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/tftpd/S80tftpd-hpa b/package/tftpd/S80tftpd-hpa
> index 4e8361faa7..8ae15150a1 100644
> --- a/package/tftpd/S80tftpd-hpa
> +++ b/package/tftpd/S80tftpd-hpa
> @@ -11,6 +11,8 @@ DAEMON=/usr/sbin/$NAME
>  PIDFILE=/var/run/$NAME.pid
>  SCRIPTNAME=/etc/init.d/S80tftpd-hpa
> 
> +[ -r "/etc/default/$NAME" ] && . "/etc/default/$NAME"
> +
>  #
>  #	Function that starts the daemon/service.
>  #
> --
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tftpd: add include of config file to init script

[Peter Korsgaard]

>>>>> "Andreas" == Andreas Ehmanns <universeiii@gmx.de> writes:

 > HPA's tftp server init script does not support include of a
 > configuration file. So changing daemon parameters would cause
 > a modification of the init script.
 > Similar to NFS, dropbear, DHCP, SNMP and other network services
 > in buildroot, this patch adds an include of /etc/default/tftpd
 > to the init script. So any user can change the default behaviour
 > by adding its own configuration file instead of changing the init
 > script.

 > Signed-off-by: Andreas Ehmanns <universeiii@gmx.de>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot