From: Jakub Kicinski <kuba@kernel.org>
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Cc: shshaikh@marvell.com, jdenham@redhat.com,
GR-Linux-NIC-Dev@marvell.com, manishc@marvell.com,
alexandre.belloni@bootlin.com, outreachy@lists.linux.dev,
netdev@vger.kernel.org, razor@blackwall.org,
bridge@lists.linux-foundation.org, jesse.brandeburg@intel.com,
linux-kernel@vger.kernel.org, vladimir.oltean@nxp.com,
sbrivio@redhat.com, claudiu.manoil@nxp.com,
anthony.l.nguyen@intel.com, roopa@nvidia.com,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
davem@davemloft.net, UNGLinuxDriver@microchip.com
Subject: Re: [Bridge] [PATCH net-next v5 1/2] rtnetlink: add extack support in fdb del handlers
Date: Fri, 29 Apr 2022 18:46:36 -0700 [thread overview]
Message-ID: <20220429184636.0b869ae7@kernel.org> (raw)
In-Reply-To: <26815b6deebef7f02e864ca41714533c7009e7b7.1651236082.git.eng.alaamohamedsoliman.am@gmail.com>
On Fri, 29 Apr 2022 14:49:06 +0200 Alaa Mohamed wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index fde839ef0613..3fccac358198 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5678,7 +5678,7 @@ ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],
> static int
> ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[],
> struct net_device *dev, const unsigned char *addr,
> - __always_unused u16 vid)
> + __always_unused u16 vid, struct netlink_ext_ack *extack)
You need to update the kdoc on this one.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v5 1/2] rtnetlink: add extack support in fdb del handlers
Date: Fri, 29 Apr 2022 18:46:36 -0700 [thread overview]
Message-ID: <20220429184636.0b869ae7@kernel.org> (raw)
In-Reply-To: <26815b6deebef7f02e864ca41714533c7009e7b7.1651236082.git.eng.alaamohamedsoliman.am@gmail.com>
On Fri, 29 Apr 2022 14:49:06 +0200 Alaa Mohamed wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index fde839ef0613..3fccac358198 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5678,7 +5678,7 @@ ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],
> static int
> ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[],
> struct net_device *dev, const unsigned char *addr,
> - __always_unused u16 vid)
> + __always_unused u16 vid, struct netlink_ext_ack *extack)
You need to update the kdoc on this one.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Cc: netdev@vger.kernel.org, outreachy@lists.linux.dev,
roopa@nvidia.com, jdenham@redhat.com, sbrivio@redhat.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
davem@davemloft.net, pabeni@redhat.com, vladimir.oltean@nxp.com,
claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com,
shshaikh@marvell.com, manishc@marvell.com, razor@blackwall.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, GR-Linux-NIC-Dev@marvell.com,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v5 1/2] rtnetlink: add extack support in fdb del handlers
Date: Fri, 29 Apr 2022 18:46:36 -0700 [thread overview]
Message-ID: <20220429184636.0b869ae7@kernel.org> (raw)
In-Reply-To: <26815b6deebef7f02e864ca41714533c7009e7b7.1651236082.git.eng.alaamohamedsoliman.am@gmail.com>
On Fri, 29 Apr 2022 14:49:06 +0200 Alaa Mohamed wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index fde839ef0613..3fccac358198 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5678,7 +5678,7 @@ ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],
> static int
> ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[],
> struct net_device *dev, const unsigned char *addr,
> - __always_unused u16 vid)
> + __always_unused u16 vid, struct netlink_ext_ack *extack)
You need to update the kdoc on this one.
next prev parent reply other threads:[~2022-04-30 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 12:49 [Bridge] [PATCH net-next v5 0/2] propagate extack to vxlan_fdb_delete Alaa Mohamed
2022-04-29 12:49 ` Alaa Mohamed
2022-04-29 12:49 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-29 12:49 ` [Bridge] [PATCH net-next v5 1/2] rtnetlink: add extack support in fdb del handlers Alaa Mohamed
2022-04-29 12:49 ` Alaa Mohamed
2022-04-29 12:49 ` [Intel-wired-lan] " Alaa Mohamed
2022-04-30 1:46 ` Jakub Kicinski [this message]
2022-04-30 1:46 ` Jakub Kicinski
2022-04-30 1:46 ` [Intel-wired-lan] " Jakub Kicinski
2022-04-29 12:49 ` [Bridge] [PATCH net-next v5 2/2] net: vxlan: Add extack support to vxlan_fdb_delete Alaa Mohamed
2022-04-29 12:49 ` Alaa Mohamed
2022-04-29 12:49 ` [Intel-wired-lan] " Alaa Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429184636.0b869ae7@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdenham@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sbrivio@redhat.com \
--cc=shshaikh@marvell.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.