From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, petrm@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 2/8] selftests: router_vid_1: Add a diagram, fix coding style
Date: Wed, 4 May 2022 09:29:03 +0300 [thread overview]
Message-ID: <20220504062909.536194-3-idosch@nvidia.com> (raw)
In-Reply-To: <20220504062909.536194-1-idosch@nvidia.com>
From: Petr Machata <petrm@nvidia.com>
It is customary for selftests to have a comment with a topology diagram,
which serves to illustrate the situation in which the test is done. This
selftest lacks it. Add it.
While at it, fix the list of tests so that the test names are enumerated
one at a line.
Signed-off-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
.../selftests/net/forwarding/router_vid_1.sh | 27 ++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/router_vid_1.sh b/tools/testing/selftests/net/forwarding/router_vid_1.sh
index a7306c7ac06d..865c9f7d8143 100755
--- a/tools/testing/selftests/net/forwarding/router_vid_1.sh
+++ b/tools/testing/selftests/net/forwarding/router_vid_1.sh
@@ -1,7 +1,32 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
-ALL_TESTS="ping_ipv4 ping_ipv6"
+# +--------------------+ +----------------------+
+# | H1 | | H2 |
+# | | | |
+# | $h1.1 + | | + $h2.1 |
+# | 192.0.2.2/24 | | | | 198.51.100.2/24 |
+# | 2001:db8:1::2/64 | | | | 2001:db8:2::2/64 |
+# | | | | | |
+# | $h1 + | | + $h2 |
+# | | | | | |
+# +------------------|-+ +-|--------------------+
+# | |
+# +------------------|-------------------------|--------------------+
+# | SW | | |
+# | | | |
+# | $rp1 + + $rp2 |
+# | | | |
+# | $rp1.1 + + $rp2.1 |
+# | 192.0.2.1/24 198.51.100.1/24 |
+# | 2001:db8:1::1/64 2001:db8:2::1/64 |
+# | |
+# +-----------------------------------------------------------------+
+
+ALL_TESTS="
+ ping_ipv4
+ ping_ipv6
+"
NUM_NETIFS=4
source lib.sh
--
2.35.1
next prev parent reply other threads:[~2022-05-04 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 6:29 [PATCH net-next 0/8] mlxsw: Various updates Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 1/8] selftests: mlxsw: bail_on_lldpad before installing the cleanup trap Ido Schimmel
2022-05-04 6:29 ` Ido Schimmel [this message]
2022-05-04 6:29 ` [PATCH net-next 3/8] selftests: router.sh: Add a diagram Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 4/8] mlxsw: spectrum_dcb: Do not warn about priority changes Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 5/8] mlxsw: Treat LLDP packets as control Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 6/8] mlxsw: spectrum_acl: Do not report activity for multicast routes Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 7/8] mlxsw: spectrum_switchdev: Only query FDB notifications when necessary Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 8/8] mlxsw: spectrum_router: Only query neighbour activity " Ido Schimmel
2022-05-04 10:30 ` [PATCH net-next 0/8] mlxsw: Various updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504062909.536194-3-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.