From: Ido Schimmel <idosch@nvidia.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, petrm@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 6/8] mlxsw: spectrum_acl: Do not report activity for multicast routes
Date: Wed, 4 May 2022 09:29:07 +0300 [thread overview]
Message-ID: <20220504062909.536194-7-idosch@nvidia.com> (raw)
In-Reply-To: <20220504062909.536194-1-idosch@nvidia.com>
The driver periodically queries the device for activity of ACL rules in
order to report it to tc upon 'FLOW_CLS_STATS'.
In Spectrum-2 and later ASICs, multicast routes are programmed as ACL
rules, but unlike rules installed by tc, their activity is of no
interest.
Avoid unnecessary activity query for such rules by always reporting them
as inactive.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
index 31f7f4c3acc3..3b9ba8fa247a 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c
@@ -1827,10 +1827,9 @@ static int
mlxsw_sp_acl_tcam_mr_rule_activity_get(struct mlxsw_sp *mlxsw_sp,
void *rule_priv, bool *activity)
{
- struct mlxsw_sp_acl_tcam_mr_rule *rule = rule_priv;
+ *activity = false;
- return mlxsw_sp_acl_tcam_ventry_activity_get(mlxsw_sp, &rule->ventry,
- activity);
+ return 0;
}
static const struct mlxsw_sp_acl_profile_ops mlxsw_sp_acl_tcam_mr_ops = {
--
2.35.1
next prev parent reply other threads:[~2022-05-04 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 6:29 [PATCH net-next 0/8] mlxsw: Various updates Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 1/8] selftests: mlxsw: bail_on_lldpad before installing the cleanup trap Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 2/8] selftests: router_vid_1: Add a diagram, fix coding style Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 3/8] selftests: router.sh: Add a diagram Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 4/8] mlxsw: spectrum_dcb: Do not warn about priority changes Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 5/8] mlxsw: Treat LLDP packets as control Ido Schimmel
2022-05-04 6:29 ` Ido Schimmel [this message]
2022-05-04 6:29 ` [PATCH net-next 7/8] mlxsw: spectrum_switchdev: Only query FDB notifications when necessary Ido Schimmel
2022-05-04 6:29 ` [PATCH net-next 8/8] mlxsw: spectrum_router: Only query neighbour activity " Ido Schimmel
2022-05-04 10:30 ` [PATCH net-next 0/8] mlxsw: Various updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504062909.536194-7-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.