From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Markuss Broks <markuss.broks@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
phone-devel@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,"
<~postmarketos/upstreaming@lists.sr.ht>,
Rob Herring <robh+dt@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional
Date: Wed, 4 May 2022 19:24:17 +0200 [thread overview]
Message-ID: <20220504172417.GE1623@bug> (raw)
In-Reply-To: <CAHp75VfgSphDN9TVgeiPGdcDVqutcGnTURqu6r143sjJDsPXUA@mail.gmail.com>
Hi!
> > Make the AUX pin optional, since it isn't a core part of functionality,
> > and the device is designed to be operational with only one CTRL pin.
> >
> > Also pick up maintenance for the LED driver and the yaml bindings.
>
> It's polite to Cc reviewers of your previous versions of the series.
>
> While this patch is fine to me, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> one comment below.
Thanks for review.
Markuss, can you collect review tags and post v7?. Please drop MAINTAINERS part for now.
And sorry for delays.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2022-05-04 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 18:40 [PATCH v6 0/2] Make AUX gpio pin optional for ktd2692 Markuss Broks
2022-04-08 18:40 ` [PATCH v6 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml Markuss Broks
2022-04-08 20:59 ` Rob Herring
2022-04-08 18:40 ` [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional Markuss Broks
2022-04-11 17:11 ` Andy Shevchenko
2022-05-04 17:24 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-18 23:49 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504172417.GE1623@bug \
--to=pavel@ucw.cz \
--cc=andy.shevchenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.