[PATCH v6 0/2] Make AUX gpio pin optional for ktd2692

[PATCH v6 0/2] Make AUX gpio pin optional for ktd2692

[Markuss Broks]

Some appliances of ktd2692 don't have the AUX pin connected to
a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692
for driving the front flash LED, has the pin not connected anywhere on
schematics. Make specifying the AUX pin optional, since it is additional
functionality and only affects amount of current going through the LED.

Also convert the txt device-tree bindings to yaml and pick up maintenance
over the yaml binding and the driver itself.

v2:
- fix the dt_binding_check
v3:
- set the aux_gpio to NULL to avoid passing ERR_PTR as a gpio
v4:
- maintainership -> maintenance (description)
- remove the if (led->aux_gpio)
- use devm_gpiod_get_optional for aux gpio
v5:
- use ret to pass a correct error return code (Christophe)
v6:
- use PTR_ERR properly (when IS_ERR is true) (Christophe)

Markuss Broks (2):
  dt-bindings: leds: convert ktd2692 bindings to yaml
  leds: ktd2692: Make aux-gpios optional

 .../bindings/leds/kinetic,ktd2692.yaml        | 87 +++++++++++++++++++
 .../devicetree/bindings/leds/leds-ktd2692.txt | 50 -----------
 MAINTAINERS                                   |  6 ++
 drivers/leds/flash/leds-ktd2692.c             | 18 ++--
 4 files changed, 103 insertions(+), 58 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt

-- 
2.35.1

[PATCH v6 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml

[Markuss Broks]

This patch converts the leds-ktd2692.txt bindings to modern yaml
style device-tree bindings.

Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
 .../bindings/leds/kinetic,ktd2692.yaml        | 87 +++++++++++++++++++
 .../devicetree/bindings/leds/leds-ktd2692.txt | 50 -----------
 2 files changed, 87 insertions(+), 50 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt

diff --git a/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
new file mode 100644
index 000000000000..bac95a51afa1
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
@@ -0,0 +1,87 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: KTD2692 Flash LED Driver from Kinetic Technologies
+
+maintainers:
+  - Markuss Broks <markuss.broks@gmail.com>
+
+description: |
+  KTD2692 is the ideal power solution for high-power flash LEDs.
+  It uses ExpressWire single-wire programming for maximum flexibility.
+
+  The ExpressWire interface through CTRL pin can control LED on/off and
+  enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current,
+  Flash timeout, LVP(low voltage protection).
+
+  Also, When the AUX pin is pulled high while CTRL pin is high,
+  LED current will be ramped up to the flash-mode current level.
+
+properties:
+  compatible:
+    const: kinetic,ktd2692
+
+  ctrl-gpios:
+    maxItems: 1
+    description: Specifier of the GPIO connected to CTRL pin.
+
+  aux-gpios:
+    maxItems: 1
+    description: Specifier of the GPIO connected to CTRL pin.
+
+  vin-supply:
+    description: LED supply (2.7V to 5.5V).
+
+  led:
+    type: object
+    $ref: common.yaml#
+    description: Properties for the LED.
+    properties:
+      function: true
+      color: true
+      flash-max-timeout-us:
+        description: Flash LED maximum timeout.
+
+      led-max-microamp:
+        maximum: 300000
+        description: Minimum Threshold for Timer protection
+          is defined internally (Maximum 300mA).
+
+      flash-max-microamp:
+        maximum: 300000
+        description: Flash LED maximum current
+          Formula - I(uA) = 15000000 / Rset.
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - ctrl-gpios
+  - led
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/leds/common.h>
+
+    ktd2692 {
+      compatible = "kinetic,ktd2692";
+      ctrl-gpios = <&gpc0 1 0>;
+      aux-gpios = <&gpc0 2 0>;
+      vin-supply = <&vbat>;
+
+      led {
+        function = LED_FUNCTION_FLASH;
+        color = <LED_COLOR_ID_WHITE>;
+        flash-max-timeout-us = <250000>;
+        flash-max-microamp = <150000>;
+        led-max-microamp = <25000>;
+      };
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
deleted file mode 100644
index 853737452580..000000000000
--- a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
+++ /dev/null
@@ -1,50 +0,0 @@
-* Kinetic Technologies - KTD2692 Flash LED Driver
-
-KTD2692 is the ideal power solution for high-power flash LEDs.
-It uses ExpressWire single-wire programming for maximum flexibility.
-
-The ExpressWire interface through CTRL pin can control LED on/off and
-enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current,
-Flash timeout, LVP(low voltage protection).
-
-Also, When the AUX pin is pulled high while CTRL pin is high,
-LED current will be ramped up to the flash-mode current level.
-
-Required properties:
-- compatible : Should be "kinetic,ktd2692".
-- ctrl-gpios : Specifier of the GPIO connected to CTRL pin.
-- aux-gpios : Specifier of the GPIO connected to AUX pin.
-
-Optional properties:
-- vin-supply : "vin" LED supply (2.7V to 5.5V).
-  See Documentation/devicetree/bindings/regulator/regulator.txt
-
-A discrete LED element connected to the device must be represented by a child
-node - See Documentation/devicetree/bindings/leds/common.txt
-
-Required properties for flash LED child nodes:
-  See Documentation/devicetree/bindings/leds/common.txt
-- led-max-microamp : Minimum Threshold for Timer protection
-  is defined internally (Maximum 300mA).
-- flash-max-microamp : Flash LED maximum current
-  Formula : I(mA) = 15000 / Rset.
-- flash-max-timeout-us : Flash LED maximum timeout.
-
-Optional properties for flash LED child nodes:
-- label : See Documentation/devicetree/bindings/leds/common.txt
-
-Example:
-
-ktd2692 {
-	compatible = "kinetic,ktd2692";
-	ctrl-gpios = <&gpc0 1 0>;
-	aux-gpios = <&gpc0 2 0>;
-	vin-supply = <&vbat>;
-
-	flash-led {
-		label = "ktd2692-flash";
-		led-max-microamp = <300000>;
-		flash-max-microamp = <1500000>;
-		flash-max-timeout-us = <1835000>;
-	};
-};
-- 
2.35.1

[PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional

[Markuss Broks]

Make the AUX pin optional, since it isn't a core part of functionality,
and the device is designed to be operational with only one CTRL pin.

Also pick up maintenance for the LED driver and the yaml bindings.

Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
 MAINTAINERS                       | 6 ++++++
 drivers/leds/flash/leds-ktd2692.c | 6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2db49ea7ae55..8ef5667a1d98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10479,6 +10479,12 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
 F:	drivers/video/backlight/ktd253-backlight.c
 
+KTD2692 FLASH LED DRIVER
+M:	Markuss Broks <markuss.broks@gmail.com>
+S:	Maintained
+F:	Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml
+F:	drivers/leds/flash/leds-ktd2692.yaml
+
 KTEST
 M:	Steven Rostedt <rostedt@goodmis.org>
 M:	John Hawley <warthog9@eaglescrag.net>
diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c
index f341da1503a4..01ceea83af67 100644
--- a/drivers/leds/flash/leds-ktd2692.c
+++ b/drivers/leds/flash/leds-ktd2692.c
@@ -284,9 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
 		return ret;
 	}
 
-	led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS);
-	ret = PTR_ERR_OR_ZERO(led->aux_gpio);
-	if (ret) {
+	led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS);
+	if (IS_ERR(led->aux_gpio)) {
+		ret = PTR_ERR(led->aux_gpio);
 		dev_err(dev, "cannot get aux-gpios %d\n", ret);
 		return ret;
 	}
-- 
2.35.1

Re: [PATCH v6 1/2] dt-bindings: leds: convert ktd2692 bindings to yaml

[Rob Herring]

On Fri, 08 Apr 2022 21:40:54 +0300, Markuss Broks wrote:
> This patch converts the leds-ktd2692.txt bindings to modern yaml
> style device-tree bindings.
> 
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
>  .../bindings/leds/kinetic,ktd2692.yaml        | 87 +++++++++++++++++++
>  .../devicetree/bindings/leds/leds-ktd2692.txt | 50 -----------
>  2 files changed, 87 insertions(+), 50 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
>  delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional

[Andy Shevchenko]

On Sat, Apr 9, 2022 at 8:14 AM Markuss Broks <markuss.broks@gmail.com> wrote:
>
> Make the AUX pin optional, since it isn't a core part of functionality,
> and the device is designed to be operational with only one CTRL pin.
>
> Also pick up maintenance for the LED driver and the yaml bindings.

It's polite to Cc reviewers of your previous versions of the series.

While this patch is fine to me,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
one comment below.

> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
>  MAINTAINERS                       | 6 ++++++
>  drivers/leds/flash/leds-ktd2692.c | 6 +++---
>  2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2db49ea7ae55..8ef5667a1d98 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10479,6 +10479,12 @@ S:     Maintained
>  F:     Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml
>  F:     drivers/video/backlight/ktd253-backlight.c
>
> +KTD2692 FLASH LED DRIVER
> +M:     Markuss Broks <markuss.broks@gmail.com>
> +S:     Maintained
> +F:     Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml
> +F:     drivers/leds/flash/leds-ktd2692.yaml
> +
>  KTEST
>  M:     Steven Rostedt <rostedt@goodmis.org>
>  M:     John Hawley <warthog9@eaglescrag.net>
> diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c
> index f341da1503a4..01ceea83af67 100644
> --- a/drivers/leds/flash/leds-ktd2692.c
> +++ b/drivers/leds/flash/leds-ktd2692.c
> @@ -284,9 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,
>                 return ret;
>         }
>
> -       led->aux_gpio = devm_gpiod_get(dev, "aux", GPIOD_ASIS);
> -       ret = PTR_ERR_OR_ZERO(led->aux_gpio);
> -       if (ret) {
> +       led->aux_gpio = devm_gpiod_get_optional(dev, "aux", GPIOD_ASIS);
> +       if (IS_ERR(led->aux_gpio)) {
> +               ret = PTR_ERR(led->aux_gpio);
>                 dev_err(dev, "cannot get aux-gpios %d\n", ret);
>                 return ret;

Now you may consider switching to dev_err_probe() in a separate patch:

       if (IS_ERR(led->aux_gpio))
               return dev_err_probe(dev, PTR_ERR(led->aux_gpio),
"cannot get aux-gpios\n");

>         }

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 14892 bytes --]

CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
In-Reply-To: <20220408184104.13665-3-markuss.broks@gmail.com>
References: <20220408184104.13665-3-markuss.broks@gmail.com>
TO: Markuss Broks <markuss.broks@gmail.com>
TO: linux-kernel(a)vger.kernel.org
CC: phone-devel(a)vger.kernel.org
CC: ~postmarketos/upstreaming(a)lists.sr.ht
CC: Markuss Broks <markuss.broks@gmail.com>
CC: Pavel Machek <pavel@ucw.cz>
CC: Rob Herring <robh+dt@kernel.org>
CC: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC: Linus Walleij <linus.walleij@linaro.org>
CC: linux-leds(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org

Hi Markuss,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pavel-leds/for-next]
[also build test WARNING on linus/master linux/master v5.18-rc3 next-20220414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Make-AUX-gpio-pin-optional-for-ktd2692/20220409-024603
base:   git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
:::::: branch date: 10 days ago
:::::: commit date: 10 days ago
config: x86_64-randconfig-c007-20220418 (https://download.01.org/0day-ci/archive/20220419/202204190742.7hPtHoMK-lkp(a)intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b27430f9f46b88bcd54d992debc8d72e131e1bd0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0b519b2b7290b0e3d0bc3687cdc39efc967c6b21
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Markuss-Broks/Make-AUX-gpio-pin-optional-for-ktd2692/20220409-024603
        git checkout 0b519b2b7290b0e3d0bc3687cdc39efc967c6b21
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


clang-analyzer warnings: (new ones prefixed by >>)
   drivers/mux/mmio.c:58:2: note: Taking false branch
           if (ret == 0 || ret % 2)
           ^
   drivers/mux/mmio.c:60:6: note: Assuming 'ret' is >= 0
           if (ret < 0) {
               ^~~~~~~
   drivers/mux/mmio.c:60:2: note: Taking false branch
           if (ret < 0) {
           ^
   drivers/mux/mmio.c:69:2: note: Taking false branch
           if (IS_ERR(mux_chip))
           ^
   drivers/mux/mmio.c:74:14: note: Assuming 'i' is < 'num_fields'
           for (i = 0; i < num_fields; i++) {
                       ^~~~~~~~~~~~~~
   drivers/mux/mmio.c:74:2: note: Loop condition is true.  Entering loop body
           for (i = 0; i < num_fields; i++) {
           ^
   drivers/mux/mmio.c:78:12: note: 'mask' declared without an initial value
                   u32 reg, mask;
                            ^~~~
   drivers/mux/mmio.c:83:7: note: Assuming 'ret' is not equal to 0
                   if (!ret)
                       ^~~~
   drivers/mux/mmio.c:83:3: note: Taking false branch
                   if (!ret)
                   ^
   drivers/mux/mmio.c:86:7: note: Assuming 'ret' is >= 0
                   if (ret < 0) {
                       ^~~~~~~
   drivers/mux/mmio.c:86:3: note: Taking false branch
                   if (ret < 0) {
                   ^
   drivers/mux/mmio.c:93:15: note: 1st function call argument is an uninitialized value
                   field.msb = fls(mask) - 1;
                               ^   ~~~~
   drivers/mux/mmio.c:102:15: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'id_size') [clang-analyzer-core.CallAndMessage]
                   fields[i] = devm_regmap_field_alloc(dev, regmap, field);
                               ^                                    ~~~~~
   drivers/mux/mmio.c:47:6: note: Assuming the condition is true
           if (of_device_is_compatible(np, "mmio-mux"))
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mux/mmio.c:47:2: note: Taking true branch
           if (of_device_is_compatible(np, "mmio-mux"))
           ^
   drivers/mux/mmio.c:51:2: note: Taking false branch
           if (IS_ERR(regmap)) {
           ^
   drivers/mux/mmio.c:58:6: note: Assuming 'ret' is not equal to 0
           if (ret == 0 || ret % 2)
               ^~~~~~~~
   drivers/mux/mmio.c:58:6: note: Left side of '||' is false
   drivers/mux/mmio.c:58:18: note: Assuming the condition is false
           if (ret == 0 || ret % 2)
                           ^~~~~~~
   drivers/mux/mmio.c:58:2: note: Taking false branch
           if (ret == 0 || ret % 2)
           ^
   drivers/mux/mmio.c:60:6: note: Assuming 'ret' is >= 0
           if (ret < 0) {
               ^~~~~~~
   drivers/mux/mmio.c:60:2: note: Taking false branch
           if (ret < 0) {
           ^
   drivers/mux/mmio.c:69:2: note: Taking false branch
           if (IS_ERR(mux_chip))
           ^
   drivers/mux/mmio.c:74:14: note: Assuming 'i' is < 'num_fields'
           for (i = 0; i < num_fields; i++) {
                       ^~~~~~~~~~~~~~
   drivers/mux/mmio.c:74:2: note: Loop condition is true.  Entering loop body
           for (i = 0; i < num_fields; i++) {
           ^
   drivers/mux/mmio.c:76:3: note: 'field' initialized here
                   struct reg_field field;
                   ^~~~~~~~~~~~~~~~~~~~~~
   drivers/mux/mmio.c:83:7: note: Assuming 'ret' is 0
                   if (!ret)
                       ^~~~
   drivers/mux/mmio.c:83:3: note: Taking true branch
                   if (!ret)
                   ^
   drivers/mux/mmio.c:86:7: note: Assuming 'ret' is >= 0
                   if (ret < 0) {
                       ^~~~~~~
   drivers/mux/mmio.c:86:3: note: Taking false branch
                   if (ret < 0) {
                   ^
   drivers/mux/mmio.c:96:7: note: Assuming the condition is false
                   if (mask != GENMASK(field.msb, field.lsb)) {
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mux/mmio.c:96:3: note: Taking false branch
                   if (mask != GENMASK(field.msb, field.lsb)) {
                   ^
   drivers/mux/mmio.c:102:15: note: Passed-by-value struct argument contains uninitialized data (e.g., field: 'id_size')
                   fields[i] = devm_regmap_field_alloc(dev, regmap, field);
                               ^                                    ~~~~~
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   3 warnings generated.
>> drivers/leds/flash/leds-ktd2692.c:241:15: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign]
           setting->max = cfg->flash_max_timeout;
                        ^
   drivers/leds/flash/leds-ktd2692.c:359:6: note: Assuming 'led' is non-null
           if (!led)
               ^~~~
   drivers/leds/flash/leds-ktd2692.c:359:2: note: Taking false branch
           if (!led)
           ^
   drivers/leds/flash/leds-ktd2692.c:365:8: note: Calling 'ktd2692_parse_dt'
           ret = ktd2692_parse_dt(led, &pdev->dev, &led_cfg);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/leds/flash/leds-ktd2692.c:277:6: note: Assuming 'np' is non-null
           if (!np)
               ^~~
   drivers/leds/flash/leds-ktd2692.c:277:2: note: Taking false branch
           if (!np)
           ^
   drivers/leds/flash/leds-ktd2692.c:282:6: note: 'ret' is 0
           if (ret) {
               ^~~
   drivers/leds/flash/leds-ktd2692.c:282:2: note: Taking false branch
           if (ret) {
           ^
   drivers/leds/flash/leds-ktd2692.c:288:2: note: Taking true branch
           if (IS_ERR(led->aux_gpio)) {
           ^
   drivers/leds/flash/leds-ktd2692.c:290:3: note: Loop condition is false.  Exiting loop
                   dev_err(dev, "cannot get aux-gpios %d\n", ret);
                   ^
   include/linux/dev_printk.h:144:2: note: expanded from macro 'dev_err'
           dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
           ^
   include/linux/dev_printk.h:109:3: note: expanded from macro 'dev_printk_index_wrap'
                   dev_printk_index_emit(level, fmt);                      \
                   ^
   include/linux/dev_printk.h:105:2: note: expanded from macro 'dev_printk_index_emit'
           printk_index_subsys_emit("%s %s: ", level, fmt)
           ^
   include/linux/printk.h:413:2: note: expanded from macro 'printk_index_subsys_emit'
           __printk_index_emit(fmt, level, subsys_fmt_prefix)
           ^
   include/linux/printk.h:392:34: note: expanded from macro '__printk_index_emit'
   #define __printk_index_emit(...) do {} while (0)
                                    ^
   drivers/leds/flash/leds-ktd2692.c:291:3: note: Returning without writing to 'cfg->flash_max_timeout'
                   return ret;
                   ^
   drivers/leds/flash/leds-ktd2692.c:365:8: note: Returning from 'ktd2692_parse_dt'
           ret = ktd2692_parse_dt(led, &pdev->dev, &led_cfg);
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/leds/flash/leds-ktd2692.c:366:6: note: Assuming 'ret' is 0
           if (ret)
               ^~~
   drivers/leds/flash/leds-ktd2692.c:366:2: note: Taking false branch
           if (ret)
           ^
   drivers/leds/flash/leds-ktd2692.c:369:2: note: Calling 'ktd2692_init_flash_timeout'
           ktd2692_init_flash_timeout(fled_cdev, &led_cfg);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/leds/flash/leds-ktd2692.c:241:15: note: Assigned value is garbage or undefined
           setting->max = cfg->flash_max_timeout;
                        ^ ~~~~~~~~~~~~~~~~~~~~~~
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   2 warnings generated.
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   2 warnings generated.
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   2 warnings generated.
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   2 warnings generated.
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   2 warnings generated.
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   1 warning generated.
   Suppressed 1 warnings (1 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   2 warnings generated.
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
   4 warnings generated.
   mm/huge_memory.c:583:9: warning: Value stored to 'off' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
           loff_t off = (loff_t)pgoff << PAGE_SHIFT;
                  ^~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   mm/huge_memory.c:583:9: note: Value stored to 'off' during its initialization is never read
           loff_t off = (loff_t)pgoff << PAGE_SHIFT;
                  ^~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   mm/huge_memory.c:3096:4: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
                           strcpy(file_path, tok);
                           ^~~~~~
   mm/huge_memory.c:3096:4: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
                           strcpy(file_path, tok);
                           ^~~~~~
   Suppressed 2 warnings (2 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

vim +241 drivers/leds/flash/leds-ktd2692.c

b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  233  
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  234  static void ktd2692_init_flash_timeout(struct led_classdev_flash *fled_cdev,
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  235  				       struct ktd2692_led_config_data *cfg)
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  236  {
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  237  	struct led_flash_setting *setting;
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  238  
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  239  	setting = &fled_cdev->timeout;
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  240  	setting->min = KTD2692_FLASH_MODE_TIMEOUT_DISABLE;
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12 @241  	setting->max = cfg->flash_max_timeout;
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  242  	setting->step = cfg->flash_max_timeout
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  243  			/ (KTD2692_FLASH_MODE_TIMEOUT_LEVELS - 1);
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  244  	setting->val = cfg->flash_max_timeout;
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  245  }
b7da8c5c725cc2 drivers/leds/leds-ktd2692.c Ingi Kim 2015-05-12  246  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional

[Pavel Machek]

Hi!

> > Make the AUX pin optional, since it isn't a core part of functionality,
> > and the device is designed to be operational with only one CTRL pin.
> >
> > Also pick up maintenance for the LED driver and the yaml bindings.
> 
> It's polite to Cc reviewers of your previous versions of the series.
> 
> While this patch is fine to me, Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> 
> one comment below.

Thanks for review.

Markuss, can you collect review tags and post v7?. Please drop MAINTAINERS part for now.

And sorry for delays.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html