From: Pavel Machek <pavel@ucw.cz>
To: Aparna M <a-m1@ti.com>,
nm@ti.com, vigneshr@ti.com, kristo@kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
praneeth@ti.com, grygorii.strashko@ti.com, nikhil.nd@ti.com,
linux-leds@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Date: Wed, 4 May 2022 19:25:07 +0200 [thread overview]
Message-ID: <20220504172507.GH1623@bug> (raw)
In-Reply-To: <YmYuV3lhncn6RWGQ@ada-deb-carambola.ifak-system.com>
Hi!
> > + led-7 {
> > + color = <LED_COLOR_ID_AMBER>;
> > + function = LED_FUNCTION_INDICATOR;
> > + function-enumerator = <8>;
> > + linux,default-trigger = "heartbeat";
> > + gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
> > + };
>
> This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to
> author's personal preferences?
You are right that having 8 leds marked as indicator is not too useful.
> I added the linux-leds list to Cc.
Thank you!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Aparna M <a-m1@ti.com>,
nm@ti.com, vigneshr@ti.com, kristo@kernel.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
praneeth@ti.com, grygorii.strashko@ti.com, nikhil.nd@ti.com,
linux-leds@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs
Date: Wed, 4 May 2022 19:25:07 +0200 [thread overview]
Message-ID: <20220504172507.GH1623@bug> (raw)
In-Reply-To: <YmYuV3lhncn6RWGQ@ada-deb-carambola.ifak-system.com>
Hi!
> > + led-7 {
> > + color = <LED_COLOR_ID_AMBER>;
> > + function = LED_FUNCTION_INDICATOR;
> > + function-enumerator = <8>;
> > + linux,default-trigger = "heartbeat";
> > + gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
> > + };
>
> This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to
> author's personal preferences?
You are right that having 8 leds marked as indicator is not too useful.
> I added the linux-leds list to Cc.
Thank you!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-04 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 7:29 [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs Aparna M
2022-04-20 7:29 ` Aparna M
2022-04-22 9:57 ` Vignesh Raghavendra
2022-04-22 9:57 ` Vignesh Raghavendra
2022-04-25 5:15 ` Alexander Dahl
2022-04-25 5:15 ` Alexander Dahl
2022-05-04 17:25 ` Pavel Machek [this message]
2022-05-04 17:25 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504172507.GH1623@bug \
--to=pavel@ucw.cz \
--cc=a-m1@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nikhil.nd@ti.com \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.