All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>
Cc: iommu@lists.linux-foundation.org,
	Jacob jun Pan <jacob.jun.pan@intel.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] iommu/vt-d: Remove hard coding PGSNP bit in PASID entries
Date: Thu,  5 May 2022 09:07:10 +0800	[thread overview]
Message-ID: <20220505010710.1477739-5-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20220505010710.1477739-1-baolu.lu@linux.intel.com>

As enforce_cache_coherency has been introduced into the iommu_domain_ops,
the kernel component which owns the iommu domain is able to opt-in its
requirement for force snooping support. The iommu driver has no need to
hard code the page snoop control bit in the PASID table entries anymore.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/pasid.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
index 41a0e3b02c79..0abfa7fc7fb0 100644
--- a/drivers/iommu/intel/pasid.c
+++ b/drivers/iommu/intel/pasid.c
@@ -710,9 +710,6 @@ int intel_pasid_setup_second_level(struct intel_iommu *iommu,
 	pasid_set_fault_enable(pte);
 	pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap));
 
-	if (domain->domain.type == IOMMU_DOMAIN_UNMANAGED)
-		pasid_set_pgsnp(pte);
-
 	/*
 	 * Since it is a second level only translation setup, we should
 	 * set SRE bit as well (addresses are expected to be GPAs).
-- 
2.25.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>
Cc: Jacob jun Pan <jacob.jun.pan@intel.com>,
	Liu Yi L <yi.l.liu@intel.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 4/4] iommu/vt-d: Remove hard coding PGSNP bit in PASID entries
Date: Thu,  5 May 2022 09:07:10 +0800	[thread overview]
Message-ID: <20220505010710.1477739-5-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20220505010710.1477739-1-baolu.lu@linux.intel.com>

As enforce_cache_coherency has been introduced into the iommu_domain_ops,
the kernel component which owns the iommu domain is able to opt-in its
requirement for force snooping support. The iommu driver has no need to
hard code the page snoop control bit in the PASID table entries anymore.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/pasid.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
index 41a0e3b02c79..0abfa7fc7fb0 100644
--- a/drivers/iommu/intel/pasid.c
+++ b/drivers/iommu/intel/pasid.c
@@ -710,9 +710,6 @@ int intel_pasid_setup_second_level(struct intel_iommu *iommu,
 	pasid_set_fault_enable(pte);
 	pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap));
 
-	if (domain->domain.type == IOMMU_DOMAIN_UNMANAGED)
-		pasid_set_pgsnp(pte);
-
 	/*
 	 * Since it is a second level only translation setup, we should
 	 * set SRE bit as well (addresses are expected to be GPAs).
-- 
2.25.1


  parent reply	other threads:[~2022-05-05  1:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05  1:07 [PATCH v2 0/4] iommu/vt-d: Force snooping improvement Lu Baolu
2022-05-05  1:07 ` Lu Baolu
2022-05-05  1:07 ` [PATCH v2 1/4] iommu/vt-d: Block force-snoop domain attaching if no SC support Lu Baolu
2022-05-05  1:07   ` Lu Baolu
2022-05-05  8:34   ` Tian, Kevin
2022-05-05  8:34     ` Tian, Kevin
2022-05-05  1:07 ` [PATCH v2 2/4] iommu/vt-d: Check domain force_snooping against attached devices Lu Baolu
2022-05-05  1:07   ` Lu Baolu
2022-05-05  8:43   ` Tian, Kevin
2022-05-05  8:43     ` Tian, Kevin
2022-05-05 12:12     ` Baolu Lu
2022-05-05 12:12       ` Baolu Lu
2022-05-05  1:07 ` [PATCH v2 3/4] iommu/vt-d: Remove domain_update_iommu_snooping() Lu Baolu
2022-05-05  1:07   ` Lu Baolu
2022-05-05  8:44   ` Tian, Kevin
2022-05-05  8:44     ` Tian, Kevin
2022-05-05  1:07 ` Lu Baolu [this message]
2022-05-05  1:07   ` [PATCH v2 4/4] iommu/vt-d: Remove hard coding PGSNP bit in PASID entries Lu Baolu
2022-05-05  8:46   ` Tian, Kevin
2022-05-05  8:46     ` Tian, Kevin
2022-05-05 12:14     ` Baolu Lu
2022-05-05 12:14       ` Baolu Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505010710.1477739-5-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jacob.jun.pan@intel.com \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.