All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org, edumazet@google.com,
	pabeni@redhat.com, davem@davemloft.net
Subject: Re: [PATCH net-next 5/6] net: virtio: switch to netif_napi_add_weight()
Date: Sat, 7 May 2022 02:55:35 -0400	[thread overview]
Message-ID: <20220507025428-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220506170751.822862-6-kuba@kernel.org>

On Fri, May 06, 2022 at 10:07:50AM -0700, Jakub Kicinski wrote:
> virtio netdev driver uses a custom napi weight, switch to the new
> API for setting custom weight.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> CC: mst@redhat.com
> CC: jasowang@redhat.com
> CC: virtualization@lists.linux-foundation.org
> ---
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index ebb98b796352..db05b5e930be 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3313,8 +3313,8 @@ static int virtnet_alloc_queues(struct virtnet_info *vi)
>  	INIT_DELAYED_WORK(&vi->refill, refill_work);
>  	for (i = 0; i < vi->max_queue_pairs; i++) {
>  		vi->rq[i].pages = NULL;
> -		netif_napi_add(vi->dev, &vi->rq[i].napi, virtnet_poll,
> -			       napi_weight);
> +		netif_napi_add_weight(vi->dev, &vi->rq[i].napi, virtnet_poll,
> +				      napi_weight);
>  		netif_napi_add_tx_weight(vi->dev, &vi->sq[i].napi,
>  					 virtnet_poll_tx,
>  					 napi_tx ? napi_weight : 0);
> -- 
> 2.34.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
	edumazet@google.com, jasowang@redhat.com,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 5/6] net: virtio: switch to netif_napi_add_weight()
Date: Sat, 7 May 2022 02:55:35 -0400	[thread overview]
Message-ID: <20220507025428-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220506170751.822862-6-kuba@kernel.org>

On Fri, May 06, 2022 at 10:07:50AM -0700, Jakub Kicinski wrote:
> virtio netdev driver uses a custom napi weight, switch to the new
> API for setting custom weight.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> CC: mst@redhat.com
> CC: jasowang@redhat.com
> CC: virtualization@lists.linux-foundation.org
> ---
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index ebb98b796352..db05b5e930be 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3313,8 +3313,8 @@ static int virtnet_alloc_queues(struct virtnet_info *vi)
>  	INIT_DELAYED_WORK(&vi->refill, refill_work);
>  	for (i = 0; i < vi->max_queue_pairs; i++) {
>  		vi->rq[i].pages = NULL;
> -		netif_napi_add(vi->dev, &vi->rq[i].napi, virtnet_poll,
> -			       napi_weight);
> +		netif_napi_add_weight(vi->dev, &vi->rq[i].napi, virtnet_poll,
> +				      napi_weight);
>  		netif_napi_add_tx_weight(vi->dev, &vi->sq[i].napi,
>  					 virtnet_poll_tx,
>  					 napi_tx ? napi_weight : 0);
> -- 
> 2.34.1


  parent reply	other threads:[~2022-05-07  6:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 17:07 [PATCH net-next 0/6] net: switch drivers to netif_napi_add_weight() Jakub Kicinski
2022-05-06 17:07 ` [PATCH net-next 1/6] um: vector: switch " Jakub Kicinski
2022-05-06 17:07   ` Jakub Kicinski
2022-05-06 17:07 ` [PATCH net-next 2/6] caif_virtio: " Jakub Kicinski
2022-05-07  6:55   ` Michael S. Tsirkin
2022-05-06 17:07 ` [PATCH net-next 3/6] eth: " Jakub Kicinski
2022-05-11 17:57   ` Edward Cree
2022-05-11 19:45     ` Jakub Kicinski
2022-05-11 21:02       ` Edward Cree
2022-05-12  7:27         ` Martin Habets
2022-05-06 17:07 ` [PATCH net-next 4/6] r8152: " Jakub Kicinski
2022-05-06 17:07 ` [PATCH net-next 5/6] net: virtio: " Jakub Kicinski
2022-05-07  1:38   ` Xuan Zhuo
2022-05-07  1:38     ` Xuan Zhuo
2022-05-07  3:08   ` Jason Wang
2022-05-07  3:08     ` Jason Wang
2022-05-07  6:55   ` Michael S. Tsirkin [this message]
2022-05-07  6:55     ` Michael S. Tsirkin
2022-05-06 17:07 ` [PATCH net-next 6/6] net: wan: " Jakub Kicinski
2022-05-06 17:07   ` Jakub Kicinski
2022-05-08 10:50 ` [PATCH net-next 0/6] net: switch drivers " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507025428-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.