From: David Disseldorp <ddiss@suse.de>
To: fdmanana@kernel.org
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
zlang@kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: Re: [Resend PATCH] generic: test fsync of directory with renamed symlink
Date: Mon, 9 May 2022 14:15:08 +0200 [thread overview]
Message-ID: <20220509141508.6647bc5f@suse.de> (raw)
In-Reply-To: <8f06924cda35f9a5e22c1c188eb46205dd50491f.1651573756.git.fdmanana@suse.com>
On Tue, 3 May 2022 11:57:49 +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Test that if we fsync a directory, create a symlink inside it, rename
> the symlink, fsync again the directory and then power fail, after the
> filesystem is mounted again, the symlink exists with the new name and
> it has the correct content.
>
> This currently fails on btrfs, because the symlink ends up empty (which
> is illegal on Linux), but it is fixed by kernel commit:
>
> d0e64a981fd841 ("btrfs: always log symlinks in full mode")
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
This looks fine and works for me.
Reviewed-by: David Disseldorp <ddiss@suse.de>
...
> +mkdir $SCRATCH_MNT/testdir
nit: It's worth quoting the variable here (and elsewhere). That said, I
highly doubt anyone is using a SCRATCH_MNT with a space in it, so it
should be okay as is.
Cheers, David
next prev parent reply other threads:[~2022-05-09 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 10:57 [Resend PATCH] generic: test fsync of directory with renamed symlink fdmanana
2022-05-09 10:03 ` Filipe Manana
2022-05-09 11:13 ` Zorro Lang
2022-05-09 11:32 ` Filipe Manana
2022-05-09 13:08 ` Zorro Lang
2022-05-09 12:15 ` David Disseldorp [this message]
2022-05-09 12:45 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509141508.6647bc5f@suse.de \
--to=ddiss@suse.de \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.