All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fuad Tabba <tabba@google.com>
To: kvmarm@lists.cs.columbia.edu
Cc: kernel-team@android.com, maz@kernel.org, catalin.marinas@arm.com,
	will@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] KVM: arm64: Repack struct kvm_pmu to reduce size
Date: Tue, 10 May 2022 09:57:08 +0000	[thread overview]
Message-ID: <20220510095710.148178-3-tabba@google.com> (raw)
In-Reply-To: <20220510095710.148178-1-tabba@google.com>

struct kvm_pmu has 2 holes using 10 bytes. This is instantiated
in all vcpus, so it adds up. Repack the structures to remove the
holes.

No functional change intended.

Reviewed-by: Oliver Upton <oupton@google.com>
Signed-off-by: Fuad Tabba <tabba@google.com>
---
 include/kvm/arm_pmu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h
index 20193416d214..eaa8290b116f 100644
--- a/include/kvm/arm_pmu.h
+++ b/include/kvm/arm_pmu.h
@@ -21,12 +21,12 @@ struct kvm_pmc {
 };
 
 struct kvm_pmu {
-	int irq_num;
+	struct irq_work overflow_work;
 	struct kvm_pmc pmc[ARMV8_PMU_MAX_COUNTERS];
 	DECLARE_BITMAP(chained, ARMV8_PMU_MAX_COUNTER_PAIRS);
+	int irq_num;
 	bool created;
 	bool irq_level;
-	struct irq_work overflow_work;
 };
 
 struct arm_pmu_entry {
-- 
2.36.0.512.ge40c2bad7a-goog

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Fuad Tabba <tabba@google.com>
To: kvmarm@lists.cs.columbia.edu
Cc: maz@kernel.org, will@kernel.org, qperret@google.com,
	james.morse@arm.com,  alexandru.elisei@arm.com,
	suzuki.poulose@arm.com, catalin.marinas@arm.com,
	 drjones@redhat.com, oupton@google.com,
	linux-arm-kernel@lists.infradead.org, tabba@google.com,
	kernel-team@android.com
Subject: [PATCH v4 2/4] KVM: arm64: Repack struct kvm_pmu to reduce size
Date: Tue, 10 May 2022 09:57:08 +0000	[thread overview]
Message-ID: <20220510095710.148178-3-tabba@google.com> (raw)
In-Reply-To: <20220510095710.148178-1-tabba@google.com>

struct kvm_pmu has 2 holes using 10 bytes. This is instantiated
in all vcpus, so it adds up. Repack the structures to remove the
holes.

No functional change intended.

Reviewed-by: Oliver Upton <oupton@google.com>
Signed-off-by: Fuad Tabba <tabba@google.com>
---
 include/kvm/arm_pmu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h
index 20193416d214..eaa8290b116f 100644
--- a/include/kvm/arm_pmu.h
+++ b/include/kvm/arm_pmu.h
@@ -21,12 +21,12 @@ struct kvm_pmc {
 };
 
 struct kvm_pmu {
-	int irq_num;
+	struct irq_work overflow_work;
 	struct kvm_pmc pmc[ARMV8_PMU_MAX_COUNTERS];
 	DECLARE_BITMAP(chained, ARMV8_PMU_MAX_COUNTER_PAIRS);
+	int irq_num;
 	bool created;
 	bool irq_level;
-	struct irq_work overflow_work;
 };
 
 struct arm_pmu_entry {
-- 
2.36.0.512.ge40c2bad7a-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-10  9:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  9:57 [PATCH v4 0/4] KVM: arm64: Do not communicate host pmu event changes by accessing hyp data Fuad Tabba
2022-05-10  9:57 ` Fuad Tabba
2022-05-10  9:57 ` [PATCH v4 1/4] KVM: arm64: Wrapper for getting pmu_events Fuad Tabba
2022-05-10  9:57   ` Fuad Tabba
2022-05-10  9:57 ` Fuad Tabba [this message]
2022-05-10  9:57   ` [PATCH v4 2/4] KVM: arm64: Repack struct kvm_pmu to reduce size Fuad Tabba
2022-05-10  9:57 ` [PATCH v4 3/4] KVM: arm64: Pass pmu events to hyp via vcpu Fuad Tabba
2022-05-10  9:57   ` Fuad Tabba
2022-05-10 18:07   ` Oliver Upton
2022-05-10 18:07     ` Oliver Upton
2022-05-10  9:57 ` [PATCH v4 4/4] KVM: arm64: Reenable pmu in Protected Mode Fuad Tabba
2022-05-10  9:57   ` Fuad Tabba
2022-05-10 18:07   ` Oliver Upton
2022-05-10 18:07     ` Oliver Upton
2022-05-15 10:29 ` [PATCH v4 0/4] KVM: arm64: Do not communicate host pmu event changes by accessing hyp data Marc Zyngier
2022-05-15 10:29   ` Marc Zyngier
2022-05-15 10:57 ` Marc Zyngier
2022-05-15 10:57   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220510095710.148178-3-tabba@google.com \
    --to=tabba@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.