From: Jakub Kicinski <kuba@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: tag_mtk: add padding for tx packets
Date: Tue, 10 May 2022 14:26:06 -0700 [thread overview]
Message-ID: <20220510142606.34d83121@kernel.org> (raw)
In-Reply-To: <20220510094014.68440-1-nbd@nbd.name>
On Tue, 10 May 2022 11:40:13 +0200 Felix Fietkau wrote:
> Padding for transmitted packets needs to account for the special tag.
> With not enough padding, garbage bytes are inserted by the switch at the
> end of small packets.
>
> Fixes: 5cd8985a1909 ("net-next: dsa: add Mediatek tag RX/TX handler")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
You should answer all questions and address or dispute all feedback.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: tag_mtk: add padding for tx packets
Date: Tue, 10 May 2022 14:26:06 -0700 [thread overview]
Message-ID: <20220510142606.34d83121@kernel.org> (raw)
In-Reply-To: <20220510094014.68440-1-nbd@nbd.name>
On Tue, 10 May 2022 11:40:13 +0200 Felix Fietkau wrote:
> Padding for transmitted packets needs to account for the special tag.
> With not enough padding, garbage bytes are inserted by the switch at the
> end of small packets.
>
> Fixes: 5cd8985a1909 ("net-next: dsa: add Mediatek tag RX/TX handler")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
You should answer all questions and address or dispute all feedback.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: tag_mtk: add padding for tx packets
Date: Tue, 10 May 2022 14:26:06 -0700 [thread overview]
Message-ID: <20220510142606.34d83121@kernel.org> (raw)
In-Reply-To: <20220510094014.68440-1-nbd@nbd.name>
On Tue, 10 May 2022 11:40:13 +0200 Felix Fietkau wrote:
> Padding for transmitted packets needs to account for the special tag.
> With not enough padding, garbage bytes are inserted by the switch at the
> end of small packets.
>
> Fixes: 5cd8985a1909 ("net-next: dsa: add Mediatek tag RX/TX handler")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
You should answer all questions and address or dispute all feedback.
next prev parent reply other threads:[~2022-05-10 21:26 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 9:40 [PATCH v2] net: dsa: tag_mtk: add padding for tx packets Felix Fietkau
2022-05-10 9:40 ` Felix Fietkau
2022-05-10 9:40 ` Felix Fietkau
2022-05-10 12:37 ` Vladimir Oltean
2022-05-10 12:37 ` Vladimir Oltean
2022-05-10 12:37 ` Vladimir Oltean
2022-05-10 14:52 ` Felix Fietkau
2022-05-10 14:52 ` Felix Fietkau
2022-05-10 14:52 ` Felix Fietkau
2022-05-10 16:52 ` Vladimir Oltean
2022-05-10 16:52 ` Vladimir Oltean
2022-05-10 16:52 ` Vladimir Oltean
2022-05-10 22:06 ` Felix Fietkau
2022-05-10 22:06 ` Felix Fietkau
2022-05-10 22:06 ` Felix Fietkau
2022-05-10 22:21 ` Vladimir Oltean
2022-05-10 22:21 ` Vladimir Oltean
2022-05-10 22:21 ` Vladimir Oltean
2022-05-11 8:50 ` Felix Fietkau
2022-05-11 8:50 ` Felix Fietkau
2022-05-11 8:50 ` Felix Fietkau
2022-05-11 9:32 ` Vladimir Oltean
2022-05-11 9:32 ` Vladimir Oltean
2022-05-11 9:32 ` Vladimir Oltean
2022-05-11 12:24 ` Felix Fietkau
2022-05-11 12:24 ` Felix Fietkau
2022-05-11 12:24 ` Felix Fietkau
2022-05-11 13:22 ` Vladimir Oltean
2022-05-11 13:22 ` Vladimir Oltean
2022-05-11 13:22 ` Vladimir Oltean
2022-05-11 14:32 ` Andrew Lunn
2022-05-11 14:32 ` Andrew Lunn
2022-05-11 14:32 ` Andrew Lunn
2022-05-12 8:51 ` Felix Fietkau
2022-05-12 8:51 ` Felix Fietkau
2022-05-12 8:51 ` Felix Fietkau
2022-05-12 12:39 ` Andrew Lunn
2022-05-12 12:39 ` Andrew Lunn
2022-05-12 12:39 ` Andrew Lunn
2022-05-12 13:08 ` Felix Fietkau
2022-05-12 13:08 ` Felix Fietkau
2022-05-12 13:08 ` Felix Fietkau
2022-05-12 15:32 ` Andrew Lunn
2022-05-12 15:32 ` Andrew Lunn
2022-05-12 15:32 ` Andrew Lunn
2022-05-11 14:39 ` Andrew Lunn
2022-05-11 14:39 ` Andrew Lunn
2022-05-11 14:39 ` Andrew Lunn
2022-05-10 21:26 ` Jakub Kicinski [this message]
2022-05-10 21:26 ` Jakub Kicinski
2022-05-10 21:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510142606.34d83121@kernel.org \
--to=kuba@kernel.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.