From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support
Date: Wed, 11 May 2022 18:09:49 +0800 [thread overview]
Message-ID: <20220511100949.GG122876@MiWiFi-R3L-srv> (raw)
In-Reply-To: <2da2e67a-864e-246b-b9d0-673c7af937b4@oracle.com>
On 05/09/22 at 10:43am, Eric DeVolder wrote:
>
>
> On 5/6/22 02:12, Baoquan He wrote:
> > On 05/05/22 at 02:45pm, Eric DeVolder wrote:
> > ......
> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > > index 256cf6db573c..f197af50def6 100644
> > > --- a/kernel/crash_core.c
> > > +++ b/kernel/crash_core.c
> > > @@ -9,12 +9,17 @@
> > > #include <linux/init.h>
> > > #include <linux/utsname.h>
> > > #include <linux/vmalloc.h>
> > > +#include <linux/highmem.h>
> >
> > Wondering where highmem.h is needed. Just curious.
>
> Ahh, I missed that. At one point in time we moved map_crash_pages() into
> this file, which brought highmem.h along with it. But we have since moved
> map_crash_pages() into x86/crash.c. And I missed eliminating highmem.h at
> that time.
>
> I have removed this for v9.
That's nice, and you can add my ack when repost.
Acked-by: Baoquan He <bhe@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Eric DeVolder <eric.devolder@oracle.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, ebiederm@xmission.com,
dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, nramas@linux.microsoft.com,
thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de,
rppt@kernel.org, david@redhat.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support
Date: Wed, 11 May 2022 18:09:49 +0800 [thread overview]
Message-ID: <20220511100949.GG122876@MiWiFi-R3L-srv> (raw)
In-Reply-To: <2da2e67a-864e-246b-b9d0-673c7af937b4@oracle.com>
On 05/09/22 at 10:43am, Eric DeVolder wrote:
>
>
> On 5/6/22 02:12, Baoquan He wrote:
> > On 05/05/22 at 02:45pm, Eric DeVolder wrote:
> > ......
> > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > > index 256cf6db573c..f197af50def6 100644
> > > --- a/kernel/crash_core.c
> > > +++ b/kernel/crash_core.c
> > > @@ -9,12 +9,17 @@
> > > #include <linux/init.h>
> > > #include <linux/utsname.h>
> > > #include <linux/vmalloc.h>
> > > +#include <linux/highmem.h>
> >
> > Wondering where highmem.h is needed. Just curious.
>
> Ahh, I missed that. At one point in time we moved map_crash_pages() into
> this file, which brought highmem.h along with it. But we have since moved
> map_crash_pages() into x86/crash.c. And I missed eliminating highmem.h at
> that time.
>
> I have removed this for v9.
That's nice, and you can add my ack when repost.
Acked-by: Baoquan He <bhe@redhat.com>
next prev parent reply other threads:[~2022-05-11 10:09 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 18:45 [PATCH v8 0/7] crash: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2022-05-05 18:45 ` Eric DeVolder
2022-05-05 18:45 ` [PATCH v8 1/7] x86/crash: fix minor typo/bug in debug message Eric DeVolder
2022-05-05 18:45 ` Eric DeVolder
[not found] ` <72764a3c-8b8c-8652-945e-9b15f31cda15@linux.ibm.com>
2022-05-09 5:26 ` Baoquan He
2022-05-09 5:26 ` Baoquan He
2022-05-09 15:41 ` Eric DeVolder
2022-05-09 15:41 ` Eric DeVolder
2022-05-05 18:45 ` [PATCH v8 2/7] crash: prototype change for crash_prepare_elf64_headers Eric DeVolder
2022-05-05 18:45 ` Eric DeVolder
2022-05-12 8:42 ` David Hildenbrand
2022-05-12 8:42 ` David Hildenbrand
2022-05-12 16:10 ` Eric DeVolder
2022-05-12 16:10 ` Eric DeVolder
2022-05-05 18:45 ` [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support Eric DeVolder
2022-05-05 18:45 ` Eric DeVolder
2022-05-06 7:12 ` Baoquan He
2022-05-06 7:12 ` Baoquan He
2022-05-09 15:43 ` Eric DeVolder
2022-05-09 15:43 ` Eric DeVolder
2022-05-11 10:09 ` Baoquan He [this message]
2022-05-11 10:09 ` Baoquan He
2022-05-12 8:52 ` David Hildenbrand
2022-05-12 8:52 ` David Hildenbrand
2022-05-12 16:10 ` Eric DeVolder
2022-05-12 16:10 ` Eric DeVolder
2022-05-31 13:15 ` David Hildenbrand
2022-05-31 13:15 ` David Hildenbrand
2022-05-31 22:25 ` Eric DeVolder
2022-05-31 22:25 ` Eric DeVolder
2022-06-15 9:53 ` David Hildenbrand
2022-06-15 9:53 ` David Hildenbrand
2022-05-23 8:36 ` Sourabh Jain
2022-05-23 8:36 ` Sourabh Jain
2022-05-23 15:04 ` Eric DeVolder
2022-05-23 15:04 ` Eric DeVolder
2022-05-05 18:46 ` [PATCH v8 4/7] kexec: exclude elfcorehdr from the segment digest Eric DeVolder
2022-05-05 18:46 ` Eric DeVolder
2022-05-11 10:11 ` Baoquan He
2022-05-11 10:11 ` Baoquan He
2022-05-05 18:46 ` [PATCH v8 5/7] kexec: exclude hot remove cpu from elfcorehdr notes Eric DeVolder
2022-05-05 18:46 ` Eric DeVolder
2022-05-11 10:13 ` Baoquan He
2022-05-11 10:13 ` Baoquan He
2022-05-05 18:46 ` [PATCH v8 6/7] x86/crash: Add x86 crash hotplug support for kexec_file_load Eric DeVolder
2022-05-05 18:46 ` Eric DeVolder
2022-05-25 5:25 ` Sourabh Jain
2022-05-25 5:25 ` Sourabh Jain
2022-05-25 13:51 ` Eric DeVolder
2022-05-25 13:51 ` Eric DeVolder
2022-05-05 18:46 ` [PATCH v8 7/7] x86/crash: Add x86 crash hotplug support for kexec_load Eric DeVolder
2022-05-05 18:46 ` Eric DeVolder
2022-05-25 14:26 ` Sourabh Jain
2022-05-25 14:26 ` Sourabh Jain
2022-05-31 22:18 ` Eric DeVolder
2022-05-31 22:18 ` Eric DeVolder
2022-05-25 15:13 ` [PATCH v8 0/7] crash: Kernel handling of CPU and memory hot un/plug Sourabh Jain
2022-05-25 15:13 ` Sourabh Jain
2022-05-26 13:16 ` Eric DeVolder
2022-05-26 13:16 ` Eric DeVolder
2022-05-26 13:39 ` Sourabh Jain
2022-05-26 13:39 ` Sourabh Jain
2022-05-26 13:44 ` Eric DeVolder
2022-05-26 13:44 ` Eric DeVolder
2022-05-31 13:18 ` David Hildenbrand
2022-05-31 13:18 ` David Hildenbrand
2022-05-31 22:22 ` Eric DeVolder
2022-05-31 22:22 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511100949.GG122876@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.