Re: [PATCH] f2fs: fix error code in f2fs_ioc_start_atomic_write()

[Dan Carpenter <dan.carpenter@oracle.com>]

On Wed, May 11, 2022 at 10:37:57AM -0700, Jaegeuk Kim wrote:
> Hi Dan,
> 
> Thank you for the fix. If you don't mind, can I integrate this fix into
> the original patch which is in -next?
> 

Yeah, that's not a problem.  Feel free.

regards,
dan carpenter

> Thanks,
> 
> On 05/11, Dan Carpenter wrote:
> > Return an error code if f2fs_iget() fails.  Currently it returns
> > success.
> > 
> > Fixes: 3d7ad9c30607 ("f2fs: change the current atomic write way")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  fs/f2fs/file.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 79d1a20fbda9..cd768fadfd67 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -2047,6 +2047,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> >  	pinode = f2fs_iget(inode->i_sb, fi->i_pino);
> >  	if (IS_ERR(pinode)) {
> >  		f2fs_up_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
> > +		ret = PTR_ERR(pinode);
> >  		goto out;
> >  	}
> >  
> > -- 
> > 2.35.1