From: Miles Chen <miles.chen@mediatek.com>
To: <wenst@chromium.org>
Cc: <angelogioacchino.delregno@collabora.com>,
<chun-jie.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<miles.chen@mediatek.com>, <mturquette@baylibre.com>,
<rex-bc.chen@mediatek.com>, <sboyd@kernel.org>
Subject: Re: [PATCH v2 02/11] clk: mediatek: apmixed: Drop error message from clk_register() failure
Date: Thu, 12 May 2022 21:54:17 +0800 [thread overview]
Message-ID: <20220512135417.4399-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220510104804.544597-3-wenst@chromium.org>
> mtk_clk_register_ref2usb_tx() prints an error message if clk_register()
> fails. It doesn't if kzalloc() fails though. The caller would then tack
> on its own error message to handle this.
>
> Also, All other clk registration functions in the MediaTek clk library
> leave the error message printing to the bulk registration functions,
> while the helpers that register individual clks just return error codes.
>
> Drop the error message that is printed when clk_register() fails in
> mtk_clk_register_ref2usb_tx() to make its behavior consistent both
> across its failure modes, and with the rest of the driver library.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <wenst@chromium.org>
Cc: <angelogioacchino.delregno@collabora.com>,
<chun-jie.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<miles.chen@mediatek.com>, <mturquette@baylibre.com>,
<rex-bc.chen@mediatek.com>, <sboyd@kernel.org>
Subject: Re: [PATCH v2 02/11] clk: mediatek: apmixed: Drop error message from clk_register() failure
Date: Thu, 12 May 2022 21:54:17 +0800 [thread overview]
Message-ID: <20220512135417.4399-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220510104804.544597-3-wenst@chromium.org>
> mtk_clk_register_ref2usb_tx() prints an error message if clk_register()
> fails. It doesn't if kzalloc() fails though. The caller would then tack
> on its own error message to handle this.
>
> Also, All other clk registration functions in the MediaTek clk library
> leave the error message printing to the bulk registration functions,
> while the helpers that register individual clks just return error codes.
>
> Drop the error message that is printed when clk_register() fails in
> mtk_clk_register_ref2usb_tx() to make its behavior consistent both
> across its failure modes, and with the rest of the driver library.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <wenst@chromium.org>
Cc: <angelogioacchino.delregno@collabora.com>,
<chun-jie.chen@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<miles.chen@mediatek.com>, <mturquette@baylibre.com>,
<rex-bc.chen@mediatek.com>, <sboyd@kernel.org>
Subject: Re: [PATCH v2 02/11] clk: mediatek: apmixed: Drop error message from clk_register() failure
Date: Thu, 12 May 2022 21:54:17 +0800 [thread overview]
Message-ID: <20220512135417.4399-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220510104804.544597-3-wenst@chromium.org>
> mtk_clk_register_ref2usb_tx() prints an error message if clk_register()
> fails. It doesn't if kzalloc() fails though. The caller would then tack
> on its own error message to handle this.
>
> Also, All other clk registration functions in the MediaTek clk library
> leave the error message printing to the bulk registration functions,
> while the helpers that register individual clks just return error codes.
>
> Drop the error message that is printed when clk_register() fails in
> mtk_clk_register_ref2usb_tx() to make its behavior consistent both
> across its failure modes, and with the rest of the driver library.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-12 13:54 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 10:47 [PATCH v2 00/11] clk: mediatek: Move to struct clk_hw provider APIs Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` [PATCH v2 01/11] clk: mediatek: Make mtk_clk_register_composite() static Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-12 2:36 ` Miles Chen
2022-05-12 2:36 ` Miles Chen
2022-05-12 2:36 ` Miles Chen
2022-05-10 10:47 ` [PATCH v2 02/11] clk: mediatek: apmixed: Drop error message from clk_register() failure Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-12 13:54 ` Miles Chen [this message]
2022-05-12 13:54 ` Miles Chen
2022-05-12 13:54 ` Miles Chen
2022-05-10 10:47 ` [PATCH v2 03/11] clk: mediatek: Convert mtk_{alloc,free}_clk_data to struct clk_hw Chen-Yu Tsai
2022-05-10 10:47 ` [PATCH v2 03/11] clk: mediatek: Convert mtk_{alloc, free}_clk_data " Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-12 14:05 ` [PATCH v2 03/11] clk: mediatek: Convert mtk_{alloc,free}_clk_data " Miles Chen
2022-05-12 14:05 ` [PATCH v2 03/11] clk: mediatek: Convert mtk_{alloc, free}_clk_data " Miles Chen
2022-05-12 14:05 ` Miles Chen
2022-05-10 10:47 ` [PATCH v2 04/11] clk: mediatek: Replace 'struct clk' with 'struct clk_hw' Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-12 14:18 ` Miles Chen
2022-05-12 14:18 ` Miles Chen
2022-05-12 14:18 ` Miles Chen
2022-05-10 10:47 ` [PATCH v2 05/11] clk: mediatek: mt27xx: " Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-12 14:49 ` Miles Chen
2022-05-12 14:49 ` Miles Chen
2022-05-12 14:49 ` Miles Chen
2022-05-13 3:24 ` Chen-Yu Tsai
2022-05-13 3:24 ` Chen-Yu Tsai
2022-05-13 3:24 ` Chen-Yu Tsai
2022-05-14 16:51 ` Miles Chen
2022-05-14 16:51 ` Miles Chen
2022-05-14 16:51 ` Miles Chen
2022-05-10 10:47 ` [PATCH v2 06/11] clk: mediatek: mt67xx: " Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-10 10:47 ` Chen-Yu Tsai
2022-05-14 17:02 ` Miles Chen
2022-05-14 17:02 ` Miles Chen
2022-05-14 17:02 ` Miles Chen
2022-05-10 10:48 ` [PATCH v2 07/11] clk: mediatek: mt7xxx: " Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-14 17:03 ` Miles Chen
2022-05-14 17:03 ` Miles Chen
2022-05-14 17:03 ` Miles Chen
2022-05-10 10:48 ` [PATCH v2 08/11] clk: mediatek: mt8xxx: " Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-14 17:04 ` Miles Chen
2022-05-14 17:04 ` Miles Chen
2022-05-14 17:04 ` Miles Chen
2022-05-10 10:48 ` [PATCH v2 09/11] clk: mediatek: Switch to clk_hw provider APIs Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-14 17:05 ` Miles Chen
2022-05-14 17:05 ` Miles Chen
2022-05-14 17:05 ` Miles Chen
2022-05-10 10:48 ` [PATCH v2 10/11] clk: mediatek: mt8173: Fix usage of mtk_clk_register_ref2usb_tx() Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-14 17:06 ` Miles Chen
2022-05-14 17:06 ` Miles Chen
2022-05-14 17:06 ` Miles Chen
2022-05-10 10:48 ` [PATCH v2 11/11] clk: mediatek: mt8173: Switch to clk_hw provider APIs Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-10 10:48 ` Chen-Yu Tsai
2022-05-14 17:07 ` Miles Chen
2022-05-14 17:07 ` Miles Chen
2022-05-14 17:07 ` Miles Chen
2022-05-11 8:03 ` [PATCH v2 00/11] clk: mediatek: Move to struct " AngeloGioacchino Del Regno
2022-05-11 8:03 ` AngeloGioacchino Del Regno
2022-05-11 8:03 ` AngeloGioacchino Del Regno
2022-05-14 17:11 ` Miles Chen
2022-05-14 17:11 ` Miles Chen
2022-05-14 17:11 ` Miles Chen
2022-05-18 21:45 ` Stephen Boyd
2022-05-18 21:45 ` Stephen Boyd
2022-05-18 21:45 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512135417.4399-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=rex-bc.chen@mediatek.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.