From: Dan Cross <cross@oxidecomputer.com>
To: kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Dan Cross <cross@oxidecomputer.com>
Subject: [PATCH 1/2] kvm-unit-tests: invoke $LD explicitly in
Date: Fri, 13 May 2022 01:07:39 +0000 [thread overview]
Message-ID: <20220513010740.8544-2-cross@oxidecomputer.com> (raw)
In-Reply-To: <20220513010740.8544-1-cross@oxidecomputer.com>
This change modifies x86/Makefile.common to allow building on
illumos; I have also tested it on Linux. This switches from
using the C compiler as a linker driver to simply invoking the
linker directly in two places, allowing us to easily use gold
instead of the Solaris linker.
Signed-off-by: Dan Cross <cross@oxidecomputer.com>
---
x86/Makefile.common | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/x86/Makefile.common b/x86/Makefile.common
index b903988..0a0f7b9 100644
--- a/x86/Makefile.common
+++ b/x86/Makefile.common
@@ -62,7 +62,7 @@ else
.PRECIOUS: %.elf %.o
%.elf: %.o $(FLATLIBS) $(SRCDIR)/x86/flat.lds $(cstart.o)
- $(CC) $(CFLAGS) -nostdlib -o $@ -Wl,-T,$(SRCDIR)/x86/flat.lds \
+ $(LD) -T $(SRCDIR)/x86/flat.lds -nostdlib -o $@ \
$(filter %.o, $^) $(FLATLIBS)
@chmod a-x $@
@@ -98,8 +98,8 @@ test_cases: $(tests-common) $(tests)
$(TEST_DIR)/%.o: CFLAGS += -std=gnu99 -ffreestanding -I $(SRCDIR)/lib -I $(SRCDIR)/lib/x86 -I lib
$(TEST_DIR)/realmode.elf: $(TEST_DIR)/realmode.o
- $(CC) -m32 -nostdlib -o $@ -Wl,-m,elf_i386 \
- -Wl,-T,$(SRCDIR)/$(TEST_DIR)/realmode.lds $^
+ $(LD) -m elf_i386 -nostdlib -o $@ \
+ -T $(SRCDIR)/$(TEST_DIR)/realmode.lds $^
$(TEST_DIR)/realmode.o: bits = $(if $(call cc-option,-m16,""),16,32)
--
2.31.1
next prev parent reply other threads:[~2022-05-13 1:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 20:45 [PATCH] kvm-unit-tests: Build changes for illumos Dan Cross
2022-05-12 22:05 ` Sean Christopherson
2022-05-13 1:07 ` [PATCH 0/2] kvm-unit-tests: Build changes to support illumos Dan Cross
2022-05-13 1:07 ` Dan Cross [this message]
2022-05-13 1:07 ` [PATCH 2/2] kvm-unit-tests: configure changes for illumos Dan Cross
2022-05-13 14:34 ` Sean Christopherson
2022-05-19 9:53 ` Thomas Huth
2022-05-24 21:20 ` Dan Cross
2022-05-25 7:41 ` Thomas Huth
2022-05-24 21:22 ` Dan Cross
2022-05-25 7:44 ` Thomas Huth
2022-05-26 7:11 ` Andrew Jones
2022-05-26 17:39 ` [PATCH 0/2] kvm-unit-tests: Build changes to support illumos Dan Cross
2022-05-26 17:39 ` [PATCH 1/2] kvm-unit-tests: invoke $LD explicitly in Dan Cross
2022-05-26 21:17 ` Sean Christopherson
2022-06-01 7:03 ` Thomas Huth
2022-06-01 17:09 ` Dan Cross
2022-06-01 17:43 ` Andrew Jones
2022-06-01 21:51 ` Dan Cross
2022-06-01 21:57 ` [PATCH v4 0/2] kvm-unit-tests: Build changes to support illumos Dan Cross
2022-06-01 21:57 ` [PATCH v4 1/2] kvm-unit-tests: configure changes for illumos Dan Cross
2022-06-01 21:57 ` [PATCH v4 2/2] kvm-unit-tests: invoke $LD explicitly Dan Cross
2022-06-02 10:53 ` [PATCH v4 0/2] kvm-unit-tests: Build changes to support illumos Thomas Huth
2022-06-02 11:32 ` Dan Cross
2022-05-26 17:39 ` [PATCH 2/2] kvm-unit-tests: configure changes for illumos Dan Cross
2022-05-26 21:23 ` Sean Christopherson
2022-05-26 22:17 ` Dan Cross
2022-05-27 14:41 ` Sean Christopherson
2022-05-31 17:02 ` Dan Cross
2022-05-26 17:40 ` Dan Cross
[not found] ` <CAA9fzEGdi0k8bkyXQwvt6gFd-gwHNNFF7A89U4DhtGHjKqe4AQ@mail.gmail.com>
2022-05-13 1:27 ` Fwd: [PATCH] kvm-unit-tests: Build " Dan Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513010740.8544-2-cross@oxidecomputer.com \
--to=cross@oxidecomputer.com \
--cc=kvm@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.