From: Sean Christopherson <seanjc@google.com>
To: Dan Cross <cross@oxidecomputer.com>
Cc: kvm@vger.kernel.org, Andrew Jones <drjones@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] kvm-unit-tests: configure changes for illumos.
Date: Fri, 27 May 2022 14:41:29 +0000 [thread overview]
Message-ID: <YpDjGdzsX+VHy1R8@google.com> (raw)
In-Reply-To: <CAA9fzEFF=fdfV7qE-PU5fMD+XyrskQjvxPbgZ1yyS4fRTeBO2g@mail.gmail.com>
On Thu, May 26, 2022, Dan Cross wrote:
> On Thu, May 26, 2022 at 5:23 PM Sean Christopherson <seanjc@google.com> wrote:
> > Why not simply move the check to run_tests.sh? I can't imaging it's performance
> > sensitive, and I doubt I'm the only one that builds tests on one system and runs
> > them on a completely different system.
>
> `run_tests.sh` already has the test. Changing it to a warning here
> was at the suggestion of Thomas and Drew.
Ah, hence the earlier comment about removing the check entirely. Either works
for me, thanks!
next prev parent reply other threads:[~2022-05-27 14:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 20:45 [PATCH] kvm-unit-tests: Build changes for illumos Dan Cross
2022-05-12 22:05 ` Sean Christopherson
2022-05-13 1:07 ` [PATCH 0/2] kvm-unit-tests: Build changes to support illumos Dan Cross
2022-05-13 1:07 ` [PATCH 1/2] kvm-unit-tests: invoke $LD explicitly in Dan Cross
2022-05-13 1:07 ` [PATCH 2/2] kvm-unit-tests: configure changes for illumos Dan Cross
2022-05-13 14:34 ` Sean Christopherson
2022-05-19 9:53 ` Thomas Huth
2022-05-24 21:20 ` Dan Cross
2022-05-25 7:41 ` Thomas Huth
2022-05-24 21:22 ` Dan Cross
2022-05-25 7:44 ` Thomas Huth
2022-05-26 7:11 ` Andrew Jones
2022-05-26 17:39 ` [PATCH 0/2] kvm-unit-tests: Build changes to support illumos Dan Cross
2022-05-26 17:39 ` [PATCH 1/2] kvm-unit-tests: invoke $LD explicitly in Dan Cross
2022-05-26 21:17 ` Sean Christopherson
2022-06-01 7:03 ` Thomas Huth
2022-06-01 17:09 ` Dan Cross
2022-06-01 17:43 ` Andrew Jones
2022-06-01 21:51 ` Dan Cross
2022-06-01 21:57 ` [PATCH v4 0/2] kvm-unit-tests: Build changes to support illumos Dan Cross
2022-06-01 21:57 ` [PATCH v4 1/2] kvm-unit-tests: configure changes for illumos Dan Cross
2022-06-01 21:57 ` [PATCH v4 2/2] kvm-unit-tests: invoke $LD explicitly Dan Cross
2022-06-02 10:53 ` [PATCH v4 0/2] kvm-unit-tests: Build changes to support illumos Thomas Huth
2022-06-02 11:32 ` Dan Cross
2022-05-26 17:39 ` [PATCH 2/2] kvm-unit-tests: configure changes for illumos Dan Cross
2022-05-26 21:23 ` Sean Christopherson
2022-05-26 22:17 ` Dan Cross
2022-05-27 14:41 ` Sean Christopherson [this message]
2022-05-31 17:02 ` Dan Cross
2022-05-26 17:40 ` Dan Cross
[not found] ` <CAA9fzEGdi0k8bkyXQwvt6gFd-gwHNNFF7A89U4DhtGHjKqe4AQ@mail.gmail.com>
2022-05-13 1:27 ` Fwd: [PATCH] kvm-unit-tests: Build " Dan Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpDjGdzsX+VHy1R8@google.com \
--to=seanjc@google.com \
--cc=cross@oxidecomputer.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.