From: Eddie James <eajames@linux.ibm.com>
To: openbmc@lists.ozlabs.org
Cc: cjengel@us.ibm.com, joel@jms.id.au
Subject: [PATCH u-boot v2019.04-aspeed-openbmc v2 6/9] i2c: ast_i2c: Remove SCL direct drive mode
Date: Fri, 13 May 2022 12:07:12 -0500 [thread overview]
Message-ID: <20220513170715.43475-7-eajames@linux.ibm.com> (raw)
In-Reply-To: <20220513170715.43475-1-eajames@linux.ibm.com>
SCL direct drive mode prevents communication with devices that
do clock stretching, so disable. The Linux driver doesn't use
this mode, and the engine can handle clock stretching.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
drivers/i2c/ast_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/ast_i2c.c b/drivers/i2c/ast_i2c.c
index bbc32d6cdb..13420ade84 100644
--- a/drivers/i2c/ast_i2c.c
+++ b/drivers/i2c/ast_i2c.c
@@ -73,7 +73,7 @@ static void ast_i2c_init_bus(struct udevice *dev)
/* Enable Master Mode. Assuming single-master */
writel(I2CD_MASTER_EN
| I2CD_M_SDA_LOCK_EN
- | I2CD_MULTI_MASTER_DIS | I2CD_M_SCL_DRIVE_EN,
+ | I2CD_MULTI_MASTER_DIS,
&priv->regs->fcr);
/* Enable Interrupts */
writel(I2CD_INTR_TX_ACK
--
2.27.0
next prev parent reply other threads:[~2022-05-13 17:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 17:07 [PATCH u-boot v2019.04-aspeed-openbmc v2 0/9] ast2600: Add I2C TPMv2 driver Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 1/9] tpm: Add more TPM2 definitions Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 2/9] tpm: add #ifndef to fix redeclaration build errors Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 3/9] tpm2: Introduce TIS tpm core Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 4/9] tis: fix tpm_tis_remove() Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 5/9] tpm: core: Set timeouts before requesting locality Eddie James
2022-05-13 17:07 ` Eddie James [this message]
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 7/9] tpm: add support for TPMv2.x I2C chips Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 8/9] arm: dts: ast2600-rainier: Add NPCT75X TPM Eddie James
2022-05-13 17:07 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 9/9] board: ast2600-ibm: Add AST2600 BMC based POWER10+ servers Eddie James
2022-05-20 6:30 ` Joel Stanley
2022-05-24 16:42 ` Eddie James
2022-05-20 6:31 ` [PATCH u-boot v2019.04-aspeed-openbmc v2 0/9] ast2600: Add I2C TPMv2 driver Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513170715.43475-7-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=cjengel@us.ibm.com \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.