All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shreenidhi Shedi <yesshedi@gmail.com>
To: arnd@arndb.de, gregkh@linuxfoundation.org, paul@paul-moore.com,
	eparis@redhat.com
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
	Shreenidhi Shedi <sshedi@vmware.com>,
	yesshedi@gmail.com
Subject: [PATCH 1/5] char: lp: ensure that index has not exceeded LP_NO
Date: Sun, 15 May 2022 02:44:51 +0530	[thread overview]
Message-ID: <20220514211455.284782-1-sshedi@vmware.com> (raw)

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 0e22e3b0a04e..d474d02b6c7f 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;
 		break;
 
-- 
2.36.1

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit


WARNING: multiple messages have this Message-ID (diff)
From: Shreenidhi Shedi <yesshedi@gmail.com>
To: arnd@arndb.de, gregkh@linuxfoundation.org, paul@paul-moore.com,
	eparis@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
	yesshedi@gmail.com, Shreenidhi Shedi <sshedi@vmware.com>
Subject: [PATCH 1/5] char: lp: ensure that index has not exceeded LP_NO
Date: Sun, 15 May 2022 02:44:51 +0530	[thread overview]
Message-ID: <20220514211455.284782-1-sshedi@vmware.com> (raw)

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
---
 drivers/char/lp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 0e22e3b0a04e..d474d02b6c7f 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -972,7 +972,7 @@ static void lp_attach(struct parport *port)
 			if (port_num[i] == -1)
 				break;
 
-		if (!lp_register(i, port))
+		if (i < LP_NO && !lp_register(i, port))
 			lp_count++;
 		break;
 
-- 
2.36.1


             reply	other threads:[~2022-05-15 19:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 21:14 Shreenidhi Shedi [this message]
2022-05-14 21:14 ` [PATCH 1/5] char: lp: ensure that index has not exceeded LP_NO Shreenidhi Shedi
2022-05-14 21:14 ` [PATCH 2/5] char: lp: remove redundant initialization of err Shreenidhi Shedi
2022-05-14 21:14   ` Shreenidhi Shedi
2022-05-14 21:53   ` Greg KH
2022-05-14 21:53     ` Greg KH
2022-05-14 21:14 ` [PATCH 3/5] char: lp: fix most of checkspec.pl warnings & errors Shreenidhi Shedi
2022-05-14 21:14   ` Shreenidhi Shedi
2022-05-14 21:53   ` Greg KH
2022-05-14 21:53     ` Greg KH
2022-05-14 21:14 ` [PATCH 4/5] audit: remove redundant data_len check Shreenidhi Shedi
2022-05-14 21:14   ` Shreenidhi Shedi
2022-05-14 21:54   ` Greg KH
2022-05-14 21:54     ` Greg KH
2022-05-15 23:30   ` Paul Moore
2022-05-15 23:30     ` Paul Moore
2022-05-14 21:14 ` [PATCH 5/5] audit: fix most of the checkspec.pl warnnings & errors Shreenidhi Shedi
2022-05-14 21:14   ` Shreenidhi Shedi
2022-05-14 21:54   ` Greg KH
2022-05-14 21:54     ` Greg KH
2022-05-14 21:52 ` [PATCH 1/5] char: lp: ensure that index has not exceeded LP_NO Greg KH
2022-05-14 21:52   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220514211455.284782-1-sshedi@vmware.com \
    --to=yesshedi@gmail.com \
    --cc=arnd@arndb.de \
    --cc=eparis@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=sshedi@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.