All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422
Date: Sun, 15 May 2022 06:41:21 +0000	[thread overview]
Message-ID: <20220515064126.1424-5-linux.amoon@gmail.com> (raw)
In-Reply-To: <20220515064126.1424-1-linux.amoon@gmail.com>

As per Exynos5422 user manaul e-Fuse range min~max range is 16~76.
if e-Fuse value is out of this range, then thermal sensor may not
sense thermal data properly.

Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v1: Fix the commit message
---
 drivers/thermal/samsung/exynos_tmu.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 58ff1b577c47..0faec0f16db6 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -926,12 +926,14 @@ static int exynos_map_dt_data(struct platform_device *pdev)
 		data->gain = 8;
 		data->reference_voltage = 16;
 		data->efuse_value = 55;
-		if (data->soc != SOC_ARCH_EXYNOS5420 &&
-		    data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO)
+		if (data->soc == SOC_ARCH_EXYNOS5420 &&
+		    data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) {
+			data->min_efuse_value = 16;
+			data->max_efuse_value = 76;
+		} else {
 			data->min_efuse_value = 40;
-		else
-			data->min_efuse_value = 0;
-		data->max_efuse_value = 100;
+			data->max_efuse_value = 100;
+		}
 		break;
 	case SOC_ARCH_EXYNOS5433:
 		data->tmu_set_trip_temp = exynos5433_tmu_set_trip_temp;
-- 
2.36.1


WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422
Date: Sun, 15 May 2022 06:41:21 +0000	[thread overview]
Message-ID: <20220515064126.1424-5-linux.amoon@gmail.com> (raw)
In-Reply-To: <20220515064126.1424-1-linux.amoon@gmail.com>

As per Exynos5422 user manaul e-Fuse range min~max range is 16~76.
if e-Fuse value is out of this range, then thermal sensor may not
sense thermal data properly.

Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v1: Fix the commit message
---
 drivers/thermal/samsung/exynos_tmu.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 58ff1b577c47..0faec0f16db6 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -926,12 +926,14 @@ static int exynos_map_dt_data(struct platform_device *pdev)
 		data->gain = 8;
 		data->reference_voltage = 16;
 		data->efuse_value = 55;
-		if (data->soc != SOC_ARCH_EXYNOS5420 &&
-		    data->soc != SOC_ARCH_EXYNOS5420_TRIMINFO)
+		if (data->soc == SOC_ARCH_EXYNOS5420 &&
+		    data->soc == SOC_ARCH_EXYNOS5420_TRIMINFO) {
+			data->min_efuse_value = 16;
+			data->max_efuse_value = 76;
+		} else {
 			data->min_efuse_value = 40;
-		else
-			data->min_efuse_value = 0;
-		data->max_efuse_value = 100;
+			data->max_efuse_value = 100;
+		}
 		break;
 	case SOC_ARCH_EXYNOS5433:
 		data->tmu_set_trip_temp = exynos5433_tmu_set_trip_temp;
-- 
2.36.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-15  6:42 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15  6:41 [PATCHv2 0/6] Exynos Thermal code inprovement Anand Moon
2022-05-15  6:41 ` Anand Moon
2022-05-15  6:41 ` [PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform Anand Moon
2022-05-15  6:41   ` Anand Moon
2022-05-15  9:39   ` Krzysztof Kozlowski
2022-05-15  9:39     ` Krzysztof Kozlowski
2022-05-15  9:52   ` Krzysztof Kozlowski
2022-05-15  9:52     ` Krzysztof Kozlowski
2022-05-17 18:42     ` Anand Moon
2022-05-17 18:42       ` Anand Moon
2022-05-18  7:25       ` Krzysztof Kozlowski
2022-05-18  7:25         ` Krzysztof Kozlowski
2022-05-21  9:50         ` Anand Moon
2022-05-21  9:50           ` Anand Moon
2022-05-21 14:15           ` Krzysztof Kozlowski
2022-05-21 14:15             ` Krzysztof Kozlowski
2022-05-15  6:41 ` [PATCHv2 2/6] thermal: exynos: Reorder the gpu clock initialization for exynos5420 SoC Anand Moon
2022-05-15  6:41   ` Anand Moon
2022-05-15  9:41   ` Krzysztof Kozlowski
2022-05-15  9:41     ` Krzysztof Kozlowski
2022-05-17 18:43     ` Anand Moon
2022-05-17 18:43       ` Anand Moon
2022-05-18  7:28       ` Krzysztof Kozlowski
2022-05-18  7:28         ` Krzysztof Kozlowski
2022-05-21  9:51         ` Anand Moon
2022-05-21  9:51           ` Anand Moon
2022-05-21 14:20           ` Krzysztof Kozlowski
2022-05-21 14:20             ` Krzysztof Kozlowski
2022-05-15  9:50   ` Krzysztof Kozlowski
2022-05-15  9:50     ` Krzysztof Kozlowski
2022-05-17 18:43     ` Anand Moon
2022-05-17 18:43       ` Anand Moon
2022-05-15  6:41 ` [PATCHv2 3/6] thermal: exynos: Check before clk_disable_unprepare() not needed Anand Moon
2022-05-15  6:41   ` Anand Moon
2022-05-15  9:43   ` Krzysztof Kozlowski
2022-05-15  9:43     ` Krzysztof Kozlowski
2022-05-17 18:44     ` Anand Moon
2022-05-17 18:44       ` Anand Moon
2022-05-15  6:41 ` Anand Moon [this message]
2022-05-15  6:41   ` [PATCHv2 4/6] thermal: exynos: fixed the efuse min/max value for exynos5422 Anand Moon
2022-05-15  9:45   ` Krzysztof Kozlowski
2022-05-15  9:45     ` Krzysztof Kozlowski
2022-05-16 10:42   ` kernel test robot
2022-05-16 10:42     ` kernel test robot
2022-05-16 10:44     ` Krzysztof Kozlowski
2022-05-16 10:44       ` Krzysztof Kozlowski
2022-05-16 10:44       ` Krzysztof Kozlowski
2022-05-17 18:44       ` Anand Moon
2022-05-17 18:44         ` Anand Moon
2022-05-17 18:44         ` Anand Moon
2022-05-15  6:41 ` [PATCHv2 5/6] thermal: exynos: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Anand Moon
2022-05-15  6:41   ` Anand Moon
2022-05-15  9:47   ` Krzysztof Kozlowski
2022-05-15  9:47     ` Krzysztof Kozlowski
2022-05-17 18:44     ` Anand Moon
2022-05-17 18:44       ` Anand Moon
2022-05-15  6:41 ` [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu Anand Moon
2022-05-15  6:41   ` Anand Moon
2022-05-15  9:48   ` Krzysztof Kozlowski
2022-05-15  9:48     ` Krzysztof Kozlowski
2022-05-17 18:45     ` Anand Moon
2022-05-17 18:45       ` Anand Moon
2022-05-18  7:19       ` Krzysztof Kozlowski
2022-05-18  7:19         ` Krzysztof Kozlowski
2022-05-21  9:52         ` Anand Moon
2022-05-21  9:52           ` Anand Moon
2022-05-21 14:11           ` Krzysztof Kozlowski
2022-05-21 14:11             ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220515064126.1424-5-linux.amoon@gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=amitk@kernel.org \
    --cc=bzolnier@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.