From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KVM list <kvm@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org, mie@igel.co.jp,
Netdev <netdev@vger.kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [GIT PULL] virtio: last minute fixup
Date: Mon, 16 May 2022 05:03:35 -0400 [thread overview]
Message-ID: <20220516045821-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAHk-=wgnYGY=10sRDzXCC2bmappjBTRNNbr8owvGLEW-xuV7Vw@mail.gmail.com>
On Thu, May 12, 2022 at 10:10:34AM -0700, Linus Torvalds wrote:
> On Thu, May 12, 2022 at 6:30 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Links to other random places don't serve that function.
>
> What "function"?
>
> This is my argument. Those Link: things need to have a *reason*.
>
> Saying "they are a change ID" is not a reason. That's just a random
> word-salad. You need to have an active reason that you can explain,
> not just say "look, I want to add a message ID to every commit".
So I want to go to my inbox and compare the patch as received with what
is in my tree. What did I change? And I tweak both the patch content
when applying and the subject so these are not good indicators. Is this
at all convincing?
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
KVM list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mie@igel.co.jp
Subject: Re: [GIT PULL] virtio: last minute fixup
Date: Mon, 16 May 2022 05:03:35 -0400 [thread overview]
Message-ID: <20220516045821-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAHk-=wgnYGY=10sRDzXCC2bmappjBTRNNbr8owvGLEW-xuV7Vw@mail.gmail.com>
On Thu, May 12, 2022 at 10:10:34AM -0700, Linus Torvalds wrote:
> On Thu, May 12, 2022 at 6:30 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Links to other random places don't serve that function.
>
> What "function"?
>
> This is my argument. Those Link: things need to have a *reason*.
>
> Saying "they are a change ID" is not a reason. That's just a random
> word-salad. You need to have an active reason that you can explain,
> not just say "look, I want to add a message ID to every commit".
So I want to go to my inbox and compare the patch as received with what
is in my tree. What did I change? And I tweak both the patch content
when applying and the subject so these are not good indicators. Is this
at all convincing?
--
MST
next prev parent reply other threads:[~2022-05-16 9:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 12:23 [GIT PULL] virtio: last minute fixup Michael S. Tsirkin
2022-05-10 12:23 ` Michael S. Tsirkin
2022-05-10 18:23 ` Linus Torvalds
2022-05-10 18:23 ` Linus Torvalds
2022-05-10 23:12 ` Nathan Chancellor
2022-05-10 23:50 ` Linus Torvalds
2022-05-10 23:50 ` Linus Torvalds
2022-05-11 7:13 ` Michael S. Tsirkin
2022-05-11 7:13 ` Michael S. Tsirkin
2022-05-11 12:51 ` Konstantin Ryabitsev
2022-05-11 13:40 ` Michael Ellerman
2022-05-11 13:40 ` Michael Ellerman
2022-05-11 16:31 ` Konstantin Ryabitsev
2022-05-12 2:07 ` Theodore Ts'o
2022-05-12 2:07 ` Theodore Ts'o
2022-05-11 17:35 ` Dave Taht
2022-05-11 6:22 ` Michael S. Tsirkin
2022-05-11 6:22 ` Michael S. Tsirkin
2022-05-11 10:12 ` Michael Ellerman
2022-05-11 10:12 ` Michael Ellerman
2022-05-11 16:20 ` Linus Torvalds
2022-05-11 16:20 ` Linus Torvalds
2022-05-12 13:30 ` Michael Ellerman
2022-05-12 13:30 ` Michael Ellerman
2022-05-12 17:10 ` Linus Torvalds
2022-05-12 17:10 ` Linus Torvalds
2022-05-12 17:19 ` Linus Torvalds
2022-05-12 17:19 ` Linus Torvalds
2022-05-13 14:14 ` Eric W. Biederman
2022-05-13 14:14 ` Eric W. Biederman
2022-05-13 17:00 ` Jakub Kicinski
2022-05-16 9:03 ` Michael S. Tsirkin [this message]
2022-05-16 9:03 ` Michael S. Tsirkin
2022-05-11 12:24 ` Jörg Rödel
2022-05-11 12:24 ` Jörg Rödel
2022-05-13 12:16 ` Michael S. Tsirkin
2022-05-13 12:16 ` Michael S. Tsirkin
2022-05-10 18:31 ` pr-tracker-bot
2022-05-10 18:31 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516045821-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=konstantin@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mie@igel.co.jp \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.