All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Bastian Hecht <hechtb@googlemail.com>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC] dt-bindings: mtd: Remove Renesas FLCTL NAND controller support
Date: Mon, 16 May 2022 19:51:13 -0500	[thread overview]
Message-ID: <20220517005113.GA3685447-robh@kernel.org> (raw)
In-Reply-To: <ef70e24a57d2342458fe11b7b13775ffac1f1bd0.1652098726.git.geert+renesas@glider.be>

On Mon, May 09, 2022 at 02:27:52PM +0200, Geert Uytterhoeven wrote:
> The DT bindings for the Renesas FLCTL NAND controller document only support a
> single SoC, namely the Renesas R-Mobile AP4 (SH7372).
> Linux dropped support for this SoC in commit 59b89af1d5551c12 ("ARM:
> shmobile: sh7372: Remove Legacy C SoC code") in v4.1.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> The FLCTL NAND controller (or an enhanced version) is also present on
> SH-Mobile AG5 (sh73a0) and R-Mobile A1 (r8a7740), but the sole boards
> supported upstream (KMC KZM-A9-GT resp. Atmark Techno Armadillo-800-EVA)
> use eMMC NAND instead of raw NAND FLASH.
> 
> What's the policy w.r.t. stale DT bindings?
> Should it be converted to json-schema instead?

Wouldn't be high on my list.

> drivers/mtd/nand/raw/sh_flctl.c still implements these bindings.
> The driver cannot be removed, as it is also used on the non-DT
> SH7723-based AP-325RXA platform.

But you could remove the DT support in the driver? I'd just leave this 
as-is if you don't do that.

Rob

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Bastian Hecht <hechtb@googlemail.com>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC] dt-bindings: mtd: Remove Renesas FLCTL NAND controller support
Date: Mon, 16 May 2022 19:51:13 -0500	[thread overview]
Message-ID: <20220517005113.GA3685447-robh@kernel.org> (raw)
In-Reply-To: <ef70e24a57d2342458fe11b7b13775ffac1f1bd0.1652098726.git.geert+renesas@glider.be>

On Mon, May 09, 2022 at 02:27:52PM +0200, Geert Uytterhoeven wrote:
> The DT bindings for the Renesas FLCTL NAND controller document only support a
> single SoC, namely the Renesas R-Mobile AP4 (SH7372).
> Linux dropped support for this SoC in commit 59b89af1d5551c12 ("ARM:
> shmobile: sh7372: Remove Legacy C SoC code") in v4.1.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> The FLCTL NAND controller (or an enhanced version) is also present on
> SH-Mobile AG5 (sh73a0) and R-Mobile A1 (r8a7740), but the sole boards
> supported upstream (KMC KZM-A9-GT resp. Atmark Techno Armadillo-800-EVA)
> use eMMC NAND instead of raw NAND FLASH.
> 
> What's the policy w.r.t. stale DT bindings?
> Should it be converted to json-schema instead?

Wouldn't be high on my list.

> drivers/mtd/nand/raw/sh_flctl.c still implements these bindings.
> The driver cannot be removed, as it is also used on the non-DT
> SH7723-based AP-325RXA platform.

But you could remove the DT support in the driver? I'd just leave this 
as-is if you don't do that.

Rob

  reply	other threads:[~2022-05-17  0:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 12:27 [PATCH/RFC] dt-bindings: mtd: Remove Renesas FLCTL NAND controller support Geert Uytterhoeven
2022-05-09 12:27 ` Geert Uytterhoeven
2022-05-17  0:51 ` Rob Herring [this message]
2022-05-17  0:51   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517005113.GA3685447-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=hechtb@googlemail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.