From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: jjherne@linux.ibm.com, akrowiak@linux.ibm.com,
kvm@vger.kernel.org, Matthew Rosato <mjrosato@linux.ibm.com>,
linux-s390@vger.kernel.org, intel-gfx@lists.freedesktop.org,
cohuck@redhat.com, linux-kernel@vger.kernel.org,
pasic@linux.ibm.com, borntraeger@linux.ibm.com,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Date: Wed, 18 May 2022 08:58:52 -0300 [thread overview]
Message-ID: <20220518115852.GG1343366@nvidia.com> (raw)
In-Reply-To: <YoSivTU7nivO9FMD@infradead.org>
On Wed, May 18, 2022 at 12:39:41AM -0700, Christoph Hellwig wrote:
> > if (device->ops->flags & VFIO_DEVICE_NEEDS_KVM)
> > {
>
> Nit: this is not the normal brace placement.
>
> But what is you diff against anyway? The one Matthew sent did away
> with the VFIO_DEVICE_NEEDS_KVM flags, which does the wrong thing for
> zpci, so it can't be that..
Against what I sent before, I did this before Matthew sent his
> Also if we want to do major code movement, it really needs to go into
> a separate patch or patches, as the combinations of all these moves
> with actual code changes is almost unreadable.
Sure, just checking how things could look at this point
Matthew's version first followed by the code motion is probably a good
approach.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>,
alex.williamson@redhat.com, cohuck@redhat.com,
borntraeger@linux.ibm.com, jjherne@linux.ibm.com,
akrowiak@linux.ibm.com, pasic@linux.ibm.com,
zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Date: Wed, 18 May 2022 08:58:52 -0300 [thread overview]
Message-ID: <20220518115852.GG1343366@nvidia.com> (raw)
In-Reply-To: <YoSivTU7nivO9FMD@infradead.org>
On Wed, May 18, 2022 at 12:39:41AM -0700, Christoph Hellwig wrote:
> > if (device->ops->flags & VFIO_DEVICE_NEEDS_KVM)
> > {
>
> Nit: this is not the normal brace placement.
>
> But what is you diff against anyway? The one Matthew sent did away
> with the VFIO_DEVICE_NEEDS_KVM flags, which does the wrong thing for
> zpci, so it can't be that..
Against what I sent before, I did this before Matthew sent his
> Also if we want to do major code movement, it really needs to go into
> a separate patch or patches, as the combinations of all these moves
> with actual code changes is almost unreadable.
Sure, just checking how things could look at this point
Matthew's version first followed by the code motion is probably a good
approach.
Jason
next prev parent reply other threads:[~2022-05-18 11:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 18:08 [PATCH 0/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM Matthew Rosato
2022-05-17 18:08 ` [PATCH 1/1] " Matthew Rosato
2022-05-17 18:56 ` [Intel-gfx] " Jason Gunthorpe
2022-05-17 18:56 ` Jason Gunthorpe
2022-05-18 7:39 ` [Intel-gfx] " Christoph Hellwig
2022-05-18 7:39 ` Christoph Hellwig
2022-05-18 11:58 ` Jason Gunthorpe [this message]
2022-05-18 11:58 ` Jason Gunthorpe
2022-05-18 7:47 ` [Intel-gfx] " Christoph Hellwig
2022-05-18 7:47 ` Christoph Hellwig
2022-05-18 14:37 ` Matthew Rosato
2022-05-18 15:12 ` [Intel-gfx] " Jason Gunthorpe
2022-05-18 15:12 ` Jason Gunthorpe
2022-05-18 15:33 ` Matthew Rosato
2022-05-18 15:38 ` [Intel-gfx] " Jason Gunthorpe
2022-05-18 15:38 ` Jason Gunthorpe
2022-05-17 21:07 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/1] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518115852.GG1343366@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.