From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
"Lu Baolu" <baolu.lu@linux.intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
"Christoph Hellwig" <hch@infradead.org>,
vkoul@kernel.org, robin.murphy@arm.com, will@kernel.org
Cc: Yi Liu <yi.l.liu@intel.com>, Dave Jiang <dave.jiang@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>,
Eric Auger <eric.auger@redhat.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [PATCH v4 6/6] iommu/vt-d: Delete unused SVM flag
Date: Wed, 18 May 2022 11:21:20 -0700 [thread overview]
Message-ID: <20220518182120.1136715-7-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <20220518182120.1136715-1-jacob.jun.pan@linux.intel.com>
Supervisor PASID for SVA/SVM is no longer supported, delete the unused
flag.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
drivers/iommu/intel/svm.c | 2 +-
include/linux/intel-svm.h | 13 -------------
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index 44331db060e4..5b220d464218 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -750,7 +750,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
* to unbind the mm while any page faults are outstanding.
*/
svm = pasid_private_find(req->pasid);
- if (IS_ERR_OR_NULL(svm) || (svm->flags & SVM_FLAG_SUPERVISOR_MODE))
+ if (IS_ERR_OR_NULL(svm))
goto bad_req;
}
diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h
index b3b125b332aa..6835a665c195 100644
--- a/include/linux/intel-svm.h
+++ b/include/linux/intel-svm.h
@@ -13,17 +13,4 @@
#define PRQ_RING_MASK ((0x1000 << PRQ_ORDER) - 0x20)
#define PRQ_DEPTH ((0x1000 << PRQ_ORDER) >> 5)
-/*
- * The SVM_FLAG_SUPERVISOR_MODE flag requests a PASID which can be used only
- * for access to kernel addresses. No IOTLB flushes are automatically done
- * for kernel mappings; it is valid only for access to the kernel's static
- * 1:1 mapping of physical memory — not to vmalloc or even module mappings.
- * A future API addition may permit the use of such ranges, by means of an
- * explicit IOTLB flush call (akin to the DMA API's unmap method).
- *
- * It is unlikely that we will ever hook into flush_tlb_kernel_range() to
- * do such IOTLB flushes automatically.
- */
-#define SVM_FLAG_SUPERVISOR_MODE BIT(0)
-
#endif /* __INTEL_SVM_H__ */
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
dmaengine@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
"Lu Baolu" <baolu.lu@linux.intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
"Christoph Hellwig" <hch@infradead.org>,
vkoul@kernel.org, robin.murphy@arm.com, will@kernel.org
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Raj Ashok <ashok.raj@intel.com>
Subject: [PATCH v4 6/6] iommu/vt-d: Delete unused SVM flag
Date: Wed, 18 May 2022 11:21:20 -0700 [thread overview]
Message-ID: <20220518182120.1136715-7-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <20220518182120.1136715-1-jacob.jun.pan@linux.intel.com>
Supervisor PASID for SVA/SVM is no longer supported, delete the unused
flag.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
drivers/iommu/intel/svm.c | 2 +-
include/linux/intel-svm.h | 13 -------------
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index 44331db060e4..5b220d464218 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -750,7 +750,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
* to unbind the mm while any page faults are outstanding.
*/
svm = pasid_private_find(req->pasid);
- if (IS_ERR_OR_NULL(svm) || (svm->flags & SVM_FLAG_SUPERVISOR_MODE))
+ if (IS_ERR_OR_NULL(svm))
goto bad_req;
}
diff --git a/include/linux/intel-svm.h b/include/linux/intel-svm.h
index b3b125b332aa..6835a665c195 100644
--- a/include/linux/intel-svm.h
+++ b/include/linux/intel-svm.h
@@ -13,17 +13,4 @@
#define PRQ_RING_MASK ((0x1000 << PRQ_ORDER) - 0x20)
#define PRQ_DEPTH ((0x1000 << PRQ_ORDER) >> 5)
-/*
- * The SVM_FLAG_SUPERVISOR_MODE flag requests a PASID which can be used only
- * for access to kernel addresses. No IOTLB flushes are automatically done
- * for kernel mappings; it is valid only for access to the kernel's static
- * 1:1 mapping of physical memory — not to vmalloc or even module mappings.
- * A future API addition may permit the use of such ranges, by means of an
- * explicit IOTLB flush call (akin to the DMA API's unmap method).
- *
- * It is unlikely that we will ever hook into flush_tlb_kernel_range() to
- * do such IOTLB flushes automatically.
- */
-#define SVM_FLAG_SUPERVISOR_MODE BIT(0)
-
#endif /* __INTEL_SVM_H__ */
--
2.25.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-05-18 18:17 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 18:21 [PATCH v4 0/6] Enable PASID for DMA API users Jacob Pan
2022-05-18 18:21 ` Jacob Pan
2022-05-18 18:21 ` [PATCH v4 1/6] iommu: Add a per domain PASID for DMA API Jacob Pan
2022-05-18 18:21 ` Jacob Pan
2022-05-19 6:50 ` Baolu Lu
2022-05-19 6:50 ` Baolu Lu
2022-05-24 13:50 ` Jason Gunthorpe
2022-05-24 13:50 ` Jason Gunthorpe via iommu
2022-05-24 15:17 ` Jacob Pan
2022-05-24 15:17 ` Jacob Pan
2022-05-30 12:22 ` Jason Gunthorpe
2022-05-30 12:22 ` Jason Gunthorpe via iommu
2022-05-31 10:12 ` Tian, Kevin
2022-05-31 10:12 ` Tian, Kevin
2022-05-31 12:45 ` Baolu Lu
2022-05-31 12:45 ` Baolu Lu
2022-05-31 16:03 ` Jason Gunthorpe
2022-05-31 16:03 ` Jason Gunthorpe via iommu
2022-05-31 17:29 ` Jacob Pan
2022-05-31 17:29 ` Jacob Pan
2022-05-31 19:05 ` Jason Gunthorpe
2022-05-31 19:05 ` Jason Gunthorpe via iommu
2022-05-31 20:44 ` Jacob Pan
2022-05-31 20:44 ` Jacob Pan
2022-06-01 1:50 ` Tian, Kevin
2022-06-01 1:50 ` Tian, Kevin
2022-06-01 1:43 ` Tian, Kevin
2022-06-01 1:43 ` Tian, Kevin
2022-06-01 9:37 ` Baolu Lu
2022-06-01 9:37 ` Baolu Lu
2022-06-01 10:05 ` Tian, Kevin
2022-06-01 10:05 ` Tian, Kevin
2022-05-18 18:21 ` [PATCH v4 2/6] iommu: Add a helper to do PASID lookup from domain Jacob Pan
2022-05-18 18:21 ` Jacob Pan
2022-05-19 6:41 ` Baolu Lu
2022-05-19 6:41 ` Baolu Lu
2022-05-19 20:10 ` Jacob Pan
2022-05-19 20:10 ` Jacob Pan
2022-05-19 6:48 ` Christoph Hellwig
2022-05-19 6:48 ` Christoph Hellwig
2022-05-20 15:18 ` Jacob Pan
2022-05-20 15:18 ` Jacob Pan
2022-05-23 7:55 ` Tian, Kevin
2022-05-23 7:55 ` Tian, Kevin
2022-05-23 9:14 ` Tian, Kevin
2022-05-23 9:14 ` Tian, Kevin
2022-05-23 18:01 ` Jacob Pan
2022-05-23 18:01 ` Jacob Pan
2022-05-18 18:21 ` [PATCH v4 3/6] iommu/vt-d: Implement domain ops for attach_dev_pasid Jacob Pan
2022-05-18 18:21 ` Jacob Pan
2022-05-24 13:51 ` Jason Gunthorpe
2022-05-24 13:51 ` Jason Gunthorpe via iommu
2022-05-24 16:12 ` Jacob Pan
2022-05-24 16:12 ` Jacob Pan
2022-05-24 18:02 ` Jason Gunthorpe
2022-05-24 18:02 ` Jason Gunthorpe via iommu
2022-05-24 20:45 ` Jacob Pan
2022-05-24 20:45 ` Jacob Pan
2022-05-24 21:10 ` Jason Gunthorpe
2022-05-24 21:10 ` Jason Gunthorpe via iommu
2022-05-18 18:21 ` [PATCH v4 4/6] iommu: Add PASID support for DMA mapping API users Jacob Pan
2022-05-18 18:21 ` Jacob Pan
2022-05-23 8:25 ` Tian, Kevin
2022-05-23 8:25 ` Tian, Kevin
2022-05-23 15:23 ` Jacob Pan
2022-05-23 15:23 ` Jacob Pan
2022-05-18 18:21 ` [PATCH v4 5/6] dmaengine: idxd: Use DMA API for in-kernel DMA with PASID Jacob Pan
2022-05-18 18:21 ` Jacob Pan
2022-05-18 18:21 ` Jacob Pan [this message]
2022-05-18 18:21 ` [PATCH v4 6/6] iommu/vt-d: Delete unused SVM flag Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518182120.1136715-7-jacob.jun.pan@linux.intel.com \
--to=jacob.jun.pan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.