All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Subject: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification
Date: Thu, 19 May 2022 08:39:02 +0800	[thread overview]
Message-ID: <20220519003902.GE156677@MiWiFi-R3L-srv> (raw)
In-Reply-To: <YoTYm6Fo1vBUuJGu@osiris>

On 05/18/22 at 01:29pm, Heiko Carstens wrote:
> On Thu, May 12, 2022 at 03:01:23PM +0800, Coiby Xu wrote:
> > From: Michal Suchanek <msuchanek@suse.de>
> > 
> > commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
> > adds support for KEXEC_SIG verification with keys from platform keyring
> > but the built-in keys and secondary keyring are not used.
> > 
> > Add support for the built-in keys and secondary keyring as x86 does.
> > 
> > Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
> > Cc: stable at vger.kernel.org
> > Cc: Philipp Rudo <prudo@linux.ibm.com>
> > Cc: kexec at lists.infradead.org
> > Cc: keyrings at vger.kernel.org
> > Cc: linux-security-module at vger.kernel.org
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > Reviewed-by: "Lee, Chun-Yi" <jlee@suse.com>
> > Acked-by: Baoquan He <bhe@redhat.com>
> > Signed-off-by: Coiby Xu <coxu@redhat.com>
> > ---
> >  arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++-----
> >  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> As far as I can tell this doesn't have any dependency to the other
> patches in this series, so should I pick this up for the s390 tree, or
> how will this go upstream?

Thanks, Heiko.

I want to ask Mimi if this can be taken into KEYS-ENCRYPTED tree.
Otherwise I will ask Andrew to help pick this whole series.

Surely, this patch 4 can be taken into s390 seperately since it's
independent, both looks good.

Thanks
Baoquan



WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Heiko Carstens <hca@linux.ibm.com>,
	akpm@linux-foundation.org, zohar@linux.ibm.com
Cc: Coiby Xu <coxu@redhat.com>,
	kexec@lists.infradead.org, keyrings@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Michal Suchanek <msuchanek@suse.de>,
	Dave Young <dyoung@redhat.com>, Will Deacon <will@kernel.org>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Mimi Zohar <zohar@linux.ibm.com>, Chun-Yi Lee <jlee@suse.com>,
	stable@vger.kernel.org, Philipp Rudo <prudo@linux.ibm.com>,
	linux-security-module@vger.kernel.org,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	"open list:S390" <linux-s390@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification
Date: Thu, 19 May 2022 08:39:02 +0800	[thread overview]
Message-ID: <20220519003902.GE156677@MiWiFi-R3L-srv> (raw)
In-Reply-To: <YoTYm6Fo1vBUuJGu@osiris>

On 05/18/22 at 01:29pm, Heiko Carstens wrote:
> On Thu, May 12, 2022 at 03:01:23PM +0800, Coiby Xu wrote:
> > From: Michal Suchanek <msuchanek@suse.de>
> > 
> > commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
> > adds support for KEXEC_SIG verification with keys from platform keyring
> > but the built-in keys and secondary keyring are not used.
> > 
> > Add support for the built-in keys and secondary keyring as x86 does.
> > 
> > Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
> > Cc: stable@vger.kernel.org
> > Cc: Philipp Rudo <prudo@linux.ibm.com>
> > Cc: kexec@lists.infradead.org
> > Cc: keyrings@vger.kernel.org
> > Cc: linux-security-module@vger.kernel.org
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > Reviewed-by: "Lee, Chun-Yi" <jlee@suse.com>
> > Acked-by: Baoquan He <bhe@redhat.com>
> > Signed-off-by: Coiby Xu <coxu@redhat.com>
> > ---
> >  arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++-----
> >  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> As far as I can tell this doesn't have any dependency to the other
> patches in this series, so should I pick this up for the s390 tree, or
> how will this go upstream?

Thanks, Heiko.

I want to ask Mimi if this can be taken into KEYS-ENCRYPTED tree.
Otherwise I will ask Andrew to help pick this whole series.

Surely, this patch 4 can be taken into s390 seperately since it's
independent, both looks good.

Thanks
Baoquan


WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Heiko Carstens <hca@linux.ibm.com>,
	akpm@linux-foundation.org, zohar@linux.ibm.com
Cc: Coiby Xu <coxu@redhat.com>,
	kexec@lists.infradead.org, keyrings@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Michal Suchanek <msuchanek@suse.de>,
	Dave Young <dyoung@redhat.com>, Will Deacon <will@kernel.org>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Mimi Zohar <zohar@linux.ibm.com>, Chun-Yi Lee <jlee@suse.com>,
	stable@vger.kernel.org, Philipp Rudo <prudo@linux.ibm.com>,
	linux-security-module@vger.kernel.org,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	"open list:S390" <linux-s390@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification
Date: Thu, 19 May 2022 08:39:02 +0800	[thread overview]
Message-ID: <20220519003902.GE156677@MiWiFi-R3L-srv> (raw)
In-Reply-To: <YoTYm6Fo1vBUuJGu@osiris>

On 05/18/22 at 01:29pm, Heiko Carstens wrote:
> On Thu, May 12, 2022 at 03:01:23PM +0800, Coiby Xu wrote:
> > From: Michal Suchanek <msuchanek@suse.de>
> > 
> > commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
> > adds support for KEXEC_SIG verification with keys from platform keyring
> > but the built-in keys and secondary keyring are not used.
> > 
> > Add support for the built-in keys and secondary keyring as x86 does.
> > 
> > Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype")
> > Cc: stable@vger.kernel.org
> > Cc: Philipp Rudo <prudo@linux.ibm.com>
> > Cc: kexec@lists.infradead.org
> > Cc: keyrings@vger.kernel.org
> > Cc: linux-security-module@vger.kernel.org
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > Reviewed-by: "Lee, Chun-Yi" <jlee@suse.com>
> > Acked-by: Baoquan He <bhe@redhat.com>
> > Signed-off-by: Coiby Xu <coxu@redhat.com>
> > ---
> >  arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++-----
> >  1 file changed, 13 insertions(+), 5 deletions(-)
> 
> As far as I can tell this doesn't have any dependency to the other
> patches in this series, so should I pick this up for the s390 tree, or
> how will this go upstream?

Thanks, Heiko.

I want to ask Mimi if this can be taken into KEYS-ENCRYPTED tree.
Otherwise I will ask Andrew to help pick this whole series.

Surely, this patch 4 can be taken into s390 seperately since it's
independent, both looks good.

Thanks
Baoquan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-19  0:39 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  7:01 [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature Coiby Xu
2022-05-12  7:01 ` Coiby Xu
2022-05-12  7:01 ` [PATCH v8 1/4] kexec: clean up arch_kexec_kernel_verify_sig Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-06-09 21:57   ` Mimi Zohar
2022-06-09 21:57     ` Mimi Zohar
2022-06-09 21:57     ` Mimi Zohar
2022-05-12  7:01 ` [PATCH v8 2/4] kexec, KEYS: make the code in bzImage64_verify_sig generic Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-05-12  7:21   ` Baoquan He
2022-05-12  7:21     ` Baoquan He
2022-05-12  7:21     ` Baoquan He
2022-06-09 22:18   ` Mimi Zohar
2022-06-09 22:18     ` Mimi Zohar
2022-06-09 22:18     ` Mimi Zohar
2022-06-16  1:47     ` Coiby Xu
2022-06-16  1:47       ` Coiby Xu
2022-06-16  1:47       ` Coiby Xu
2022-05-12  7:01 ` [PATCH v8 3/4] arm64: kexec_file: use more system keyrings to verify kernel image signature Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-06-09 23:15   ` Mimi Zohar
2022-06-09 23:15     ` Mimi Zohar
2022-06-09 23:15     ` Mimi Zohar
2022-06-16  1:22     ` Coiby Xu
2022-06-16  1:22       ` Coiby Xu
2022-06-16  1:22       ` Coiby Xu
2022-06-17  9:34     ` Michal Suchánek
2022-06-17  9:34       ` Michal Suchánek
2022-06-17  9:34       ` Michal Suchánek
2022-05-12  7:01 ` [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-05-12  7:01   ` Coiby Xu
2022-05-18 11:29   ` Heiko Carstens
2022-05-18 11:29     ` Heiko Carstens
2022-05-18 11:29     ` Heiko Carstens
2022-05-19  0:39     ` Baoquan He [this message]
2022-05-19  0:39       ` Baoquan He
2022-05-19  0:39       ` Baoquan He
2022-05-19 11:56       ` Mimi Zohar
2022-05-19 11:56         ` Mimi Zohar
2022-05-19 11:56         ` Mimi Zohar
2022-05-19 14:22         ` Baoquan He
2022-05-19 14:22           ` Baoquan He
2022-05-19 14:22           ` Baoquan He
2022-05-19 17:11           ` Michal =?unknown-8bit?q?Such=C3=A1nek?=
2022-05-19 17:11             ` Michal Suchánek
2022-05-19 17:11             ` Michal Suchánek
2022-06-16  1:46             ` Coiby Xu
2022-06-16  1:46               ` Coiby Xu
2022-06-16  1:46               ` Coiby Xu
2022-05-20 17:04 ` [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature Mimi Zohar
2022-05-20 17:04   ` Mimi Zohar
2022-05-25  9:59   ` Coiby Xu
2022-05-25  9:59     ` Coiby Xu
2022-05-25 13:30     ` Mimi Zohar
2022-05-25 13:30       ` Mimi Zohar
2022-05-27 13:43       ` Coiby Xu
2022-05-27 13:43         ` Coiby Xu
2022-05-27 16:45         ` Mimi Zohar
2022-05-27 16:45           ` Mimi Zohar
2022-06-16  1:15           ` Coiby Xu
2022-06-16  1:15             ` Coiby Xu
2022-06-17  3:57             ` Coiby Xu
2022-06-17  3:57               ` Coiby Xu
2022-06-17 11:58               ` Mimi Zohar
2022-06-17 11:58                 ` Mimi Zohar
2022-06-20 13:14                 ` Coiby Xu
2022-06-20 13:14                   ` Coiby Xu
2022-06-09 15:35         ` Mimi Zohar
2022-06-09 15:35           ` Mimi Zohar
2022-06-16  1:21           ` Coiby Xu
2022-06-16  1:21             ` Coiby Xu
2022-06-17 12:06             ` Mimi Zohar
2022-06-17 12:06               ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519003902.GE156677@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.