From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v5 00/11] ethtool: Add support for frame preemption
Date: Fri, 20 May 2022 15:34:13 -0700 [thread overview]
Message-ID: <20220520153413.16c6830b@kernel.org> (raw)
In-Reply-To: <20220520011538.1098888-1-vinicius.gomes@intel.com>
On Thu, 19 May 2022 18:15:27 -0700 Vinicius Costa Gomes wrote:
> Changes from v4:
> - Went back to exposing the per-queue frame preemption bits via
> ethtool-netlink only, via taprio/mqprio was seen as too much
> trouble. (Vladimir Oltean)
> - Fixed documentation and code/patch organization changes (Vladimir
> Oltean).
First of all - could you please, please, please rev these patches more
than once a year? It's really hard to keep track of the context when
previous version was sent in Jun 2021 :/
I disagree that queue mask belongs in ethtool. It's an attribute of
a queue and should be attached to a queue. The DCBNL parallel is flawed
IMO because pause generation is Rx, not Tx. There is no Rx queue in
Linux, much less per-prio.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
vladimir.oltean@nxp.com, po.liu@nxp.com,
boon.leong.ong@intel.com, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next v5 00/11] ethtool: Add support for frame preemption
Date: Fri, 20 May 2022 15:34:13 -0700 [thread overview]
Message-ID: <20220520153413.16c6830b@kernel.org> (raw)
In-Reply-To: <20220520011538.1098888-1-vinicius.gomes@intel.com>
On Thu, 19 May 2022 18:15:27 -0700 Vinicius Costa Gomes wrote:
> Changes from v4:
> - Went back to exposing the per-queue frame preemption bits via
> ethtool-netlink only, via taprio/mqprio was seen as too much
> trouble. (Vladimir Oltean)
> - Fixed documentation and code/patch organization changes (Vladimir
> Oltean).
First of all - could you please, please, please rev these patches more
than once a year? It's really hard to keep track of the context when
previous version was sent in Jun 2021 :/
I disagree that queue mask belongs in ethtool. It's an attribute of
a queue and should be attached to a queue. The DCBNL parallel is flawed
IMO because pause generation is Rx, not Tx. There is no Rx queue in
Linux, much less per-prio.
next prev parent reply other threads:[~2022-05-20 22:34 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 1:15 [Intel-wired-lan] [PATCH net-next v5 00/11] ethtool: Add support for frame preemption Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 01/11] ethtool: Add support for configuring " Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 9:06 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 9:06 ` Vladimir Oltean
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 02/11] ethtool: Add support for Frame Preemption verification Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 9:16 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 9:16 ` Vladimir Oltean
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 03/11] igc: Add support for receiving frames with all zeroes address Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 04/11] igc: Set the RX packet buffer size for TSN mode Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 05/11] igc: Optimze TX buffer sizes for TSN Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 9:33 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 9:33 ` Vladimir Oltean
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 06/11] igc: Add support for receiving errored frames Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 9:19 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 9:19 ` Vladimir Oltean
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 07/11] igc: Add support for enabling frame preemption via ethtool Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 08/11] igc: Add support for setting frame preemption configuration Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 9:22 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 9:22 ` Vladimir Oltean
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 09/11] igc: Add support for Frame Preemption verification Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 10:43 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 10:43 ` Vladimir Oltean
2022-05-27 9:08 ` [Intel-wired-lan] " Zhou Furong
2022-05-27 9:08 ` Zhou Furong
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 10/11] igc: Check incompatible configs for Frame Preemption Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 6:11 ` [Intel-wired-lan] " kernel test robot
2022-05-20 6:11 ` kernel test robot
2022-05-20 11:06 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 11:06 ` Vladimir Oltean
2022-05-20 1:15 ` [Intel-wired-lan] [PATCH net-next v5 11/11] igc: Add support for exposing frame preemption stats registers Vinicius Costa Gomes
2022-05-20 1:15 ` Vinicius Costa Gomes
2022-05-20 12:13 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-20 12:13 ` Vladimir Oltean
2022-05-20 22:34 ` Jakub Kicinski [this message]
2022-05-20 22:34 ` [PATCH net-next v5 00/11] ethtool: Add support for frame preemption Jakub Kicinski
2022-05-21 15:03 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-21 15:03 ` Vladimir Oltean
2022-05-23 19:52 ` [Intel-wired-lan] " Jakub Kicinski
2022-05-23 19:52 ` Jakub Kicinski
2022-05-23 20:32 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-23 20:32 ` Vladimir Oltean
2022-05-23 21:31 ` [Intel-wired-lan] " Jakub Kicinski
2022-05-23 21:31 ` Jakub Kicinski
2022-05-23 22:49 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-23 22:49 ` Vladimir Oltean
2022-05-23 23:33 ` [Intel-wired-lan] " Vladimir Oltean
2022-05-23 23:33 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520153413.16c6830b@kernel.org \
--to=kuba@kernel.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.