[LTP] LTP release preparations

[LTP] LTP release preparations

[Cyril Hrubis]

Hi!
It's time to start working on pre-release preparations. As usually we
should start by considering patches that should be applied before we
freeze the git.

As for me I would like to get the runtime patchset in if possible.

What else should be considered for the release?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] LTP release preparations

[Petr Vorel]

Hi Cyril,

> What else should be considered for the release?

Fixes (worth to merge before)
* if-mtu-change.sh: Fix using functions
https://patchwork.ozlabs.org/project/ltp/patch/20220509094322.10959-1-pvorel@suse.cz/

* Fix constant redefinition
https://patchwork.ozlabs.org/project/ltp/list/?series=298174

I'd also like to post rebased
* shell: Fixes for disabled IPv6
https://patchwork.ozlabs.org/project/ltp/list/?series=284532
* shell: Add $TST_MOUNT_DEVICE support
https://patchwork.ozlabs.org/project/ltp/list/?series=291724

Could we decide whether this fix is worth of merging?
* Fix tst_search_driver for x86-64 modules
https://patchwork.ozlabs.org/project/ltp/list/?series=290523

2 additions to runtest/smoketest
* smoketest: Add macsec02.sh
https://patchwork.ozlabs.org/project/ltp/patch/20220310104457.764-1-pvorel@suse.cz/
* smoketest: Add df01.sh
https://patchwork.ozlabs.org/project/ltp/patch/20220322165042.20658-1-pvorel@suse.cz/

I guess we can postpone switching to bionic after the release
* ci: Ubuntu xenial -> bionic
https://patchwork.ozlabs.org/project/ltp/patch/20220316150429.2873-1-pvorel@suse.cz/

also remove rup and rusers can be decided after the release (although it's not
working on my VMs and I don't think it's worth to fix them)
* Remove RPC rup and rusers tests
https://patchwork.ozlabs.org/project/ltp/list/?series=297407

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] LTP release preparations

[Li Wang]

[-- Attachment #1.1: Type: text/plain, Size: 757 bytes --]

On Mon, May 9, 2022 at 8:48 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> It's time to start working on pre-release preparations. As usually we
> should start by considering patches that should be applied before we
> freeze the git.
>
> As for me I would like to get the runtime patchset in if possible.
>

+1, I will add my review ASAP.



> What else should be considered for the release?
>


1628025 New          [v2] rtc02: loosen the compare precision with few
seconds
1625610 New          [1/2] lapi/mount.h: Remove <linux/mount.h>
1625609 New          [2/2] Remove duplicate include of <sys/mount.h>

also, I vote for adding expand Cgroup library from Luke's patchset, but
if time is hurrying I'm fine without it as well.



-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 2055 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] LTP release preparations

[Cyril Hrubis]

Hi!
> > As for me I would like to get the runtime patchset in if possible.
> >
> 
> +1, I will add my review ASAP.

Thx.

> > What else should be considered for the release?
> >
> 
> 
> 1628025 New          [v2] rtc02: loosen the compare precision with few
> seconds
> 1625610 New          [1/2] lapi/mount.h: Remove <linux/mount.h>
> 1625609 New          [2/2] Remove duplicate include of <sys/mount.h>
> 
> also, I vote for adding expand Cgroup library from Luke's patchset, but
> if time is hurrying I'm fine without it as well.

I would vote for getting the cgroup patchset in as well here, even if
that would delay the release by a few days.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] LTP release preparations

[Martin Doucha]

On 09. 05. 22 14:50, Cyril Hrubis wrote:
> Hi!
> It's time to start working on pre-release preparations. As usually we
> should start by considering patches that should be applied before we
> freeze the git.
> 
> As for me I would like to get the runtime patchset in if possible.
> 
> What else should be considered for the release?

I'd like to add the two KVM patches - memory access helper functions and
multiple iteration support. I can't finish the KVM documentation until
they're merged.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] LTP release preparations

[Cyril Hrubis]

Hi!
> I'd like to add the two KVM patches - memory access helper functions and
> multiple iteration support. I can't finish the KVM documentation until
> they're merged.

I will have a look.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] LTP release preparations

[Cyril Hrubis]

Hi!
I've finally pushed the runtest patchset, many thanks for reviews
especially Li for his careful review and tests.

Other than that I will have a look at the KVM documentation by Martin,
since it would be nice to include documentation for the newly added
library and as this is not a code change it will be safe for the
release.

With that I would like to release at the end of the week, which gives us
chance to re-test with the runtime patches on the top. I will run a few
testruns myself just to make sure that everything is fine.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH] preadv203: set max_runtime to 270s

[Li Wang]

Before the runtime patchset preadv203 use 5min as default timeout
per fs, that's really long enough for prepare_device(). But after
that, its now only has 30s which might be short for a slower system
to do preparation work.

Let's set max_runtime to 270s to make the timeout at least equal
to previously.

  ==== Before =====
  # ./preadv203
  ...
  tst_test.c:1459: TINFO: Timeout per run is 0h 05m 00s
  preadv203.c:143: TINFO: Number of full_reads 2567, short reads 10, zero len reads 0, EAGAIN(s) 2530185
  preadv203.c:180: TINFO: Number of writes 682740
  preadv203.c:194: TINFO: Cache dropped 114 times
  preadv203.c:223: TPASS: Got some EAGAIN
  tst_test.c:1531: TINFO: Testing on ext3
  tst_test.c:999: TINFO: Formatting /dev/loop0 with ext3 opts='' extra opts=''
  mke2fs 1.46.5 (30-Dec-2021)
  tst_test.c:1459: TINFO: Timeout per run is 0h 05m 00s
  ...

  ==== After =====
  # time ./preadv203
  tst_device.c:89: TINFO: Found free device 0 '/dev/loop0'
  tst_test.c:1524: TINFO: Timeout per run is 0h 00m 30s
  tst_supported_fs_types.c:89: TINFO: Kernel supports ext2
  ...
  tst_test.c:1597: TINFO: Testing on ext2
  tst_test.c:1062: TINFO: Formatting /dev/loop0 with ext2 opts='' extra opts=''
  mke2fs 1.46.5 (30-Dec-2021)
  Test timeouted, sending SIGKILL!
  tst_test.c:1575: TINFO: If you are running on slow machine, try exporting LTP_TIMEOUT_MUL > 1
  tst_test.c:1577: TBROK: Test killed! (timeout?)

  Summary:
  passed   0
  failed   0
  broken   1
  skipped  0
  warnings 0

  real	0m36.246s
  user	0m0.706s
  sys	1m2.965s

Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Cyril Hrubis <chrubis@suse.cz>
---

Notes:
    Another fixe way is going with define DEFAULT_TIMEOUT to 60, that
    generally extends all timeout for each fs to perform prepare_device().
    And this will impact all test cases with setting .all_filesystems.

 testcases/kernel/syscalls/preadv2/preadv203.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/syscalls/preadv2/preadv203.c b/testcases/kernel/syscalls/preadv2/preadv203.c
index 01622ad15..46bb39ef1 100644
--- a/testcases/kernel/syscalls/preadv2/preadv203.c
+++ b/testcases/kernel/syscalls/preadv2/preadv203.c
@@ -279,5 +279,6 @@ static struct tst_test test = {
 	.mntpoint = MNTPOINT,
 	.mount_device = 1,
 	.all_filesystems = 1,
+	.max_runtime = 270,
 	.needs_root = 1,
 };
-- 
2.31.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] preadv203: set max_runtime to 270s

[Cyril Hrubis]

Hi!
> Before the runtime patchset preadv203 use 5min as default timeout
> per fs, that's really long enough for prepare_device(). But after
> that, its now only has 30s which might be short for a slower system
> to do preparation work.
> 
> Let's set max_runtime to 270s to make the timeout at least equal
> to previously.

Isn't the main reason why the test fails that the verify_preadv2()
function spins for at most 60 seconds?

I guess that the proper solution should be:

diff --git a/testcases/kernel/syscalls/preadv2/preadv203.c b/testcases/kernel/syscalls/preadv2/preadv203.c
index 01622ad15..e9377071e 100644
--- a/testcases/kernel/syscalls/preadv2/preadv203.c
+++ b/testcases/kernel/syscalls/preadv2/preadv203.c
@@ -199,7 +199,6 @@ static void *cache_dropper(void *unused)
 static void verify_preadv2(void)
 {
        pthread_t reader, dropper, writer;
-       unsigned int max_runtime = 600;
        void *eagains;

        stop = 0;
@@ -210,7 +209,7 @@ static void verify_preadv2(void)
        SAFE_PTHREAD_CREATE(&reader, NULL, nowait_reader, NULL);
        SAFE_PTHREAD_CREATE(&writer, NULL, writer_thread, NULL);

-       while (!stop && max_runtime-- > 0)
+       while (!stop && tst_remaining_runtime())
                usleep(100000);

        stop = 1;
@@ -280,4 +279,5 @@ static struct tst_test test = {
        .mount_device = 1,
        .all_filesystems = 1,
        .needs_root = 1,
+       .max_runtime = 60,
 };

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] preadv203: set max_runtime to 270s

[Li Wang]

[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]

Cyril Hrubis <chrubis@suse.cz> wrote:

Hi!
> > Before the runtime patchset preadv203 use 5min as default timeout
> > per fs, that's really long enough for prepare_device(). But after
> > that, its now only has 30s which might be short for a slower system
> > to do preparation work.
> >
> > Let's set max_runtime to 270s to make the timeout at least equal
> > to previously.
>
> Isn't the main reason why the test fails that the verify_preadv2()
> function spins for at most 60 seconds?
>

Ah, you're right!
I overlooked that spins 60s but wrongly blame the default timeout in the
library.

>
> I guess that the proper solution should be:
>

This patch works for me. I will send V2 as your suggestion.

-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 1672 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp