From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: peterz@infradead.org, jpoimboe@redhat.com,
linux-kernel@vger.kernel.org, rostedt@goodmis.org, aik@ozlabs.ru,
sv@linux.ibm.com, Paul Mackerras <paulus@samba.org>,
naveen.n.rao@linux.vnet.ibm.com, mbenes@suse.cz,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v1 2/4] objtool: Add R_REL32 macro
Date: Wed, 25 May 2022 11:40:54 -0500 [thread overview]
Message-ID: <20220525164054.GO25951@gate.crashing.org> (raw)
In-Reply-To: <35932b18ea948cbc1e7ec9d006e4575641a4daa5.1653494186.git.christophe.leroy@csgroup.eu>
Hi!
On Wed, May 25, 2022 at 05:58:15PM +0200, Christophe Leroy wrote:
> In order to allow other architectures than x86 to use 32 bits
> relative relocations, define a R_REL32 macro that each architecture
> will define, in the same way as already done for R_NONE.
What are the expected semantics of this relocation? It is PC-relative,
sure, but what is the destination? S+A-P always? That works for both
x86-64 and for PowerPC, but it should be written doen somewhere :-)
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
peterz@infradead.org, aik@ozlabs.ru, sv@linux.ibm.com,
rostedt@goodmis.org, jpoimboe@redhat.com,
naveen.n.rao@linux.vnet.ibm.com, mbenes@suse.cz,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 2/4] objtool: Add R_REL32 macro
Date: Wed, 25 May 2022 11:40:54 -0500 [thread overview]
Message-ID: <20220525164054.GO25951@gate.crashing.org> (raw)
In-Reply-To: <35932b18ea948cbc1e7ec9d006e4575641a4daa5.1653494186.git.christophe.leroy@csgroup.eu>
Hi!
On Wed, May 25, 2022 at 05:58:15PM +0200, Christophe Leroy wrote:
> In order to allow other architectures than x86 to use 32 bits
> relative relocations, define a R_REL32 macro that each architecture
> will define, in the same way as already done for R_NONE.
What are the expected semantics of this relocation? It is PC-relative,
sure, but what is the destination? S+A-P always? That works for both
x86-64 and for PowerPC, but it should be written doen somewhere :-)
Segher
next prev parent reply other threads:[~2022-05-25 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 15:58 [RFC PATCH v1 0/4] Implement inline static calls on PPC32 Christophe Leroy
2022-05-25 15:58 ` Christophe Leroy
2022-05-25 15:58 ` [RFC PATCH v1 1/4] Revert "objtool: Enable objtool to run only on files with ftrace enabled" Christophe Leroy
2022-05-25 15:58 ` Christophe Leroy
2022-05-25 16:34 ` Peter Zijlstra
2022-05-25 16:34 ` Peter Zijlstra
2022-05-25 17:03 ` Christophe Leroy
2022-05-25 17:03 ` Christophe Leroy
2022-05-25 15:58 ` [RFC PATCH v1 2/4] objtool: Add R_REL32 macro Christophe Leroy
2022-05-25 15:58 ` Christophe Leroy
2022-05-25 16:40 ` Segher Boessenkool [this message]
2022-05-25 16:40 ` Segher Boessenkool
2022-05-25 15:58 ` [RFC PATCH v1 3/4] static_call: Call static_call_init() from start_kernel() Christophe Leroy
2022-05-25 15:58 ` Christophe Leroy
2022-05-25 15:58 ` [RFC PATCH v1 4/4] powerpc/static_call: Implement inline static calls Christophe Leroy
2022-05-25 15:58 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525164054.GO25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=christophe.leroy@csgroup.eu \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.