From: Jim Quinlan <jim2101024@gmail.com>
To: linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
james.dutton@gmail.com, Cyril Brulebois <kibi@debian.org>,
bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com,
james.quinlan@broadcom.com
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
BCM2711/BCM2835 ARM ARCHITECTURE),
linux-kernel@vger.kernel.org (open list),
linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM
BCM2711/BCM2835 ARM ARCHITECTURE),
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>
Subject: [PATCH v2 0/1] PCI: brcmstb: Fix regression regarding missing PCIe linkup
Date: Sat, 28 May 2022 18:44:22 -0400 [thread overview]
Message-ID: <20220528224423.7017-1-jim2101024@gmail.com> (raw)
v2 -- Replace using the condition "bus->number == 1" and instead
use "pci_is_root_bus(bus->parent)". Although I initially
planned to get/enable regulators under and port device,
this became more complicated for this regression fix.
-- Corrected the commit message in v1 to say "Root Port DT
node" rather than "Endpoint DT node".
-- brcm_pcie_add_bus() now returns 0 if there is an error in
error in calling pci_subdev_regulators_add_bus(). Instead,
we dev_err() and turn on our refusal mode instead.
-- The pci_subdev_regulators_remove_bus() function now calls
regulator_bulk_free() in addtion to regulator_bulk_disable().
I noticed that this call was missing after Bjorn had me detail
the call graph for removing the bus when pcie link-up failed.
-- Rewrote and added some comments.
v1 -- Original
Jim Quinlan (1):
PCI: brcmstb: Fix regression regarding missing PCIe linkup
drivers/pci/controller/pcie-brcmstb.c | 43 +++++++++++++++++++--------
1 file changed, 30 insertions(+), 13 deletions(-)
base-commit: ef1302160bfb19f804451d0e919266703501c875
prerequisite-patch-id: 23a425390a4226bd70bbff459148c80f5e28379c
prerequisite-patch-id: e3f2875124b46b2b1cf9ea28883bf0c864b79479
prerequisite-patch-id: 9cdd706ee2038c7b393c4d65ff76a1873df1ca03
prerequisite-patch-id: 332ac90be6e4e4110e27bdd1caaff212c129f547
prerequisite-patch-id: 32a74f87cbfe9e8d52c34a4edeee6d271925665a
prerequisite-patch-id: f57cdf7ec7080bb8c95782bc7c3ec672db8ec1ce
prerequisite-patch-id: 18dc9236aed47f708f5c854afd832f3c80be5ea7
prerequisite-patch-id: dd147c6854c4ca12a9a8bd4f5714968a59d60e4e
prerequisite-patch-id: 0905430e81a95900a1366916fe2940b848317a7c
prerequisite-patch-id: 710896210c50354d87f6025fe0bd1b89981138eb
prerequisite-patch-id: 97d3886cb911cb12ef3d514fdfff2a0ab11e8570
prerequisite-patch-id: 241f1e1878fc177d941f4982ca12779a29feb62b
prerequisite-patch-id: d856608825e2294297db5d7f88f8c180f3e5a1f2
prerequisite-patch-id: 92bcbc9772fb4d248157bcf35e799ac37be8ee45
prerequisite-patch-id: 6f4b1aac459bb54523ade0e87c04e9d6c45bd9f5
prerequisite-patch-id: 090ee7a3112a4ecb03805b23ed10e2c96b3b34ed
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Jim Quinlan <jim2101024@gmail.com>
To: linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
james.dutton@gmail.com, Cyril Brulebois <kibi@debian.org>,
bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com,
james.quinlan@broadcom.com
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
BCM2711/BCM2835 ARM ARCHITECTURE),
linux-kernel@vger.kernel.org (open list),
linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM
BCM2711/BCM2835 ARM ARCHITECTURE),
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>
Subject: [PATCH v2 0/1] PCI: brcmstb: Fix regression regarding missing PCIe linkup
Date: Sat, 28 May 2022 18:44:22 -0400 [thread overview]
Message-ID: <20220528224423.7017-1-jim2101024@gmail.com> (raw)
v2 -- Replace using the condition "bus->number == 1" and instead
use "pci_is_root_bus(bus->parent)". Although I initially
planned to get/enable regulators under and port device,
this became more complicated for this regression fix.
-- Corrected the commit message in v1 to say "Root Port DT
node" rather than "Endpoint DT node".
-- brcm_pcie_add_bus() now returns 0 if there is an error in
error in calling pci_subdev_regulators_add_bus(). Instead,
we dev_err() and turn on our refusal mode instead.
-- The pci_subdev_regulators_remove_bus() function now calls
regulator_bulk_free() in addtion to regulator_bulk_disable().
I noticed that this call was missing after Bjorn had me detail
the call graph for removing the bus when pcie link-up failed.
-- Rewrote and added some comments.
v1 -- Original
Jim Quinlan (1):
PCI: brcmstb: Fix regression regarding missing PCIe linkup
drivers/pci/controller/pcie-brcmstb.c | 43 +++++++++++++++++++--------
1 file changed, 30 insertions(+), 13 deletions(-)
base-commit: ef1302160bfb19f804451d0e919266703501c875
prerequisite-patch-id: 23a425390a4226bd70bbff459148c80f5e28379c
prerequisite-patch-id: e3f2875124b46b2b1cf9ea28883bf0c864b79479
prerequisite-patch-id: 9cdd706ee2038c7b393c4d65ff76a1873df1ca03
prerequisite-patch-id: 332ac90be6e4e4110e27bdd1caaff212c129f547
prerequisite-patch-id: 32a74f87cbfe9e8d52c34a4edeee6d271925665a
prerequisite-patch-id: f57cdf7ec7080bb8c95782bc7c3ec672db8ec1ce
prerequisite-patch-id: 18dc9236aed47f708f5c854afd832f3c80be5ea7
prerequisite-patch-id: dd147c6854c4ca12a9a8bd4f5714968a59d60e4e
prerequisite-patch-id: 0905430e81a95900a1366916fe2940b848317a7c
prerequisite-patch-id: 710896210c50354d87f6025fe0bd1b89981138eb
prerequisite-patch-id: 97d3886cb911cb12ef3d514fdfff2a0ab11e8570
prerequisite-patch-id: 241f1e1878fc177d941f4982ca12779a29feb62b
prerequisite-patch-id: d856608825e2294297db5d7f88f8c180f3e5a1f2
prerequisite-patch-id: 92bcbc9772fb4d248157bcf35e799ac37be8ee45
prerequisite-patch-id: 6f4b1aac459bb54523ade0e87c04e9d6c45bd9f5
prerequisite-patch-id: 090ee7a3112a4ecb03805b23ed10e2c96b3b34ed
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2022-05-28 22:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 22:44 Jim Quinlan [this message]
2022-05-28 22:44 ` [PATCH v2 0/1] PCI: brcmstb: Fix regression regarding missing PCIe linkup Jim Quinlan
2022-05-28 22:44 ` [PATCH v2 1/1] " Jim Quinlan
2022-05-28 22:44 ` Jim Quinlan
2022-05-29 1:15 ` Cyril Brulebois
2022-05-29 1:15 ` Cyril Brulebois
2022-05-29 2:11 ` Jim Quinlan
2022-05-29 2:11 ` Jim Quinlan
2022-05-30 10:12 ` Stefan Wahren
2022-05-30 10:12 ` Stefan Wahren
2022-06-02 19:17 ` Cyril Brulebois
2022-06-02 19:17 ` Cyril Brulebois
2022-06-02 20:05 ` Bjorn Helgaas
2022-06-02 20:05 ` Bjorn Helgaas
2022-06-04 20:59 ` Jim Quinlan
2022-06-04 20:59 ` Jim Quinlan
2022-05-29 16:52 ` Jim Quinlan
2022-05-29 16:52 ` Jim Quinlan
2022-05-29 17:36 ` Thorsten Leemhuis
2022-05-29 17:36 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220528224423.7017-1-jim2101024@gmail.com \
--to=jim2101024@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=james.dutton@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=kibi@debian.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.