All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: "Kamde, Tanuj" <tanuj.kamde@amd.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	Wu Zongyong <wuzongyong@linux.alibaba.com>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	"pabloc@xilinx.com" <pabloc@xilinx.com>,
	Eli Cohen <elic@nvidia.com>, Zhang Min <zhang.min9@zte.com.cn>,
	"lulu@redhat.com" <lulu@redhat.com>,
	"Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
	"martinh@xilinx.com" <martinh@xilinx.com>,
	Xie Yongji <xieyongji@bytedance.com>,
	"dinang@xilinx.com" <dinang@xilinx.com>,
	"habetsm.xilinx@gmail.com" <habetsm.xilinx@gmail.com>,
	Longpeng <longpeng2@huawei.com>,
	"lvivier@redhat.com" <lvivier@redhat.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	"Dawar, Gautam" <gautam.dawar@amd.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
	"hanand@xilinx.com" <hanand@xilinx.com>,
	"martinpo@xilinx.com" <martinpo@xilinx.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: Re: [PATCH v3 2/4] vhost-vdpa: introduce STOP backend feature bit
Date: Mon, 30 May 2022 17:27:25 +0300	[thread overview]
Message-ID: <20220530142725.GU2168@kadam> (raw)
In-Reply-To: <20220527073654.GM2168@kadam>

On Fri, May 27, 2022 at 10:36:55AM +0300, Dan Carpenter wrote:
> static void match_pointer(struct expression *ret_value)
> {
>         struct symbol *type;
>         char *name;
> 
>         type = cur_func_return_type();
>         if (!type || sval_type_max(type).value != 1)
>                 return;
> 
>         if (!is_pointer(ret_value))
>                 return;
> 
>         name = expr_to_str(ret_value);
>         sm_msg("'%s' return pointer cast to bool", name);
>         free_string(name);
> }

I found a bug in Smatch with this check.  With the Smatch bug fixed then
there is only only place which does a legitimate implied pointer to bool
cast.  A different function returns NULL on error instead of false.

drivers/gpu/drm/i915/display/intel_dmc.c:249 intel_dmc_has_payload() 'i915->dmc.dmc_info[0]->payload' return pointer cast to bool
drivers/net/wireless/rndis_wlan.c:1980 rndis_bss_info_update() '(0)' return pointer cast to bool
drivers/net/wireless/rndis_wlan.c:1989 rndis_bss_info_update() '(0)' return pointer cast to bool
drivers/net/wireless/rndis_wlan.c:1995 rndis_bss_info_update() '(0)' return pointer cast to bool

regards,
dan carpenter

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
	"Dawar, Gautam" <gautam.dawar@amd.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	Jason Wang <jasowang@redhat.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	"martinh@xilinx.com" <martinh@xilinx.com>,
	"ecree.xilinx@gmail.com" <ecree.xilinx@gmail.com>,
	Eli Cohen <elic@nvidia.com>, Parav Pandit <parav@nvidia.com>,
	Wu Zongyong <wuzongyong@linux.alibaba.com>,
	"dinang@xilinx.com" <dinang@xilinx.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Xie Yongji <xieyongji@bytedance.com>,
	"lulu@redhat.com" <lulu@redhat.com>,
	"martinpo@xilinx.com" <martinpo@xilinx.com>,
	"pabloc@xilinx.com" <pabloc@xilinx.com>,
	Longpeng <longpeng2@huawei.com>,
	"Piotr.Uminski@intel.com" <Piotr.Uminski@intel.com>,
	"Kamde, Tanuj" <tanuj.kamde@amd.com>,
	Si-Wei Liu <si-wei.liu@oracle.com>,
	"habetsm.xilinx@gmail.com" <habetsm.xilinx@gmail.com>,
	"lvivier@redhat.com" <lvivier@redhat.com>,
	Zhang Min <zhang.min9@zte.com.cn>,
	"hanand@xilinx.com" <hanand@xilinx.com>
Subject: Re: [PATCH v3 2/4] vhost-vdpa: introduce STOP backend feature bit
Date: Mon, 30 May 2022 17:27:25 +0300	[thread overview]
Message-ID: <20220530142725.GU2168@kadam> (raw)
In-Reply-To: <20220527073654.GM2168@kadam>

On Fri, May 27, 2022 at 10:36:55AM +0300, Dan Carpenter wrote:
> static void match_pointer(struct expression *ret_value)
> {
>         struct symbol *type;
>         char *name;
> 
>         type = cur_func_return_type();
>         if (!type || sval_type_max(type).value != 1)
>                 return;
> 
>         if (!is_pointer(ret_value))
>                 return;
> 
>         name = expr_to_str(ret_value);
>         sm_msg("'%s' return pointer cast to bool", name);
>         free_string(name);
> }

I found a bug in Smatch with this check.  With the Smatch bug fixed then
there is only only place which does a legitimate implied pointer to bool
cast.  A different function returns NULL on error instead of false.

drivers/gpu/drm/i915/display/intel_dmc.c:249 intel_dmc_has_payload() 'i915->dmc.dmc_info[0]->payload' return pointer cast to bool
drivers/net/wireless/rndis_wlan.c:1980 rndis_bss_info_update() '(0)' return pointer cast to bool
drivers/net/wireless/rndis_wlan.c:1989 rndis_bss_info_update() '(0)' return pointer cast to bool
drivers/net/wireless/rndis_wlan.c:1995 rndis_bss_info_update() '(0)' return pointer cast to bool

regards,
dan carpenter


  parent reply	other threads:[~2022-05-30 14:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 10:59 [PATCH v3 0/4] Implement vdpasim stop operation Eugenio Pérez
2022-05-25 10:59 ` [PATCH v3 1/4] vdpa: Add " Eugenio Pérez
2022-05-25 10:59 ` [PATCH v3 2/4] vhost-vdpa: introduce STOP backend feature bit Eugenio Pérez
2022-05-25 11:23   ` Dawar, Gautam
2022-05-26  8:57     ` Eugenio Perez Martin
2022-05-26  9:07       ` Stefano Garzarella
2022-05-26  9:07         ` Stefano Garzarella
2022-05-26 12:44         ` Eugenio Perez Martin
2022-05-26 13:20           ` Dan Carpenter
2022-05-26 13:20             ` Dan Carpenter
2022-05-26 17:00             ` Eugenio Perez Martin
2022-05-26 19:06               ` Dan Carpenter
2022-05-26 19:06                 ` Dan Carpenter
2022-05-27  6:50                 ` Eugenio Perez Martin
2022-05-27  7:36                   ` Dan Carpenter
2022-05-27  7:36                     ` Dan Carpenter
2022-05-27 14:13                     ` Dawar, Gautam
2022-05-30 14:27                     ` Dan Carpenter [this message]
2022-05-30 14:27                       ` Dan Carpenter
2022-05-30 15:12                       ` Dan Carpenter
2022-05-30 15:12                         ` Dan Carpenter
2022-05-25 10:59 ` [PATCH v3 3/4] vhost-vdpa: uAPI to stop the device Eugenio Pérez
2022-05-25 14:32   ` kernel test robot
2022-05-25 14:32     ` kernel test robot
2022-05-25 17:52   ` kernel test robot
2022-05-25 17:52     ` kernel test robot
2022-05-25 10:59 ` [PATCH v3 4/4] vdpa_sim: Implement stop vdpa op Eugenio Pérez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220530142725.GU2168@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Piotr.Uminski@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dinang@xilinx.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=elic@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=gautam.dawar@amd.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=hanand@xilinx.com \
    --cc=kvm@vger.kernel.org \
    --cc=lingshan.zhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longpeng2@huawei.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=martinh@xilinx.com \
    --cc=martinpo@xilinx.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabloc@xilinx.com \
    --cc=si-wei.liu@oracle.com \
    --cc=tanuj.kamde@amd.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wuzongyong@linux.alibaba.com \
    --cc=xieyongji@bytedance.com \
    --cc=zhang.min9@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.