All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737
@ 2022-05-31 21:01 Fabrice Fontaine
  2022-05-31 23:03 ` Giulio Benetti
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-05-31 21:01 UTC (permalink / raw)
  To: buildroot
  Cc: Romain Naour, Giulio Benetti, Thomas De Schampheleire,
	Thomas Petazzoni, Fabrice Fontaine

pixman fails to build with BR2_OPTIMIZE_S on sh4{eb,a,aeb}:

In file included from pixman-fast-path.c:33:
pixman-fast-path.c: In function 'fast_composite_scaled_nearest_8888_565_normal_OVER':
pixman-inlines.h:586:1: internal compiler error: Segmentation fault
  586 | }
      | ^

Fixes:
 - http://autobuild.buildroot.org/results/c9d35d5975311a191dfbe12291398503987e804e
 - http://autobuild.buildroot.org/results/d34b8672f6211d60af4122bdd94fa8c2f4f4bf6a
 - http://autobuild.buildroot.org/results/933c4a2e73c987573ecc97172f442b78199462d5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 toolchain/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 73ea78624a..7584b85f71 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -199,7 +199,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
 # still exists in gcc = 11.1.0
 config BR2_TOOLCHAIN_HAS_GCC_BUG_101737
 	bool
-	default y if BR2_sh4
+	default y if BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101915
 # ICE: in extract_insn, at recog.c:2294 on microblaze.
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737
  2022-05-31 21:01 [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737 Fabrice Fontaine
@ 2022-05-31 23:03 ` Giulio Benetti
  2022-05-31 23:20   ` Giulio Benetti
  2022-06-01 12:44 ` Thomas Petazzoni via buildroot
  2022-06-07 13:57 ` Peter Korsgaard
  2 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2022-05-31 23:03 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot
  Cc: Romain Naour, Thomas Petazzoni, Thomas De Schampheleire

Hi Fabrice,

On 31/05/22 23:01, Fabrice Fontaine wrote:
> pixman fails to build with BR2_OPTIMIZE_S on sh4{eb,a,aeb}:
> 
> In file included from pixman-fast-path.c:33:
> pixman-fast-path.c: In function 'fast_composite_scaled_nearest_8888_565_normal_OVER':
> pixman-inlines.h:586:1: internal compiler error: Segmentation fault
>    586 | }
>        | ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/c9d35d5975311a191dfbe12291398503987e804e
>   - http://autobuild.buildroot.org/results/d34b8672f6211d60af4122bdd94fa8c2f4f4bf6a
>   - http://autobuild.buildroot.org/results/933c4a2e73c987573ecc97172f442b78199462d5
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   toolchain/Config.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 73ea78624a..7584b85f71 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -199,7 +199,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
>   # still exists in gcc = 11.1.0
>   config BR2_TOOLCHAIN_HAS_GCC_BUG_101737
>   	bool
> -	default y if BR2_sh4
> +	default y if BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb

I've seen only now that BR2_sh4 stands only for:
"sh4 (SH4 little endian)"
Here I've meant to make it default y when any BR2_sh4* is selected.
But at this point I would use BR2_sh since if we have that selected
then all BR_sh4* cases are included and no other BR2_sh* is present.

Can you please modify according to that?

Thanks a lot
Kind regards
-- 
Giulio Benetti
CTO/CEO@Benetti Engineering sas

>   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101915
>   # ICE: in extract_insn, at recog.c:2294 on microblaze.

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737
  2022-05-31 23:03 ` Giulio Benetti
@ 2022-05-31 23:20   ` Giulio Benetti
  0 siblings, 0 replies; 6+ messages in thread
From: Giulio Benetti @ 2022-05-31 23:20 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot
  Cc: Romain Naour, Thomas De Schampheleire, Thomas Petazzoni

On 01/06/22 01:03, Giulio Benetti wrote:
> Hi Fabrice,
> 
> On 31/05/22 23:01, Fabrice Fontaine wrote:
>> pixman fails to build with BR2_OPTIMIZE_S on sh4{eb,a,aeb}:
>>
>> In file included from pixman-fast-path.c:33:
>> pixman-fast-path.c: In function 
>> 'fast_composite_scaled_nearest_8888_565_normal_OVER':
>> pixman-inlines.h:586:1: internal compiler error: Segmentation fault
>>    586 | }
>>        | ^
>>
>> Fixes:
>>   - 
>> http://autobuild.buildroot.org/results/c9d35d5975311a191dfbe12291398503987e804e 
>>
>>   - 
>> http://autobuild.buildroot.org/results/d34b8672f6211d60af4122bdd94fa8c2f4f4bf6a 
>>
>>   - 
>> http://autobuild.buildroot.org/results/933c4a2e73c987573ecc97172f442b78199462d5 
>>
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>>   toolchain/Config.in | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/toolchain/Config.in b/toolchain/Config.in
>> index 73ea78624a..7584b85f71 100644
>> --- a/toolchain/Config.in
>> +++ b/toolchain/Config.in
>> @@ -199,7 +199,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_99140
>>   # still exists in gcc = 11.1.0
>>   config BR2_TOOLCHAIN_HAS_GCC_BUG_101737
>>       bool
>> -    default y if BR2_sh4
>> +    default y if BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb
> 
> I've seen only now that BR2_sh4 stands only for:
> "sh4 (SH4 little endian)"
> Here I've meant to make it default y when any BR2_sh4* is selected.
> But at this point I would use BR2_sh since if we have that selected
> then all BR_sh4* cases are included and no other BR2_sh* is present.
> 
> Can you please modify according to that?

And with that change:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

-- 
Giulio Benetti
CTO/CEO@Benetti Engineering sas

> Thanks a lot
> Kind regards
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737
  2022-05-31 21:01 [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737 Fabrice Fontaine
  2022-05-31 23:03 ` Giulio Benetti
@ 2022-06-01 12:44 ` Thomas Petazzoni via buildroot
  2022-06-01 13:07   ` Giulio Benetti
  2022-06-07 13:57 ` Peter Korsgaard
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-06-01 12:44 UTC (permalink / raw)
  To: Fabrice Fontaine
  Cc: Romain Naour, Giulio Benetti, Thomas De Schampheleire, buildroot

On Tue, 31 May 2022 23:01:09 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> pixman fails to build with BR2_OPTIMIZE_S on sh4{eb,a,aeb}:
> 
> In file included from pixman-fast-path.c:33:
> pixman-fast-path.c: In function 'fast_composite_scaled_nearest_8888_565_normal_OVER':
> pixman-inlines.h:586:1: internal compiler error: Segmentation fault
>   586 | }
>       | ^
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/c9d35d5975311a191dfbe12291398503987e804e
>  - http://autobuild.buildroot.org/results/d34b8672f6211d60af4122bdd94fa8c2f4f4bf6a
>  - http://autobuild.buildroot.org/results/933c4a2e73c987573ecc97172f442b78199462d5
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  toolchain/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master after changing to use BR2_sh, as suggested by Giulio.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737
  2022-06-01 12:44 ` Thomas Petazzoni via buildroot
@ 2022-06-01 13:07   ` Giulio Benetti
  0 siblings, 0 replies; 6+ messages in thread
From: Giulio Benetti @ 2022-06-01 13:07 UTC (permalink / raw)
  To: Thomas Petazzoni, Fabrice Fontaine
  Cc: Romain Naour, Thomas De Schampheleire, buildroot

Hi Thomas,

On 01/06/22 14:44, Thomas Petazzoni via buildroot wrote:
> On Tue, 31 May 2022 23:01:09 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
>> pixman fails to build with BR2_OPTIMIZE_S on sh4{eb,a,aeb}:
>>
>> In file included from pixman-fast-path.c:33:
>> pixman-fast-path.c: In function 'fast_composite_scaled_nearest_8888_565_normal_OVER':
>> pixman-inlines.h:586:1: internal compiler error: Segmentation fault
>>    586 | }
>>        | ^
>>
>> Fixes:
>>   - http://autobuild.buildroot.org/results/c9d35d5975311a191dfbe12291398503987e804e
>>   - http://autobuild.buildroot.org/results/d34b8672f6211d60af4122bdd94fa8c2f4f4bf6a
>>   - http://autobuild.buildroot.org/results/933c4a2e73c987573ecc97172f442b78199462d5
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>>   toolchain/Config.in | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master after changing to use BR2_sh, as suggested by Giulio.

This patchset[1] is a bugfix similar to this and still produces 
errors[2]. Can you apply it since 2022.05 is going to be released?

Best regards

[1]: https://patchwork.ozlabs.org/project/buildroot/list/?series=281093
[2]: http://autobuild.buildroot.net/index.php?reason=sg3_utils-1.47

-- 
Giulio Benetti
CTO/CEO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737
  2022-05-31 21:01 [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737 Fabrice Fontaine
  2022-05-31 23:03 ` Giulio Benetti
  2022-06-01 12:44 ` Thomas Petazzoni via buildroot
@ 2022-06-07 13:57 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-06-07 13:57 UTC (permalink / raw)
  To: Fabrice Fontaine
  Cc: Thomas Petazzoni, Romain Naour, Giulio Benetti,
	Thomas De Schampheleire, buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > pixman fails to build with BR2_OPTIMIZE_S on sh4{eb,a,aeb}:
 > In file included from pixman-fast-path.c:33:
 > pixman-fast-path.c: In function 'fast_composite_scaled_nearest_8888_565_normal_OVER':
 > pixman-inlines.h:586:1: internal compiler error: Segmentation fault
 >   586 | }
 >       | ^

 > Fixes:
 >  - http://autobuild.buildroot.org/results/c9d35d5975311a191dfbe12291398503987e804e
 >  - http://autobuild.buildroot.org/results/d34b8672f6211d60af4122bdd94fa8c2f4f4bf6a
 >  - http://autobuild.buildroot.org/results/933c4a2e73c987573ecc97172f442b78199462d5

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-07 13:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-31 21:01 [Buildroot] [PATCH 1/1] toolchain/Config.in: sh4{eb, a, aeb} are affected by GCC bug 101737 Fabrice Fontaine
2022-05-31 23:03 ` Giulio Benetti
2022-05-31 23:20   ` Giulio Benetti
2022-06-01 12:44 ` Thomas Petazzoni via buildroot
2022-06-01 13:07   ` Giulio Benetti
2022-06-07 13:57 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.