All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Liang Yang <liang.yang@amlogic.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	Richard Weinberger <richard@nod.at>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Kelvin Zhang <kelvin.zhang@amlogic.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock
Date: Wed, 1 Jun 2022 14:51:04 -0500	[thread overview]
Message-ID: <20220601195104.GA320194-robh@kernel.org> (raw)
In-Reply-To: <20220513123404.48513-2-liang.yang@amlogic.com>

On Fri, 13 May 2022 20:34:01 +0800, Liang Yang wrote:
> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
> a common MMC and NAND sub-clock was discussed and planed to be implemented
> as NFC clock provider, but now this series of patches of a common MMC and
> NAND sub-clock are never being accepted and the current binding was never
> valid. the reasons are:
> 1. EMMC and NAND, which are mutually exclusive anyway
> 2. coupling the EMMC and NAND.
> 3. it seems that a common MMC and NAND sub-clock is over engineered.
> and let us see the link for more information:
> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
> so The meson nfc can't work now, let us rework the clock.
> 
> Signed-off-by: Liang Yang <liang.yang@amlogic.com>
> ---
>  .../bindings/mtd/amlogic,meson-nand.txt       | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Liang Yang <liang.yang@amlogic.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	Richard Weinberger <richard@nod.at>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Kelvin Zhang <kelvin.zhang@amlogic.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock
Date: Wed, 1 Jun 2022 14:51:04 -0500	[thread overview]
Message-ID: <20220601195104.GA320194-robh@kernel.org> (raw)
In-Reply-To: <20220513123404.48513-2-liang.yang@amlogic.com>

On Fri, 13 May 2022 20:34:01 +0800, Liang Yang wrote:
> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
> a common MMC and NAND sub-clock was discussed and planed to be implemented
> as NFC clock provider, but now this series of patches of a common MMC and
> NAND sub-clock are never being accepted and the current binding was never
> valid. the reasons are:
> 1. EMMC and NAND, which are mutually exclusive anyway
> 2. coupling the EMMC and NAND.
> 3. it seems that a common MMC and NAND sub-clock is over engineered.
> and let us see the link for more information:
> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
> so The meson nfc can't work now, let us rework the clock.
> 
> Signed-off-by: Liang Yang <liang.yang@amlogic.com>
> ---
>  .../bindings/mtd/amlogic,meson-nand.txt       | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Liang Yang <liang.yang@amlogic.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	Richard Weinberger <richard@nod.at>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Kelvin Zhang <kelvin.zhang@amlogic.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock
Date: Wed, 1 Jun 2022 14:51:04 -0500	[thread overview]
Message-ID: <20220601195104.GA320194-robh@kernel.org> (raw)
In-Reply-To: <20220513123404.48513-2-liang.yang@amlogic.com>

On Fri, 13 May 2022 20:34:01 +0800, Liang Yang wrote:
> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
> a common MMC and NAND sub-clock was discussed and planed to be implemented
> as NFC clock provider, but now this series of patches of a common MMC and
> NAND sub-clock are never being accepted and the current binding was never
> valid. the reasons are:
> 1. EMMC and NAND, which are mutually exclusive anyway
> 2. coupling the EMMC and NAND.
> 3. it seems that a common MMC and NAND sub-clock is over engineered.
> and let us see the link for more information:
> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
> so The meson nfc can't work now, let us rework the clock.
> 
> Signed-off-by: Liang Yang <liang.yang@amlogic.com>
> ---
>  .../bindings/mtd/amlogic,meson-nand.txt       | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Liang Yang <liang.yang@amlogic.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-arm-kernel@lists.infradead.org,
	XianWei Zhao <xianwei.zhao@amlogic.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	YongHui Yu <yonghui.yu@amlogic.com>,
	Richard Weinberger <richard@nod.at>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <narmstrong@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Victor Wan <victor.wan@amlogic.com>,
	BiChao Zheng <bichao.zheng@amlogic.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Kelvin Zhang <kelvin.zhang@amlogic.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock
Date: Wed, 1 Jun 2022 14:51:04 -0500	[thread overview]
Message-ID: <20220601195104.GA320194-robh@kernel.org> (raw)
In-Reply-To: <20220513123404.48513-2-liang.yang@amlogic.com>

On Fri, 13 May 2022 20:34:01 +0800, Liang Yang wrote:
> EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK'
> which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is
> the divider and bit6~7 is the mux for fix pll and xtal. At the beginning,
> a common MMC and NAND sub-clock was discussed and planed to be implemented
> as NFC clock provider, but now this series of patches of a common MMC and
> NAND sub-clock are never being accepted and the current binding was never
> valid. the reasons are:
> 1. EMMC and NAND, which are mutually exclusive anyway
> 2. coupling the EMMC and NAND.
> 3. it seems that a common MMC and NAND sub-clock is over engineered.
> and let us see the link for more information:
> https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com
> so The meson nfc can't work now, let us rework the clock.
> 
> Signed-off-by: Liang Yang <liang.yang@amlogic.com>
> ---
>  .../bindings/mtd/amlogic,meson-nand.txt       | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2022-06-01 19:51 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 12:34 [PATCH v5 0/4] fix the meson NFC clock Liang Yang
2022-05-13 12:34 ` Liang Yang
2022-05-13 12:34 ` Liang Yang
2022-05-13 12:34 ` Liang Yang
2022-05-13 12:34 ` [PATCH v5 1/4] dt-bindings: nand: meson: fix meson nfc clock Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-06-01 19:51   ` Rob Herring [this message]
2022-06-01 19:51     ` Rob Herring
2022-06-01 19:51     ` Rob Herring
2022-06-01 19:51     ` Rob Herring
2022-05-13 12:34 ` [PATCH v5 2/4] mtd: rawnand: meson: fix the clock Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 13:11   ` Neil Armstrong
2022-05-14  1:51   ` kernel test robot
2022-05-14  1:51     ` kernel test robot
2022-05-14  1:51     ` kernel test robot
2022-05-14  1:51     ` kernel test robot
2022-05-26 16:28   ` Kevin Hilman
2022-05-26 16:28     ` Kevin Hilman
2022-05-26 16:28     ` Kevin Hilman
2022-05-26 16:28     ` Kevin Hilman
2022-05-27  3:20     ` Liang Yang
2022-05-27  3:20       ` Liang Yang
2022-05-27  3:20       ` Liang Yang
2022-05-27  3:20       ` Liang Yang
2022-05-13 12:34 ` [PATCH v5 3/4] mtd: rawnand: meson: refine resource getting in probe Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 13:12   ` Neil Armstrong
2022-05-13 13:12     ` Neil Armstrong
2022-05-13 13:12     ` Neil Armstrong
2022-05-13 13:12     ` Neil Armstrong
2022-05-26 16:27   ` Kevin Hilman
2022-05-26 16:27     ` Kevin Hilman
2022-05-26 16:27     ` Kevin Hilman
2022-05-26 16:27     ` Kevin Hilman
2022-05-27  3:18     ` Liang Yang
2022-05-27  3:18       ` Liang Yang
2022-05-27  3:18       ` Liang Yang
2022-05-27  3:18       ` Liang Yang
2022-05-13 12:34 ` [PATCH v5 4/4] dt-bindings: nand: meson: convert txt to yaml Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-13 12:34   ` Liang Yang
2022-05-31  7:08 ` [PATCH v5 0/4] fix the meson NFC clock Peter Suti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601195104.GA320194-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bichao.zheng@amlogic.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jianxin.pan@amlogic.com \
    --cc=kelvin.zhang@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=liang.yang@amlogic.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=narmstrong@baylibre.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=victor.wan@amlogic.com \
    --cc=vigneshr@ti.com \
    --cc=xianwei.zhao@amlogic.com \
    --cc=yonghui.yu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.