* [PATCH v3 1/2] dt-bindings: soc: add samsung,boot-mode definitions
2022-05-23 12:12 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
@ 2022-05-23 12:12 ` Chanho Park
2022-06-02 13:34 ` Rob Herring
2022-05-23 12:12 ` [PATCH v3 2/2] arm64: dts: exynoautov9: add syscon reboot/reboot_mode support Chanho Park
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Chanho Park @ 2022-05-23 12:12 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Alim Akhtar, Chanwoo Choi, Sam Protsenko, linux-samsung-soc,
devicetree, Chanho Park
Adds samsung,boot-mode.h header file which contains boot mode
definitions for bootloader. As for now, there are only boot mode
definitions for Exynos Auto v9 SoC.
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
include/dt-bindings/soc/samsung,boot-mode.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 include/dt-bindings/soc/samsung,boot-mode.h
diff --git a/include/dt-bindings/soc/samsung,boot-mode.h b/include/dt-bindings/soc/samsung,boot-mode.h
new file mode 100644
index 000000000000..47ef1cdd3916
--- /dev/null
+++ b/include/dt-bindings/soc/samsung,boot-mode.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2022 Samsung Electronics Co., Ltd.
+ * Author: Chanho Park <chanho61.park@samsung.com>
+ *
+ * Device Tree bindings for Samsung Boot Mode.
+ */
+
+#ifndef __DT_BINDINGS_SAMSUNG_BOOT_MODE_H
+#define __DT_BINDINGS_SAMSUNG_BOOT_MODE_H
+
+/* Boot mode definitions for Exynos Auto v9 SoC */
+
+#define EXYNOSAUTOV9_BOOT_FASTBOOT 0xfa
+#define EXYNOSAUTOV9_BOOT_BOOTLOADER 0xfc
+#define EXYNOSAUTOV9_BOOT_RECOVERY 0xff
+
+#endif /* __DT_BINDINGS_SAMSUNG_BOOT_MODE_H */
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: soc: add samsung,boot-mode definitions
2022-05-23 12:12 ` [PATCH v3 1/2] dt-bindings: soc: add samsung,boot-mode definitions Chanho Park
@ 2022-06-02 13:34 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-06-02 13:34 UTC (permalink / raw)
To: Chanho Park
Cc: Rob Herring, Sam Protsenko, linux-samsung-soc, devicetree,
Alim Akhtar, Chanwoo Choi, Krzysztof Kozlowski
On Mon, 23 May 2022 21:12:43 +0900, Chanho Park wrote:
> Adds samsung,boot-mode.h header file which contains boot mode
> definitions for bootloader. As for now, there are only boot mode
> definitions for Exynos Auto v9 SoC.
>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> include/dt-bindings/soc/samsung,boot-mode.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 include/dt-bindings/soc/samsung,boot-mode.h
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] arm64: dts: exynoautov9: add syscon reboot/reboot_mode support
2022-05-23 12:12 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
2022-05-23 12:12 ` [PATCH v3 1/2] dt-bindings: soc: add samsung,boot-mode definitions Chanho Park
@ 2022-05-23 12:12 ` Chanho Park
2022-05-31 12:36 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
2022-06-06 9:22 ` Krzysztof Kozlowski
3 siblings, 0 replies; 8+ messages in thread
From: Chanho Park @ 2022-05-23 12:12 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Alim Akhtar, Chanwoo Choi, Sam Protsenko, linux-samsung-soc,
devicetree, Chanho Park
Reboot of exynosautov9 SoC can be handled by setting the bit(
SWRESET_SYSTEM[1]) of SYSTEM_CONFIGURATION register(PMU + 0x3a00).
syscon-reboot-mode can be used to indicate the reboot mode for
bootloader. SYSIP_DAT0 register(PMU + 0x810) will not be cleared after
reboot so bootloader can enter the boot mode according to the value.
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index 0ce46ec5cdc3..3e23db8f09d9 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -8,6 +8,7 @@
#include <dt-bindings/clock/samsung,exynosautov9.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/soc/samsung,boot-mode.h>
#include <dt-bindings/soc/samsung,exynos-usi.h>
/ {
@@ -312,6 +313,22 @@ pinctrl_peric1: pinctrl@10830000 {
pmu_system_controller: system-controller@10460000 {
compatible = "samsung,exynos7-pmu", "syscon";
reg = <0x10460000 0x10000>;
+
+ reboot: syscon-reboot {
+ compatible = "syscon-reboot";
+ regmap = <&pmu_system_controller>;
+ offset = <0x3a00>; /* SYSTEM_CONFIGURATION */
+ value = <0x2>;
+ mask = <0x2>;
+ };
+
+ reboot-mode {
+ compatible = "syscon-reboot-mode";
+ offset = <0x810>; /* SYSIP_DAT0 */
+ mode-bootloader = <EXYNOSAUTOV9_BOOT_BOOTLOADER>;
+ mode-fastboot = <EXYNOSAUTOV9_BOOT_FASTBOOT>;
+ mode-recovery = <EXYNOSAUTOV9_BOOT_RECOVERY>;
+ };
};
syscon_fsys2: syscon@17c20000 {
--
2.36.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* RE: [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9
2022-05-23 12:12 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
2022-05-23 12:12 ` [PATCH v3 1/2] dt-bindings: soc: add samsung,boot-mode definitions Chanho Park
2022-05-23 12:12 ` [PATCH v3 2/2] arm64: dts: exynoautov9: add syscon reboot/reboot_mode support Chanho Park
@ 2022-05-31 12:36 ` Chanho Park
2022-05-31 12:50 ` Krzysztof Kozlowski
2022-06-06 9:22 ` Krzysztof Kozlowski
3 siblings, 1 reply; 8+ messages in thread
From: Chanho Park @ 2022-05-31 12:36 UTC (permalink / raw)
To: 'Rob Herring', 'Krzysztof Kozlowski',
'Krzysztof Kozlowski'
Cc: 'Alim Akhtar', 'Chanwoo Choi',
'Sam Protsenko', linux-samsung-soc, devicetree
Hi Krzysztof,
Could you review below v3 patchset in your free time? :)
Best Regards,
Chanho Park
> -----Original Message-----
> From: Chanho Park <chanho61.park@samsung.com>
> Sent: Monday, May 23, 2022 9:13 PM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>; Sam Protsenko <semen.protsenko@linaro.org>;
> linux-samsung-soc@vger.kernel.org; devicetree@vger.kernel.org; Chanho Park
> <chanho61.park@samsung.com>
> Subject: [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9
>
> This adds to support syscon reboot and reboot_mode for Exynos Auto v9 SoC.
>
> Changes from v2:
> - Change license of samsung,boot-mode.h to (GPL-2.0-only OR BSD-2-Clause)
> - Add copyright of samsung,boot-mode.h
> - Change ifdef guard __DT_BINDINGS_SAMSUNG_BOOT_MODE_H
> - Remove brackets of the definitions
>
> Changes from v1:
> - Add samsung,boot-mode.h header which include reboot mode definitions
> - syscon-reboot-mode -> reboot-mode
>
> Chanho Park (2):
> dt-bindings: soc: add samsung,boot-mode definitions
> arm64: dts: exynoautov9: add syscon reboot/reboot_mode support
>
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 17 +++++++++++++++++
> include/dt-bindings/soc/samsung,boot-mode.h | 18 ++++++++++++++++++
> 2 files changed, 35 insertions(+)
> create mode 100644 include/dt-bindings/soc/samsung,boot-mode.h
>
> --
> 2.36.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9
2022-05-31 12:36 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
@ 2022-05-31 12:50 ` Krzysztof Kozlowski
2022-06-02 2:07 ` Chanho Park
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 12:50 UTC (permalink / raw)
To: Chanho Park, 'Rob Herring', 'Krzysztof Kozlowski'
Cc: 'Alim Akhtar', 'Chanwoo Choi',
'Sam Protsenko', linux-samsung-soc, devicetree
On 31/05/2022 14:36, Chanho Park wrote:
> Hi Krzysztof,
>
> Could you review below v3 patchset in your free time? :)
I looked at it before and it is fine. It's a merge window so I am not
taking any new patches before rc1.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9
2022-05-23 12:12 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
` (2 preceding siblings ...)
2022-05-31 12:36 ` [PATCH v3 0/2] syscon reboot/reboot_mode support for exynosautov9 Chanho Park
@ 2022-06-06 9:22 ` Krzysztof Kozlowski
3 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-06 9:22 UTC (permalink / raw)
To: Chanho Park, Krzysztof Kozlowski, Rob Herring
Cc: Krzysztof Kozlowski, linux-samsung-soc, devicetree, Sam Protsenko,
Alim Akhtar, Chanwoo Choi
On Mon, 23 May 2022 21:12:42 +0900, Chanho Park wrote:
> This adds to support syscon reboot and reboot_mode for Exynos Auto v9 SoC.
>
> Changes from v2:
> - Change license of samsung,boot-mode.h to (GPL-2.0-only OR BSD-2-Clause)
> - Add copyright of samsung,boot-mode.h
> - Change ifdef guard __DT_BINDINGS_SAMSUNG_BOOT_MODE_H
> - Remove brackets of the definitions
>
> [...]
Applied, thanks!
[1/2] dt-bindings: soc: add samsung,boot-mode definitions
https://git.kernel.org/krzk/linux/c/95099951557c9eb2f180d6bcb9885eecaca97d24
[2/2] arm64: dts: exynoautov9: add syscon reboot/reboot_mode support
https://git.kernel.org/krzk/linux/c/694d04a1d5449d948e438af1fd1d610d356bacc3
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 8+ messages in thread