From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Ernst Sjöstrand" <ernstp@gmail.com>,
kbuild-all@lists.01.org, "kernel test robot" <lkp@intel.com>,
kbuild@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>
Subject: Re: [kbuild] drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
Date: Thu, 2 Jun 2022 18:33:27 +0300 [thread overview]
Message-ID: <20220602153326.GI2168@kadam> (raw)
In-Reply-To: <CADnq5_PZBV0wAnNSLSdTc_8acaK3F6ZKDpcgwktmNaR9DKxG9Q@mail.gmail.com>
On Thu, Jun 02, 2022 at 10:24:58AM -0400, Alex Deucher wrote:
> On Thu, Jun 2, 2022 at 7:51 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sjöstrand wrote:
> > > Dan: I also ran Smatch which resulted in the following discussion:
> > >
> > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html
> >
> > Since the bounds check is dead code which does not make sense and is not
> > required, another idea would be to just delete it.
>
> It wouldn't be dead code if AMDGPU_MAX_VCN_INSTANCES ever increased.
Or we could add a comment to the code I suppose.
/* Impossible in 2022 but this check might sense in the future */
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
Date: Thu, 02 Jun 2022 18:33:27 +0300 [thread overview]
Message-ID: <20220602153326.GI2168@kadam> (raw)
In-Reply-To: <CADnq5_PZBV0wAnNSLSdTc_8acaK3F6ZKDpcgwktmNaR9DKxG9Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Thu, Jun 02, 2022 at 10:24:58AM -0400, Alex Deucher wrote:
> On Thu, Jun 2, 2022 at 7:51 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sjöstrand wrote:
> > > Dan: I also ran Smatch which resulted in the following discussion:
> > >
> > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html
> >
> > Since the bounds check is dead code which does not make sense and is not
> > required, another idea would be to just delete it.
>
> It wouldn't be dead code if AMDGPU_MAX_VCN_INSTANCES ever increased.
Or we could add a comment to the code I suppose.
/* Impossible in 2022 but this check might sense in the future */
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [kbuild] drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
Date: Thu, 02 Jun 2022 18:33:27 +0300 [thread overview]
Message-ID: <20220602153326.GI2168@kadam> (raw)
In-Reply-To: <CADnq5_PZBV0wAnNSLSdTc_8acaK3F6ZKDpcgwktmNaR9DKxG9Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Thu, Jun 02, 2022 at 10:24:58AM -0400, Alex Deucher wrote:
> On Thu, Jun 2, 2022 at 7:51 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sjöstrand wrote:
> > > Dan: I also ran Smatch which resulted in the following discussion:
> > >
> > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html
> >
> > Since the bounds check is dead code which does not make sense and is not
> > required, another idea would be to just delete it.
>
> It wouldn't be dead code if AMDGPU_MAX_VCN_INSTANCES ever increased.
Or we could add a comment to the code I suppose.
/* Impossible in 2022 but this check might sense in the future */
regards,
dan carpenter
next prev parent reply other threads:[~2022-06-02 15:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 7:14 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433 amdgpu_discovery_get_vcn_info() error: buffer overflow 'adev->vcn.vcn_codec_disable_mask' 2 <= 3 kernel test robot
2022-05-27 7:46 ` [kbuild] " Dan Carpenter
2022-05-27 7:46 ` Dan Carpenter
2022-05-27 7:46 ` Dan Carpenter
2022-05-27 7:56 ` Chen, Guchun
2022-05-27 7:56 ` Chen, Guchun
2022-05-27 8:12 ` Dan Carpenter
2022-05-27 8:12 ` Dan Carpenter
2022-05-27 8:12 ` Dan Carpenter
2022-05-27 8:12 ` Dan Carpenter
2022-06-01 18:43 ` [kbuild] " Alex Deucher
2022-06-01 18:43 ` Alex Deucher
2022-06-01 18:43 ` Alex Deucher
2022-06-02 6:26 ` Ernst Sjöstrand
2022-06-02 6:26 ` Ernst Sjöstrand
2022-06-02 11:50 ` Dan Carpenter
2022-06-02 11:50 ` Dan Carpenter
2022-06-02 11:50 ` Dan Carpenter
2022-06-02 11:50 ` Dan Carpenter
2022-06-02 14:24 ` [kbuild] " Alex Deucher
2022-06-02 14:24 ` Alex Deucher
2022-06-02 15:33 ` Dan Carpenter [this message]
2022-06-02 15:33 ` Dan Carpenter
2022-06-02 15:33 ` Dan Carpenter
2022-06-02 15:44 ` [kbuild] " Alex Deucher
2022-06-02 15:44 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602153326.GI2168@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ernstp@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.