From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ming Lei <ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH v6 0/3] blk-cgroup: Optimize blkcg_rstat_flush()
Date: Thu, 2 Jun 2022 15:20:17 -0400 [thread overview]
Message-ID: <20220602192020.166940-1-longman@redhat.com> (raw)
v6:
- Add a missing free_percpu() into blkcg_css_free() in patch 3.
- Integrating the documentation patch 4 back into patch 3.
v5:
- Add a new patch 2 to eliminate the use of intermediate "ret"
variable in blkcg_css_alloc() to fix compilation warning reported
by kernel test robot.
v4:
- Update comment and eliminate "inline" keywords as suggested by TJ.
v3:
- Update comments in patch 2.
- Put rcu_read_lock/unlock() in blkcg_rstat_flush().
- Use READ_ONCE/WRITE_ONCE() to access lnode->next to reduce data
races.
- Get a blkg reference when putting into the lockless list and put it
back when removed.
This patch series improves blkcg_rstat_flush() performance by eliminating
unnecessary blkg enumeration and flush operations for those blkg's and
blkg_iostat_set's that haven't been updated since the last flush.
Waiman Long (3):
blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit
blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
blk-cgroup: Optimize blkcg_rstat_flush()
block/blk-cgroup.c | 119 +++++++++++++++++++++++++++++++++++++++------
block/blk-cgroup.h | 9 ++++
2 files changed, 112 insertions(+), 16 deletions(-)
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Waiman Long <longman@redhat.com>
Subject: [PATCH v6 0/3] blk-cgroup: Optimize blkcg_rstat_flush()
Date: Thu, 2 Jun 2022 15:20:17 -0400 [thread overview]
Message-ID: <20220602192020.166940-1-longman@redhat.com> (raw)
v6:
- Add a missing free_percpu() into blkcg_css_free() in patch 3.
- Integrating the documentation patch 4 back into patch 3.
v5:
- Add a new patch 2 to eliminate the use of intermediate "ret"
variable in blkcg_css_alloc() to fix compilation warning reported
by kernel test robot.
v4:
- Update comment and eliminate "inline" keywords as suggested by TJ.
v3:
- Update comments in patch 2.
- Put rcu_read_lock/unlock() in blkcg_rstat_flush().
- Use READ_ONCE/WRITE_ONCE() to access lnode->next to reduce data
races.
- Get a blkg reference when putting into the lockless list and put it
back when removed.
This patch series improves blkcg_rstat_flush() performance by eliminating
unnecessary blkg enumeration and flush operations for those blkg's and
blkg_iostat_set's that haven't been updated since the last flush.
Waiman Long (3):
blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit
blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
blk-cgroup: Optimize blkcg_rstat_flush()
block/blk-cgroup.c | 119 +++++++++++++++++++++++++++++++++++++++------
block/blk-cgroup.h | 9 ++++
2 files changed, 112 insertions(+), 16 deletions(-)
--
2.31.1
next reply other threads:[~2022-06-02 19:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 19:20 Waiman Long [this message]
2022-06-02 19:20 ` [PATCH v6 0/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
[not found] ` <20220602192020.166940-1-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-02 19:20 ` [PATCH v6 1/3] blk-cgroup: Correctly free percpu iostat_cpu in blkg on error exit Waiman Long
2022-06-02 19:20 ` Waiman Long
[not found] ` <20220602192020.166940-2-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-04 2:08 ` Ming Lei
2022-06-04 2:08 ` Ming Lei
2022-06-04 2:47 ` Waiman Long
2022-06-02 19:20 ` [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Waiman Long
2022-06-02 19:20 ` Waiman Long
2022-06-02 20:39 ` Tejun Heo
[not found] ` <20220602192020.166940-3-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-04 2:16 ` Ming Lei
2022-06-04 2:16 ` Ming Lei
2022-06-02 19:20 ` [PATCH v6 3/3] blk-cgroup: Optimize blkcg_rstat_flush() Waiman Long
2022-06-04 3:58 ` Ming Lei
2022-06-05 23:15 ` Waiman Long
2022-06-06 1:39 ` Ming Lei
2022-06-06 1:59 ` Waiman Long
2022-06-06 1:59 ` Waiman Long
2022-06-06 2:23 ` Ming Lei
2022-06-06 2:58 ` Waiman Long
2022-06-06 2:58 ` Waiman Long
2022-06-06 3:15 ` Ming Lei
[not found] ` <20220602192020.166940-4-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-06-06 3:16 ` Ming Lei
2022-06-06 3:16 ` Ming Lei
2022-06-08 16:57 ` Michal Koutný
2022-06-08 16:57 ` Michal Koutný
2022-06-08 18:16 ` Waiman Long
2022-06-08 21:12 ` Michal Koutný
2022-06-08 22:14 ` Michal Koutný
2022-09-30 18:34 ` Waiman Long
2022-09-30 18:34 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602192020.166940-1-longman@redhat.com \
--to=longman-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.