Re: drivers/irqchip/irq-apple-aic.c:941 aic_of_ic_init() error: uninitialized symbol 'off'.

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: drivers/irqchip/irq-apple-aic.c:941 aic_of_ic_init() error: uninitialized symbol 'off'.
Date: Mon, 06 Jun 2022 14:25:02 +0300	[thread overview]
Message-ID: <20220606112502.GN2168@kadam> (raw)
In-Reply-To: <87zgiq3uux.wl-maz@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Mon, Jun 06, 2022 at 12:16:22PM +0100, Marc Zyngier wrote:
> > dc97fd6fec0099 Hector Martin 2022-03-10   926  	switch (irqc->info.version) {
> > dc97fd6fec0099 Hector Martin 2022-03-10   927  	case 1: {
> > dc97fd6fec0099 Hector Martin 2022-03-10   928  		u32 info;
> > dc97fd6fec0099 Hector Martin 2022-03-10   929  
> > 76cde26394114f Hector Martin 2021-01-21   930  		info = aic_ic_read(irqc, AIC_INFO);
> > 7c841f5f6fa3f9 Hector Martin 2022-03-10   931  		irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
> > dc97fd6fec0099 Hector Martin 2022-03-10   932  		irqc->max_irq = AIC_MAX_IRQ;
> > dc97fd6fec0099 Hector Martin 2022-03-10   933  
> > dc97fd6fec0099 Hector Martin 2022-03-10   934  		off = irqc->info.target_cpu;
> > dc97fd6fec0099 Hector Martin 2022-03-10   935  		off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
> > dc97fd6fec0099 Hector Martin 2022-03-10   936  
> > dc97fd6fec0099 Hector Martin 2022-03-10   937  		break;
> > 
> > "off" uninitialized if irqc->info.version != 1.
> 
> Which is pretty much impossible by construction, as as of this
> particular commit, all the possible implementations have version == 1.
> 
> Subsequent patches do add cases where version == 2, and that gets
> covered too.
> 
> So unless I'm missing something obvious, there is no bug here.

I assumed it was something like that.  The kbuild bot doesn't do cross
function analysis.  Neither does Clang really.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)

From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: drivers/irqchip/irq-apple-aic.c:941 aic_of_ic_init() error: uninitialized symbol 'off'.
Date: Mon, 06 Jun 2022 14:25:02 +0300	[thread overview]
Message-ID: <20220606112502.GN2168@kadam> (raw)
In-Reply-To: <87zgiq3uux.wl-maz@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

On Mon, Jun 06, 2022 at 12:16:22PM +0100, Marc Zyngier wrote:
> > dc97fd6fec0099 Hector Martin 2022-03-10   926  	switch (irqc->info.version) {
> > dc97fd6fec0099 Hector Martin 2022-03-10   927  	case 1: {
> > dc97fd6fec0099 Hector Martin 2022-03-10   928  		u32 info;
> > dc97fd6fec0099 Hector Martin 2022-03-10   929  
> > 76cde26394114f Hector Martin 2021-01-21   930  		info = aic_ic_read(irqc, AIC_INFO);
> > 7c841f5f6fa3f9 Hector Martin 2022-03-10   931  		irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
> > dc97fd6fec0099 Hector Martin 2022-03-10   932  		irqc->max_irq = AIC_MAX_IRQ;
> > dc97fd6fec0099 Hector Martin 2022-03-10   933  
> > dc97fd6fec0099 Hector Martin 2022-03-10   934  		off = irqc->info.target_cpu;
> > dc97fd6fec0099 Hector Martin 2022-03-10   935  		off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
> > dc97fd6fec0099 Hector Martin 2022-03-10   936  
> > dc97fd6fec0099 Hector Martin 2022-03-10   937  		break;
> > 
> > "off" uninitialized if irqc->info.version != 1.
> 
> Which is pretty much impossible by construction, as as of this
> particular commit, all the possible implementations have version == 1.
> 
> Subsequent patches do add cases where version == 2, and that gets
> covered too.
> 
> So unless I'm missing something obvious, there is no bug here.

I assumed it was something like that.  The kbuild bot doesn't do cross
function analysis.  Neither does Clang really.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kbuild@lists.01.org, Hector Martin <marcan@marcan.st>,
	lkp@intel.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org
Subject: Re: drivers/irqchip/irq-apple-aic.c:941 aic_of_ic_init() error: uninitialized symbol 'off'.
Date: Mon, 6 Jun 2022 14:25:02 +0300	[thread overview]
Message-ID: <20220606112502.GN2168@kadam> (raw)
In-Reply-To: <87zgiq3uux.wl-maz@kernel.org>

On Mon, Jun 06, 2022 at 12:16:22PM +0100, Marc Zyngier wrote:
> > dc97fd6fec0099 Hector Martin 2022-03-10   926  	switch (irqc->info.version) {
> > dc97fd6fec0099 Hector Martin 2022-03-10   927  	case 1: {
> > dc97fd6fec0099 Hector Martin 2022-03-10   928  		u32 info;
> > dc97fd6fec0099 Hector Martin 2022-03-10   929  
> > 76cde26394114f Hector Martin 2021-01-21   930  		info = aic_ic_read(irqc, AIC_INFO);
> > 7c841f5f6fa3f9 Hector Martin 2022-03-10   931  		irqc->nr_irq = FIELD_GET(AIC_INFO_NR_IRQ, info);
> > dc97fd6fec0099 Hector Martin 2022-03-10   932  		irqc->max_irq = AIC_MAX_IRQ;
> > dc97fd6fec0099 Hector Martin 2022-03-10   933  
> > dc97fd6fec0099 Hector Martin 2022-03-10   934  		off = irqc->info.target_cpu;
> > dc97fd6fec0099 Hector Martin 2022-03-10   935  		off += sizeof(u32) * irqc->max_irq; /* TARGET_CPU */
> > dc97fd6fec0099 Hector Martin 2022-03-10   936  
> > dc97fd6fec0099 Hector Martin 2022-03-10   937  		break;
> > 
> > "off" uninitialized if irqc->info.version != 1.
> 
> Which is pretty much impossible by construction, as as of this
> particular commit, all the possible implementations have version == 1.
> 
> Subsequent patches do add cases where version == 2, and that gets
> covered too.
> 
> So unless I'm missing something obvious, there is no bug here.

I assumed it was something like that.  The kbuild bot doesn't do cross
function analysis.  Neither does Clang really.

regards,
dan carpenter

next prev parent reply	other threads:[~2022-06-06 11:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 20:14 drivers/irqchip/irq-apple-aic.c:941 aic_of_ic_init() error: uninitialized symbol 'off' kernel test robot
2022-06-06 11:08 ` Dan Carpenter
2022-06-06 11:08 ` Dan Carpenter
2022-06-06 11:16 ` Marc Zyngier
2022-06-06 11:16   ` Marc Zyngier
2022-06-06 11:25   ` Dan Carpenter [this message]
2022-06-06 11:25     ` Dan Carpenter
2022-06-06 11:25     ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2022-06-04  2:29 kernel test robot
2023-12-03 16:51 kernel test robot
2023-12-04  6:41 Dan Carpenter
2023-12-04 10:32 ` Marc Zyngier
2023-12-07 20:43 kernel test robot
2023-12-08 21:56 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606112502.GN2168@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.