From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, will@kernel.org, marcan@marcan.st,
sven@svenpeter.dev, robin.murphy@arm.com, robdclark@gmail.com,
m.szyprowski@samsung.com, krzysztof.kozlowski@linaro.org,
agross@kernel.org, bjorn.andersson@linaro.org,
matthias.bgg@gmail.com, heiko@sntech.de, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
jean-philippe@linaro.org, alex.williamson@redhat.com,
suravee.suthikulpanit@amd.com, alyssa@rosenzweig.io,
alim.akhtar@samsung.com, dwmw2@infradead.org,
yong.wu@mediatek.com, mjrosato@linux.ibm.com,
gerald.schaefer@linux.ibm.com, thierry.reding@gmail.com,
vdumpa@nvidia.com, jonathanh@nvidia.com, cohuck@redhat.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine
Date: Tue, 7 Jun 2022 08:58:20 -0300 [thread overview]
Message-ID: <20220607115820.GH1343366@nvidia.com> (raw)
In-Reply-To: <d357966b-7abd-f8f3-3ca7-3c99f5e075b9@linux.intel.com>
On Tue, Jun 07, 2022 at 03:44:43PM +0800, Baolu Lu wrote:
> On 2022/6/6 14:19, Nicolin Chen wrote:
> > Worths mentioning the exact match for enforce_cache_coherency is removed
> > with this series, since there's very less value in doing that since KVM
> > won't be able to take advantage of it -- this just wastes domain memory.
> > Instead, we rely on Intel IOMMU driver taking care of that internally.
>
> After reading this series, I don't see that Intel IOMMU driver needs any
> further change to support the new scheme. Did I miss anything?
You already did it :)
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: linux-s390@vger.kernel.org, cohuck@redhat.com, heiko@sntech.de,
linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
alim.akhtar@samsung.com, will@kernel.org, alyssa@rosenzweig.io,
jean-philippe@linaro.org, linux-samsung-soc@vger.kernel.org,
kvm@vger.kernel.org, samuel@sholland.org, zhang.lyra@gmail.com,
jernej.skrabec@gmail.com, jonathanh@nvidia.com,
linux-rockchip@lists.infradead.org, wens@csie.org,
agross@kernel.org, linux-arm-kernel@lists.infradead.org,
orsonzhai@gmail.com, gerald.schaefer@linux.ibm.com,
linux-sunxi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
alex.williamson@redhat.com, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
virtualization@lists.linux-foundation.org, dwmw2@infradead.org,
marcan@marcan.st, linux-kernel@vger.kernel.org,
krzysztof.kozlowski@linaro.org, baolin.wang7@gmail.com,
robin.murphy@arm.com
Subject: Re: [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine
Date: Tue, 7 Jun 2022 08:58:20 -0300 [thread overview]
Message-ID: <20220607115820.GH1343366@nvidia.com> (raw)
In-Reply-To: <d357966b-7abd-f8f3-3ca7-3c99f5e075b9@linux.intel.com>
On Tue, Jun 07, 2022 at 03:44:43PM +0800, Baolu Lu wrote:
> On 2022/6/6 14:19, Nicolin Chen wrote:
> > Worths mentioning the exact match for enforce_cache_coherency is removed
> > with this series, since there's very less value in doing that since KVM
> > won't be able to take advantage of it -- this just wastes domain memory.
> > Instead, we rely on Intel IOMMU driver taking care of that internally.
>
> After reading this series, I don't see that Intel IOMMU driver needs any
> further change to support the new scheme. Did I miss anything?
You already did it :)
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, will@kernel.org, marcan@marcan.st,
sven@svenpeter.dev, robin.murphy@arm.com, robdclark@gmail.com,
m.szyprowski@samsung.com, krzysztof.kozlowski@linaro.org,
agross@kernel.org, bjorn.andersson@linaro.org,
matthias.bgg@gmail.com, heiko@sntech.de, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
jean-philippe@linaro.org, alex.williamson@redhat.com,
suravee.suthikulpanit@amd.com, alyssa@rosenzweig.io,
alim.akhtar@samsung.com, dwmw2@infradead.org,
yong.wu@mediatek.com, mjrosato@linux.ibm.com,
gerald.schaefer@linux.ibm.com, thierry.reding@gmail.com,
vdumpa@nvidia.com, jonathanh@nvidia.com, cohuck@redhat.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine
Date: Tue, 7 Jun 2022 08:58:20 -0300 [thread overview]
Message-ID: <20220607115820.GH1343366@nvidia.com> (raw)
In-Reply-To: <d357966b-7abd-f8f3-3ca7-3c99f5e075b9@linux.intel.com>
On Tue, Jun 07, 2022 at 03:44:43PM +0800, Baolu Lu wrote:
> On 2022/6/6 14:19, Nicolin Chen wrote:
> > Worths mentioning the exact match for enforce_cache_coherency is removed
> > with this series, since there's very less value in doing that since KVM
> > won't be able to take advantage of it -- this just wastes domain memory.
> > Instead, we rely on Intel IOMMU driver taking care of that internally.
>
> After reading this series, I don't see that Intel IOMMU driver needs any
> further change to support the new scheme. Did I miss anything?
You already did it :)
Jason
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
joro@8bytes.org, will@kernel.org, marcan@marcan.st,
sven@svenpeter.dev, robin.murphy@arm.com, robdclark@gmail.com,
m.szyprowski@samsung.com, krzysztof.kozlowski@linaro.org,
agross@kernel.org, bjorn.andersson@linaro.org,
matthias.bgg@gmail.com, heiko@sntech.de, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
jean-philippe@linaro.org, alex.williamson@redhat.com,
suravee.suthikulpanit@amd.com, alyssa@rosenzweig.io,
alim.akhtar@samsung.com, dwmw2@infradead.org,
yong.wu@mediatek.com, mjrosato@linux.ibm.com,
gerald.schaefer@linux.ibm.com, thierry.reding@gmail.com,
vdumpa@nvidia.com, jonathanh@nvidia.com, cohuck@redhat.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine
Date: Tue, 7 Jun 2022 08:58:20 -0300 [thread overview]
Message-ID: <20220607115820.GH1343366@nvidia.com> (raw)
In-Reply-To: <d357966b-7abd-f8f3-3ca7-3c99f5e075b9@linux.intel.com>
On Tue, Jun 07, 2022 at 03:44:43PM +0800, Baolu Lu wrote:
> On 2022/6/6 14:19, Nicolin Chen wrote:
> > Worths mentioning the exact match for enforce_cache_coherency is removed
> > with this series, since there's very less value in doing that since KVM
> > won't be able to take advantage of it -- this just wastes domain memory.
> > Instead, we rely on Intel IOMMU driver taking care of that internally.
>
> After reading this series, I don't see that Intel IOMMU driver needs any
> further change to support the new scheme. Did I miss anything?
You already did it :)
Jason
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: linux-s390@vger.kernel.org, cohuck@redhat.com, heiko@sntech.de,
mjrosato@linux.ibm.com, bjorn.andersson@linaro.org,
linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
alim.akhtar@samsung.com, will@kernel.org, alyssa@rosenzweig.io,
m.szyprowski@samsung.com, jean-philippe@linaro.org,
linux-samsung-soc@vger.kernel.org, kvm@vger.kernel.org,
samuel@sholland.org, zhang.lyra@gmail.com, joro@8bytes.org,
robdclark@gmail.com, jernej.skrabec@gmail.com,
jonathanh@nvidia.com, linux-rockchip@lists.infradead.org,
wens@csie.org, agross@kernel.org,
Nicolin Chen <nicolinc@nvidia.com>,
linux-arm-kernel@lists.infradead.org, orsonzhai@gmail.com,
gerald.schaefer@linux.ibm.com, linux-sunxi@lists.linux.dev,
sven@svenpeter.dev, linux-arm-msm@vger.kernel.org,
alex.williamson@redhat.com, iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
virtualization@lists.linux-foundation.org, yong.wu@mediatek.com,
dwmw2@infradead.org, marcan@marcan.st,
linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org,
suravee.suthikulpanit@amd.com, baolin.wang7@gmail.com,
robin.murphy@arm.com
Subject: Re: [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine
Date: Tue, 7 Jun 2022 08:58:20 -0300 [thread overview]
Message-ID: <20220607115820.GH1343366@nvidia.com> (raw)
In-Reply-To: <d357966b-7abd-f8f3-3ca7-3c99f5e075b9@linux.intel.com>
On Tue, Jun 07, 2022 at 03:44:43PM +0800, Baolu Lu wrote:
> On 2022/6/6 14:19, Nicolin Chen wrote:
> > Worths mentioning the exact match for enforce_cache_coherency is removed
> > with this series, since there's very less value in doing that since KVM
> > won't be able to take advantage of it -- this just wastes domain memory.
> > Instead, we rely on Intel IOMMU driver taking care of that internally.
>
> After reading this series, I don't see that Intel IOMMU driver needs any
> further change to support the new scheme. Did I miss anything?
You already did it :)
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-07 11:58 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 6:19 [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen via iommu
2022-06-06 6:19 ` [PATCH 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen via iommu
2022-06-07 3:23 ` Baolu Lu
2022-06-07 3:23 ` Baolu Lu
2022-06-07 3:23 ` Baolu Lu
2022-06-07 3:23 ` Baolu Lu
2022-06-07 3:23 ` Baolu Lu
2022-06-07 4:03 ` Nicolin Chen
2022-06-07 4:03 ` Nicolin Chen
2022-06-07 4:03 ` Nicolin Chen
2022-06-07 4:03 ` Nicolin Chen
2022-06-07 4:03 ` Nicolin Chen via iommu
2022-06-08 7:49 ` Tian, Kevin
2022-06-08 7:49 ` Tian, Kevin
2022-06-08 7:49 ` Tian, Kevin
2022-06-08 7:49 ` Tian, Kevin
2022-06-08 7:49 ` Tian, Kevin
2022-06-08 7:49 ` Tian, Kevin
2022-06-08 17:38 ` Nicolin Chen
2022-06-08 17:38 ` Nicolin Chen
2022-06-08 17:38 ` Nicolin Chen
2022-06-08 17:38 ` Nicolin Chen
2022-06-08 17:38 ` Nicolin Chen via iommu
2022-06-06 6:19 ` [PATCH 2/5] iommu: Ensure device has the same iommu_ops as the domain Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen via iommu
2022-06-06 14:33 ` Robin Murphy
2022-06-06 14:33 ` Robin Murphy
2022-06-06 14:33 ` Robin Murphy
2022-06-06 14:33 ` Robin Murphy
2022-06-06 14:33 ` Robin Murphy
2022-06-06 14:33 ` Robin Murphy
2022-06-06 16:51 ` Nicolin Chen
2022-06-06 16:51 ` Nicolin Chen
2022-06-06 16:51 ` Nicolin Chen
2022-06-06 16:51 ` Nicolin Chen
2022-06-06 16:51 ` Nicolin Chen via iommu
2022-06-06 17:50 ` Robin Murphy
2022-06-06 17:50 ` Robin Murphy
2022-06-06 17:50 ` Robin Murphy
2022-06-06 17:50 ` Robin Murphy
2022-06-06 17:50 ` Robin Murphy
2022-06-06 17:50 ` Robin Murphy
2022-06-06 18:28 ` Nicolin Chen
2022-06-06 18:28 ` Nicolin Chen
2022-06-06 18:28 ` Nicolin Chen
2022-06-06 18:28 ` Nicolin Chen
2022-06-06 18:28 ` Nicolin Chen via iommu
2022-06-06 18:52 ` Jason Gunthorpe
2022-06-06 18:52 ` Jason Gunthorpe
2022-06-06 18:52 ` Jason Gunthorpe
2022-06-06 18:52 ` Jason Gunthorpe
2022-06-06 18:52 ` Jason Gunthorpe via iommu
2022-06-06 6:19 ` [PATCH 3/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen via iommu
2022-06-08 8:28 ` Tian, Kevin
2022-06-08 8:28 ` Tian, Kevin
2022-06-08 8:28 ` Tian, Kevin
2022-06-08 8:28 ` Tian, Kevin
2022-06-08 8:28 ` Tian, Kevin
2022-06-08 8:28 ` Tian, Kevin
2022-06-08 11:17 ` Jason Gunthorpe
2022-06-08 11:17 ` Jason Gunthorpe
2022-06-08 11:17 ` Jason Gunthorpe
2022-06-08 11:17 ` Jason Gunthorpe
2022-06-08 11:17 ` Jason Gunthorpe via iommu
2022-06-08 23:48 ` Tian, Kevin
2022-06-08 23:48 ` Tian, Kevin
2022-06-08 23:48 ` Tian, Kevin
2022-06-08 23:48 ` Tian, Kevin
2022-06-08 23:48 ` Tian, Kevin
2022-06-08 23:48 ` Tian, Kevin
2022-06-14 20:45 ` Nicolin Chen
2022-06-14 20:45 ` Nicolin Chen
2022-06-14 20:45 ` Nicolin Chen
2022-06-14 20:45 ` Nicolin Chen
2022-06-14 20:45 ` Nicolin Chen via iommu
2022-06-15 7:35 ` Tian, Kevin
2022-06-15 7:35 ` Tian, Kevin
2022-06-15 7:35 ` Tian, Kevin
2022-06-15 7:35 ` Tian, Kevin
2022-06-15 7:35 ` Tian, Kevin
2022-06-15 7:35 ` Tian, Kevin
2022-06-15 23:12 ` Nicolin Chen
2022-06-15 23:12 ` Nicolin Chen
2022-06-15 23:12 ` Nicolin Chen
2022-06-15 23:12 ` Nicolin Chen via iommu
2022-06-06 6:19 ` [PATCH 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen via iommu
2022-06-08 8:35 ` Tian, Kevin
2022-06-08 8:35 ` Tian, Kevin
2022-06-08 8:35 ` Tian, Kevin
2022-06-08 8:35 ` Tian, Kevin
2022-06-08 8:35 ` Tian, Kevin
2022-06-08 8:35 ` Tian, Kevin
2022-06-08 17:46 ` Nicolin Chen
2022-06-08 17:46 ` Nicolin Chen
2022-06-08 17:46 ` Nicolin Chen
2022-06-08 17:46 ` Nicolin Chen
2022-06-08 17:46 ` Nicolin Chen via iommu
2022-06-06 6:19 ` [PATCH 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen
2022-06-06 6:19 ` Nicolin Chen via iommu
2022-06-07 7:44 ` [PATCH 0/5] Simplify vfio_iommu_type1 attach/detach routine Baolu Lu
2022-06-07 7:44 ` Baolu Lu
2022-06-07 7:44 ` Baolu Lu
2022-06-07 7:44 ` Baolu Lu
2022-06-07 7:44 ` Baolu Lu
2022-06-07 11:58 ` Jason Gunthorpe [this message]
2022-06-07 11:58 ` Jason Gunthorpe
2022-06-07 11:58 ` Jason Gunthorpe
2022-06-07 11:58 ` Jason Gunthorpe
2022-06-07 11:58 ` Jason Gunthorpe via iommu
2022-06-07 12:42 ` Baolu Lu
2022-06-07 12:42 ` Baolu Lu
2022-06-07 12:42 ` Baolu Lu
2022-06-07 12:42 ` Baolu Lu
2022-06-07 12:42 ` Baolu Lu
-- strict thread matches above, loose matches on Subject: below --
2022-06-10 16:39 [PATCH 5/5] vfio/iommu_type1: Simplify group attachment kernel test robot
2022-06-13 13:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607115820.GH1343366@nvidia.com \
--to=jgg@nvidia.com \
--cc=agross@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=samuel@sholland.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wens@csie.org \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.