* [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device
@ 2022-06-08 11:51 Ramesh Errabolu
2022-06-08 19:40 ` Felix Kuehling
0 siblings, 1 reply; 4+ messages in thread
From: Ramesh Errabolu @ 2022-06-08 11:51 UTC (permalink / raw)
To: amd-gfx; +Cc: Ramesh Errabolu
The field is redundant and does not serve any functional role
Signed-off-by: Ramesh Errabolu <Ramesh.Errabolu@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index cbfb32b3d235..a5409531a2fd 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -1040,7 +1040,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
props->rec_transfer_size =
iolink->recommended_transfer_size;
- dev->io_link_count++;
dev->node_props.io_links_count++;
list_add_tail(&props->list, &dev->io_link_props);
break;
@@ -1067,7 +1066,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
props2->node_from = id_to;
props2->node_to = id_from;
props2->kobj = NULL;
- to_dev->io_link_count++;
to_dev->node_props.io_links_count++;
list_add_tail(&props2->list, &to_dev->io_link_props);
}
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 3e240b22ec91..304322ac39e6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1819,7 +1819,6 @@ static void kfd_topology_update_io_links(int proximity_domain)
*/
if (iolink->node_to == proximity_domain) {
list_del(&iolink->list);
- dev->io_link_count--;
dev->node_props.io_links_count--;
} else {
if (iolink->node_from > proximity_domain)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
index 2fb5664e1041..9f6c949186c1 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
@@ -130,7 +130,6 @@ struct kfd_topology_device {
struct list_head mem_props;
uint32_t cache_count;
struct list_head cache_props;
- uint32_t io_link_count;
struct list_head io_link_props;
struct list_head p2p_link_props;
struct list_head perf_props;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device
2022-06-08 11:51 [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device Ramesh Errabolu
@ 2022-06-08 19:40 ` Felix Kuehling
0 siblings, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2022-06-08 19:40 UTC (permalink / raw)
To: Ramesh Errabolu, amd-gfx
On 2022-06-08 07:51, Ramesh Errabolu wrote:
> The field is redundant and does not serve any functional role
>
> Signed-off-by: Ramesh Errabolu <Ramesh.Errabolu@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
> drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
> 3 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index cbfb32b3d235..a5409531a2fd 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1040,7 +1040,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
> props->rec_transfer_size =
> iolink->recommended_transfer_size;
>
> - dev->io_link_count++;
> dev->node_props.io_links_count++;
> list_add_tail(&props->list, &dev->io_link_props);
> break;
> @@ -1067,7 +1066,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
> props2->node_from = id_to;
> props2->node_to = id_from;
> props2->kobj = NULL;
> - to_dev->io_link_count++;
> to_dev->node_props.io_links_count++;
> list_add_tail(&props2->list, &to_dev->io_link_props);
> }
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index 3e240b22ec91..304322ac39e6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -1819,7 +1819,6 @@ static void kfd_topology_update_io_links(int proximity_domain)
> */
> if (iolink->node_to == proximity_domain) {
> list_del(&iolink->list);
> - dev->io_link_count--;
> dev->node_props.io_links_count--;
> } else {
> if (iolink->node_from > proximity_domain)
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> index 2fb5664e1041..9f6c949186c1 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
> @@ -130,7 +130,6 @@ struct kfd_topology_device {
> struct list_head mem_props;
> uint32_t cache_count;
> struct list_head cache_props;
> - uint32_t io_link_count;
> struct list_head io_link_props;
> struct list_head p2p_link_props;
> struct list_head perf_props;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device
@ 2022-06-08 11:37 Ramesh Errabolu
2022-06-08 11:41 ` Errabolu, Ramesh
0 siblings, 1 reply; 4+ messages in thread
From: Ramesh Errabolu @ 2022-06-08 11:37 UTC (permalink / raw)
To: amd-gfx; +Cc: Ramesh Errabolu
The field is redundant and does not serve any functional role
Signed-off-by: Ramesh Errabolu <Ramesh.Errabolu@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index cbfb32b3d235..a5409531a2fd 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -1040,7 +1040,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
props->rec_transfer_size =
iolink->recommended_transfer_size;
- dev->io_link_count++;
dev->node_props.io_links_count++;
list_add_tail(&props->list, &dev->io_link_props);
break;
@@ -1067,7 +1066,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
props2->node_from = id_to;
props2->node_to = id_from;
props2->kobj = NULL;
- to_dev->io_link_count++;
to_dev->node_props.io_links_count++;
list_add_tail(&props2->list, &to_dev->io_link_props);
}
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 3e240b22ec91..304322ac39e6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1819,7 +1819,6 @@ static void kfd_topology_update_io_links(int proximity_domain)
*/
if (iolink->node_to == proximity_domain) {
list_del(&iolink->list);
- dev->io_link_count--;
dev->node_props.io_links_count--;
} else {
if (iolink->node_from > proximity_domain)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
index 2fb5664e1041..9f6c949186c1 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
@@ -130,7 +130,6 @@ struct kfd_topology_device {
struct list_head mem_props;
uint32_t cache_count;
struct list_head cache_props;
- uint32_t io_link_count;
struct list_head io_link_props;
struct list_head p2p_link_props;
struct list_head perf_props;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device
2022-06-08 11:37 Ramesh Errabolu
@ 2022-06-08 11:41 ` Errabolu, Ramesh
0 siblings, 0 replies; 4+ messages in thread
From: Errabolu, Ramesh @ 2022-06-08 11:41 UTC (permalink / raw)
To: amd-gfx@lists.freedesktop.org
[AMD Official Use Only - General]
Ignore the patch sent a bit early.
Regards,
Ramesh
-----Original Message-----
From: Errabolu, Ramesh <Ramesh.Errabolu@amd.com>
Sent: Wednesday, June 8, 2022 5:07 PM
To: amd-gfx@lists.freedesktop.org
Cc: Errabolu, Ramesh <Ramesh.Errabolu@amd.com>
Subject: [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device
The field is redundant and does not serve any functional role
Signed-off-by: Ramesh Errabolu <Ramesh.Errabolu@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 --
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 - drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index cbfb32b3d235..a5409531a2fd 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -1040,7 +1040,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
props->rec_transfer_size =
iolink->recommended_transfer_size;
- dev->io_link_count++;
dev->node_props.io_links_count++;
list_add_tail(&props->list, &dev->io_link_props);
break;
@@ -1067,7 +1066,6 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
props2->node_from = id_to;
props2->node_to = id_from;
props2->kobj = NULL;
- to_dev->io_link_count++;
to_dev->node_props.io_links_count++;
list_add_tail(&props2->list, &to_dev->io_link_props);
}
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 3e240b22ec91..304322ac39e6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1819,7 +1819,6 @@ static void kfd_topology_update_io_links(int proximity_domain)
*/
if (iolink->node_to == proximity_domain) {
list_del(&iolink->list);
- dev->io_link_count--;
dev->node_props.io_links_count--;
} else {
if (iolink->node_from > proximity_domain) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
index 2fb5664e1041..9f6c949186c1 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
@@ -130,7 +130,6 @@ struct kfd_topology_device {
struct list_head mem_props;
uint32_t cache_count;
struct list_head cache_props;
- uint32_t io_link_count;
struct list_head io_link_props;
struct list_head p2p_link_props;
struct list_head perf_props;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-08 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-08 11:51 [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device Ramesh Errabolu
2022-06-08 19:40 ` Felix Kuehling
-- strict thread matches above, loose matches on Subject: below --
2022-06-08 11:37 Ramesh Errabolu
2022-06-08 11:41 ` Errabolu, Ramesh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.