All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle
Date: Thu, 9 Jun 2022 14:35:40 -0600	[thread overview]
Message-ID: <20220609203540.GA43168-robh@kernel.org> (raw)
In-Reply-To: <20220607163703.26355-3-potin.lai.pt@gmail.com>

On Wed, Jun 08, 2022 at 12:37:03AM +0800, Potin Lai wrote:
> Introduce a new property for setting a minimum duty cycle for clock high.
> 
> * i2c-clk-duty-cycle-min: a minimum percentage of clock high
> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index ea643e6c3ef5..af4c49111cc0 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,14 @@ properties:
>      description:
>        states that there is another master active on this bus
>  
> +  i2c-clk-duty-cycle-min:

i2c-clk-duty-cycle-high-min-percent

Or maybe 'i2c-clk-high-min-percent' with duty cycle being implied.

> +    $ref: /schemas/types.yaml#/definitions/uint32

With '-percent' you can drop this.

> +    minimum: 1
> +    maximum: 100
> +    default: 50
> +    description:
> +      a minimum percentage of clock high
> +
>  required:
>    - reg
>    - compatible
> -- 
> 2.17.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Rayn Chen <rayn_chen@aspeedtech.com>,
	Patrick Williams <patrick@stwcx.xyz>,
	Potin Lai <potin.lai@quantatw.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle
Date: Thu, 9 Jun 2022 14:35:40 -0600	[thread overview]
Message-ID: <20220609203540.GA43168-robh@kernel.org> (raw)
In-Reply-To: <20220607163703.26355-3-potin.lai.pt@gmail.com>

On Wed, Jun 08, 2022 at 12:37:03AM +0800, Potin Lai wrote:
> Introduce a new property for setting a minimum duty cycle for clock high.
> 
> * i2c-clk-duty-cycle-min: a minimum percentage of clock high
> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index ea643e6c3ef5..af4c49111cc0 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,14 @@ properties:
>      description:
>        states that there is another master active on this bus
>  
> +  i2c-clk-duty-cycle-min:

i2c-clk-duty-cycle-high-min-percent

Or maybe 'i2c-clk-high-min-percent' with duty cycle being implied.

> +    $ref: /schemas/types.yaml#/definitions/uint32

With '-percent' you can drop this.

> +    minimum: 1
> +    maximum: 100
> +    default: 50
> +    description:
> +      a minimum percentage of clock high
> +
>  required:
>    - reg
>    - compatible
> -- 
> 2.17.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Rayn Chen <rayn_chen@aspeedtech.com>,
	Patrick Williams <patrick@stwcx.xyz>,
	Potin Lai <potin.lai@quantatw.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle
Date: Thu, 9 Jun 2022 14:35:40 -0600	[thread overview]
Message-ID: <20220609203540.GA43168-robh@kernel.org> (raw)
In-Reply-To: <20220607163703.26355-3-potin.lai.pt@gmail.com>

On Wed, Jun 08, 2022 at 12:37:03AM +0800, Potin Lai wrote:
> Introduce a new property for setting a minimum duty cycle for clock high.
> 
> * i2c-clk-duty-cycle-min: a minimum percentage of clock high
> 
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
>  Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index ea643e6c3ef5..af4c49111cc0 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,14 @@ properties:
>      description:
>        states that there is another master active on this bus
>  
> +  i2c-clk-duty-cycle-min:

i2c-clk-duty-cycle-high-min-percent

Or maybe 'i2c-clk-high-min-percent' with duty cycle being implied.

> +    $ref: /schemas/types.yaml#/definitions/uint32

With '-percent' you can drop this.

> +    minimum: 1
> +    maximum: 100
> +    default: 50
> +    description:
> +      a minimum percentage of clock high
> +
>  required:
>    - reg
>    - compatible
> -- 
> 2.17.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-09 20:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 16:37 [PATCH v3 0/2] Add i2c clock duty cycle property for setting minimum persentage of clock high Potin Lai
2022-06-07 16:37 ` Potin Lai
2022-06-07 16:37 ` Potin Lai
2022-06-07 16:37 ` [PATCH v3 1/2] aspeed: i2c: add clock duty cycle property Potin Lai
2022-06-07 16:37   ` Potin Lai
2022-06-07 16:37   ` Potin Lai
2022-06-07 16:37 ` [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle Potin Lai
2022-06-07 16:37   ` Potin Lai
2022-06-07 16:37   ` Potin Lai
2022-06-09 20:35   ` Rob Herring [this message]
2022-06-09 20:35     ` Rob Herring
2022-06-09 20:35     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609203540.GA43168-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.