From: Jakub Kicinski <kuba@kernel.org>
To: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Samuel Mendoza-Jonas <sam@mendozajonas.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 0/6] Configurable VLAN mode for NCSI driver
Date: Fri, 10 Jun 2022 13:09:03 -0700 [thread overview]
Message-ID: <20220610130903.0386c0d9@kernel.org> (raw)
In-Reply-To: <20220610165940.2326777-1-jiaqing.zhao@linux.intel.com>
On Sat, 11 Jun 2022 00:59:34 +0800 Jiaqing Zhao wrote:
> Currently kernel NCSI driver only supports the "VLAN + non-VLAN" mode
> (Mode #2), but this mode is an optional mode [1] defined in NCSI spec
> and some NCSI devices like Intel E810 Network Adapter [2] does not
> support that mode. This patchset adds a new "ncsi,vlan-mode" device
> tree property for configuring the VLAN mode of NCSI device.
>
> [1] Table 58 - VLAN Enable Modes
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.0.0.pdf
> [2] 12.6.5.4.3 VLAN
> https://cdrdv2.intel.com/v1/dl/getContent/613875
Please don't post the same patches more than once a day. You posted the
same patches 3 times within 15 minutes with no major difference :/
Why is "ncsi,vlan-mode" set via the device tree? Looks like something
that can be configured at runtime.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Cc: Samuel Mendoza-Jonas <sam@mendozajonas.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 0/6] Configurable VLAN mode for NCSI driver
Date: Fri, 10 Jun 2022 13:09:03 -0700 [thread overview]
Message-ID: <20220610130903.0386c0d9@kernel.org> (raw)
In-Reply-To: <20220610165940.2326777-1-jiaqing.zhao@linux.intel.com>
On Sat, 11 Jun 2022 00:59:34 +0800 Jiaqing Zhao wrote:
> Currently kernel NCSI driver only supports the "VLAN + non-VLAN" mode
> (Mode #2), but this mode is an optional mode [1] defined in NCSI spec
> and some NCSI devices like Intel E810 Network Adapter [2] does not
> support that mode. This patchset adds a new "ncsi,vlan-mode" device
> tree property for configuring the VLAN mode of NCSI device.
>
> [1] Table 58 - VLAN Enable Modes
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.0.0.pdf
> [2] 12.6.5.4.3 VLAN
> https://cdrdv2.intel.com/v1/dl/getContent/613875
Please don't post the same patches more than once a day. You posted the
same patches 3 times within 15 minutes with no major difference :/
Why is "ncsi,vlan-mode" set via the device tree? Looks like something
that can be configured at runtime.
next prev parent reply other threads:[~2022-06-10 20:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 16:59 [PATCH v2 0/6] Configurable VLAN mode for NCSI driver Jiaqing Zhao
2022-06-10 16:59 ` [PATCH v2 1/6] net/ncsi: Fix value of NCSI_CAP_VLAN_ANY Jiaqing Zhao
2022-06-10 16:59 ` [PATCH v2 2/6] net/ncsi: Rename NCSI_CAP_VLAN_NO to NCSI_CAP_VLAN_FILTERED Jiaqing Zhao
2022-06-10 16:59 ` [PATCH v2 3/6] net/ncsi: Enable VLAN filtering when callback is registered Jiaqing Zhao
2022-06-10 16:59 ` [PATCH v2 4/6] ftgmac100: Remove enable NCSI VLAN filtering Jiaqing Zhao
2022-06-10 16:59 ` [PATCH v2 5/6] dt-bindings: net: Add NCSI bindings Jiaqing Zhao
2022-06-10 23:19 ` Rob Herring
2022-06-10 23:19 ` Rob Herring
2022-06-11 3:09 ` Jiaqing Zhao
2022-06-11 3:09 ` Jiaqing Zhao
2022-06-13 15:28 ` Rob Herring
2022-06-13 15:28 ` Rob Herring
2022-06-14 2:33 ` Jiaqing Zhao
2022-06-14 2:33 ` Jiaqing Zhao
2022-06-10 16:59 ` [PATCH v2 6/6] net/ncsi: Support VLAN mode configuration Jiaqing Zhao
2022-06-10 20:09 ` Jakub Kicinski [this message]
2022-06-10 20:09 ` [PATCH v2 0/6] Configurable VLAN mode for NCSI driver Jakub Kicinski
2022-06-11 3:25 ` Jiaqing Zhao
2022-06-11 3:25 ` Jiaqing Zhao
2022-06-11 4:45 ` Jakub Kicinski
2022-06-11 4:45 ` Jakub Kicinski
2022-06-11 5:18 ` Jiaqing Zhao
2022-06-11 5:18 ` Jiaqing Zhao
2022-06-11 5:44 ` Jakub Kicinski
2022-06-11 5:44 ` Jakub Kicinski
2022-06-11 9:58 ` Jiaqing Zhao
2022-06-11 9:58 ` Jiaqing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220610130903.0386c0d9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jiaqing.zhao@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.