* [PATCH] block: update comment for blkcg_init_queue
@ 2022-06-14 10:05 ` Guoqing Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Guoqing Jiang @ 2022-06-14 10:05 UTC (permalink / raw)
To: tj-DgEjT+Ai2ygdnm+yROfE0A, axboe-tSWWG44O7X1aa/9Udqfwiw
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-block-u79uwXL29TY76Z2rM5mHXA
It was called from __alloc_disk_node since commit 1059699f87eb ("block:
move blkcg initialization/destroy into disk allocation/release handler).
Let's change the comment accordingly.
Signed-off-by: Guoqing Jiang <guoqing.jiang-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 764e740b0c0f..48ea9919e3ce 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1256,7 +1256,7 @@ static int blkcg_css_online(struct cgroup_subsys_state *css)
* blkcg_init_queue - initialize blkcg part of request queue
* @q: request_queue to initialize
*
- * Called from blk_alloc_queue(). Responsible for initializing blkcg
+ * Called from __alloc_disk_node(). Responsible for initializing blkcg
* part of new request_queue @q.
*
* RETURNS:
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] block: update comment for blkcg_init_queue
@ 2022-06-14 10:05 ` Guoqing Jiang
0 siblings, 0 replies; 5+ messages in thread
From: Guoqing Jiang @ 2022-06-14 10:05 UTC (permalink / raw)
To: tj, axboe; +Cc: cgroups, linux-block
It was called from __alloc_disk_node since commit 1059699f87eb ("block:
move blkcg initialization/destroy into disk allocation/release handler).
Let's change the comment accordingly.
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 764e740b0c0f..48ea9919e3ce 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1256,7 +1256,7 @@ static int blkcg_css_online(struct cgroup_subsys_state *css)
* blkcg_init_queue - initialize blkcg part of request queue
* @q: request_queue to initialize
*
- * Called from blk_alloc_queue(). Responsible for initializing blkcg
+ * Called from __alloc_disk_node(). Responsible for initializing blkcg
* part of new request_queue @q.
*
* RETURNS:
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <20220614100556.20899-1-guoqing.jiang-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>]
* Re: [PATCH] block: update comment for blkcg_init_queue
2022-06-14 10:05 ` Guoqing Jiang
@ 2022-06-15 6:18 ` Christoph Hellwig
-1 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2022-06-15 6:18 UTC (permalink / raw)
To: Guoqing Jiang
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A, axboe-tSWWG44O7X1aa/9Udqfwiw,
cgroups-u79uwXL29TY76Z2rM5mHXA,
linux-block-u79uwXL29TY76Z2rM5mHXA
On Tue, Jun 14, 2022 at 06:05:56PM +0800, Guoqing Jiang wrote:
> It was called from __alloc_disk_node since commit 1059699f87eb ("block:
> move blkcg initialization/destroy into disk allocation/release handler).
> Let's change the comment accordingly.
Well, the right things is to simply drop this comment. I do have
a large series toucing it and removing it, so maybe we can wait
until that?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] block: update comment for blkcg_init_queue
@ 2022-06-15 6:18 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2022-06-15 6:18 UTC (permalink / raw)
To: Guoqing Jiang; +Cc: tj, axboe, cgroups, linux-block
On Tue, Jun 14, 2022 at 06:05:56PM +0800, Guoqing Jiang wrote:
> It was called from __alloc_disk_node since commit 1059699f87eb ("block:
> move blkcg initialization/destroy into disk allocation/release handler).
> Let's change the comment accordingly.
Well, the right things is to simply drop this comment. I do have
a large series toucing it and removing it, so maybe we can wait
until that?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] block: update comment for blkcg_init_queue
2022-06-15 6:18 ` Christoph Hellwig
(?)
@ 2022-06-15 6:21 ` Guoqing Jiang
-1 siblings, 0 replies; 5+ messages in thread
From: Guoqing Jiang @ 2022-06-15 6:21 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: tj, axboe, cgroups, linux-block
On 6/15/22 2:18 PM, Christoph Hellwig wrote:
> On Tue, Jun 14, 2022 at 06:05:56PM +0800, Guoqing Jiang wrote:
>> It was called from __alloc_disk_node since commit 1059699f87eb ("block:
>> move blkcg initialization/destroy into disk allocation/release handler).
>> Let's change the comment accordingly.
> Well, the right things is to simply drop this comment. I do have
> a large series toucing it and removing it, so maybe we can wait
> until that?
Sure, I am fine with it.
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-15 6:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14 10:05 [PATCH] block: update comment for blkcg_init_queue Guoqing Jiang
2022-06-14 10:05 ` Guoqing Jiang
[not found] ` <20220614100556.20899-1-guoqing.jiang-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
2022-06-15 6:18 ` Christoph Hellwig
2022-06-15 6:18 ` Christoph Hellwig
2022-06-15 6:21 ` Guoqing Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.