From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: pmenzel@molgen.mpg.de, lianglixue@greatwall.com.cn,
netdev@vger.kernel.org, Lixue Liang <lianglixuehao@126.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH v6] igb: Assign random MAC address instead of fail in case of invalid one
Date: Tue, 14 Jun 2022 18:19:14 -0700 [thread overview]
Message-ID: <20220614181914.4cd8fe97@kernel.org> (raw)
In-Reply-To: <cbfb5d1a-dadd-efe5-b5d9-de9f483e44b2@intel.com>
On Tue, 14 Jun 2022 12:09:02 -0700 Tony Nguyen wrote:
> > Add the module parameter "allow_invalid_mac_address" to control the
>
> netdev maintainers:
>
> I know the use of module parameters is extremely frowned upon. Is this a
> use/exception that would be allowed?
I think so, I don't see a different way here.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Lixue Liang <lianglixuehao@126.com>, <pmenzel@molgen.mpg.de>,
<intel-wired-lan@lists.osuosl.org>, <jesse.brandeburg@intel.com>,
<lianglixue@greatwall.com.cn>, <netdev@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6] igb: Assign random MAC address instead of fail in case of invalid one
Date: Tue, 14 Jun 2022 18:19:14 -0700 [thread overview]
Message-ID: <20220614181914.4cd8fe97@kernel.org> (raw)
In-Reply-To: <cbfb5d1a-dadd-efe5-b5d9-de9f483e44b2@intel.com>
On Tue, 14 Jun 2022 12:09:02 -0700 Tony Nguyen wrote:
> > Add the module parameter "allow_invalid_mac_address" to control the
>
> netdev maintainers:
>
> I know the use of module parameters is extremely frowned upon. Is this a
> use/exception that would be allowed?
I think so, I don't see a different way here.
next prev parent reply other threads:[~2022-06-15 1:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 2:39 [Intel-wired-lan] [PATCH v6] igb: Assign random MAC address instead of fail in case of invalid one Lixue Liang
2022-06-10 2:39 ` Lixue Liang
2022-06-14 19:09 ` [Intel-wired-lan] " Tony Nguyen
2022-06-14 19:09 ` Tony Nguyen
2022-06-15 1:19 ` Jakub Kicinski [this message]
2022-06-15 1:19 ` Jakub Kicinski
2022-06-15 2:11 ` [Intel-wired-lan] " 梁礼学
2022-06-15 2:11 ` 梁礼学
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614181914.4cd8fe97@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=lianglixue@greatwall.com.cn \
--cc=lianglixuehao@126.com \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.