From: Rob Herring <robh@kernel.org>
To: Conor Dooley <mail@conchuod.ie>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH] dt-bindings: display: delete ilitek,ili9341.txt
Date: Fri, 17 Jun 2022 17:25:28 -0600 [thread overview]
Message-ID: <20220617232528.GA2628998-robh@kernel.org> (raw)
In-Reply-To: <20220617213706.376730-1-mail@conchuod.ie>
On Fri, Jun 17, 2022 at 10:37:07PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> ilitek,ili9341.txt was replaced by ilitek,ili9341.yaml but the txt
panel/ilitek,ili9341.yaml
> binding was not deleted. Do so.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../bindings/display/ilitek,ili9341.txt | 27 -------------------
> 1 file changed, 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt
>
> diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/ilitek,ili9341.txt
> deleted file mode 100644
> index 169b32e4ee4e..000000000000
> --- a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -Ilitek ILI9341 display panels
> -
> -This binding is for display panels using an Ilitek ILI9341 controller in SPI
> -mode.
> -
> -Required properties:
> -- compatible: "adafruit,yx240qv29", "ilitek,ili9341"
"adafruit,yx240qv29" is not in the schema.
> -- dc-gpios: D/C pin
> -- reset-gpios: Reset pin
Neither is this. It is in panel-common.yaml, but 'unevaluatedProperties'
needs to be used instead to allow it. Or add 'reset-gpios: true'.
> -
> -The node for this driver must be a child node of a SPI controller, hence
> -all mandatory properties described in ../spi/spi-bus.txt must be specified.
> -
> -Optional properties:
> -- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> - display@0{
> - compatible = "adafruit,yx240qv29", "ilitek,ili9341";
> - reg = <0>;
> - spi-max-frequency = <32000000>;
> - dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
> - reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>;
> - rotation = <270>;
> - backlight = <&backlight>;
> - };
> --
> 2.36.1
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <mail@conchuod.ie>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH] dt-bindings: display: delete ilitek,ili9341.txt
Date: Fri, 17 Jun 2022 17:25:28 -0600 [thread overview]
Message-ID: <20220617232528.GA2628998-robh@kernel.org> (raw)
In-Reply-To: <20220617213706.376730-1-mail@conchuod.ie>
On Fri, Jun 17, 2022 at 10:37:07PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> ilitek,ili9341.txt was replaced by ilitek,ili9341.yaml but the txt
panel/ilitek,ili9341.yaml
> binding was not deleted. Do so.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../bindings/display/ilitek,ili9341.txt | 27 -------------------
> 1 file changed, 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt
>
> diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/ilitek,ili9341.txt
> deleted file mode 100644
> index 169b32e4ee4e..000000000000
> --- a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -Ilitek ILI9341 display panels
> -
> -This binding is for display panels using an Ilitek ILI9341 controller in SPI
> -mode.
> -
> -Required properties:
> -- compatible: "adafruit,yx240qv29", "ilitek,ili9341"
"adafruit,yx240qv29" is not in the schema.
> -- dc-gpios: D/C pin
> -- reset-gpios: Reset pin
Neither is this. It is in panel-common.yaml, but 'unevaluatedProperties'
needs to be used instead to allow it. Or add 'reset-gpios: true'.
> -
> -The node for this driver must be a child node of a SPI controller, hence
> -all mandatory properties described in ../spi/spi-bus.txt must be specified.
> -
> -Optional properties:
> -- rotation: panel rotation in degrees counter clockwise (0,90,180,270)
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> - display@0{
> - compatible = "adafruit,yx240qv29", "ilitek,ili9341";
> - reg = <0>;
> - spi-max-frequency = <32000000>;
> - dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>;
> - reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>;
> - rotation = <270>;
> - backlight = <&backlight>;
> - };
> --
> 2.36.1
>
>
next prev parent reply other threads:[~2022-06-17 23:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 21:37 [PATCH] dt-bindings: display: delete ilitek,ili9341.txt Conor Dooley
2022-06-17 23:25 ` Rob Herring [this message]
2022-06-17 23:25 ` Rob Herring
2022-06-17 23:29 ` Conor.Dooley
2022-06-17 23:29 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617232528.GA2628998-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=conor.dooley@microchip.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@conchuod.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.