From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
Jakub Kicinski <kuba@kernel.org>,
kernel test robot <lkp@intel.com>,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
boon.leong.ong@intel.com, rmk+kernel@armlinux.org.uk
Subject: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig
Date: Mon, 20 Jun 2022 13:19:15 -0700 [thread overview]
Message-ID: <20220620201915.1195280-1-kuba@kernel.org> (raw)
Various builds bots are upset about lack of PHYLINK:
>> ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined!
>> ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined!
Link: https://lore.kernel.org/all/202206182016.Go0zVi4t-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: andrew@lunn.ch
CC: hkallweit1@gmail.com
CC: linux@armlinux.org.uk
CC: boon.leong.ong@intel.com
CC: rmk+kernel@armlinux.org.uk
---
drivers/net/pcs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig
index 22ba7b0b476d..c3e52fa6ca06 100644
--- a/drivers/net/pcs/Kconfig
+++ b/drivers/net/pcs/Kconfig
@@ -8,6 +8,7 @@ menu "PCS device drivers"
config PCS_XPCS
tristate "Synopsys DesignWare XPCS controller"
depends on MDIO_DEVICE && MDIO_BUS
+ select PHYLINK
help
This module provides helper functions for Synopsys DesignWare XPCS
controllers.
--
2.36.1
next reply other threads:[~2022-06-20 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 20:19 Jakub Kicinski [this message]
2022-06-20 21:49 ` [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig kernel test robot
2022-06-21 0:48 ` Jakub Kicinski
2022-06-21 0:48 ` Jakub Kicinski
2022-06-21 7:08 ` Russell King
2022-06-21 7:08 ` Russell King (Oracle)
2022-06-20 22:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220620201915.1195280-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.