Re: [PATCH net-next] net: pcs: xpcs: select PHYLINK in Kconfig

[Jakub Kicinski <kuba@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]

On Tue, 21 Jun 2022 05:49:57 +0800 kernel test robot wrote:
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on net-next/master]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Jakub-Kicinski/net-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git dbca1596bbb08318f5e3b3b99f8ca0a0d3830a65
> config: i386-tinyconfig
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-lkp/linux/commit/a3120516f7ee66896bb0d3c90fe653ce0cb3a09f
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Jakub-Kicinski/net-pcs-xpcs-select-PHYLINK-in-Kconfig/20220621-042123
>         git checkout a3120516f7ee66896bb0d3c90fe653ce0cb3a09f
>         make W=1 ARCH=i386  tinyconfig
>         make W=1 ARCH=i386 
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/net/phy/Kconfig:16:error: recursive dependency detected!  
>    drivers/net/phy/Kconfig:16: symbol PHYLIB is selected by PHYLINK
>    drivers/net/phy/Kconfig:6: symbol PHYLINK is selected by PCS_XPCS
>    drivers/net/pcs/Kconfig:8: symbol PCS_XPCS depends on MDIO_DEVICE
>    drivers/net/mdio/Kconfig:6: symbol MDIO_DEVICE is selected by PHYLIB
>    For a resolution refer to Documentation/kbuild/kconfig-language.rst
>    subsection "Kconfig recursive dependency limitations"

Dunno what the best practice is in that case :S
I'll leave this to the experts.