[xilinx-xlnx:xlnx_rebase_v5.15_LTS 861/1181] drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.

[xilinx-xlnx:xlnx_rebase_v5.15_LTS 861/1181] drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
CC: Tejas Prajapati Rameshchandra <tejaspra@xilinx.com>
CC: Naga Sureshkumar Relli <nagasure@xilinx.com>
CC: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
CC: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head:   59523b5c4aca0174f1f8cba2a07d3b3328b7c80e
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/1181] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago
config: i386-randconfig-c001 (https://download.01.org/0day-ci/archive/20220621/202206210106.TM0vtap0-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.
>> drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 703.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

[PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2372 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
CC: Tejas Prajapati Rameshchandra <tejaspra@xilinx.com>
CC: Naga Sureshkumar Relli <nagasure@xilinx.com>
CC: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
CC: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
CC: Mark Brown <broonie@kernel.org>
CC: linux-spi(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.
drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 703.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 3973536c4560 ("spi: spi-xilinx: Updated axi-qspi controller driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head:   59523b5c4aca0174f1f8cba2a07d3b3328b7c80e
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/1181] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/spi/spi-xilinx.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -693,13 +693,16 @@ static int xilinx_spi_probe(struct platf
 		if (startup_block) {
 			ret = of_property_read_u32(nc, "reg",
 						   &cs_num);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(nc);
 				return -EINVAL;
+			}
 		}
 		ret = of_property_read_u32(nc, "spi-rx-bus-width",
 					   &rx_bus_width);
 		if (!ret) {
 			xspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}