From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, cohuck@redhat.com,
alex.williamson@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] vfio/type1: Simplify bus_type determination
Date: Fri, 24 Jun 2022 11:14:09 -0300 [thread overview]
Message-ID: <20220624141409.GR4147@nvidia.com> (raw)
In-Reply-To: <4bc34090-249a-c505-3d90-f75a7fe7c17d@arm.com>
On Tue, Jun 21, 2022 at 08:09:20PM +0100, Robin Murphy wrote:
> Quick consensus then: does anyone have a particular preference between
> changing the .attach_group signature vs. adding a helper based on
> vfio_group_get_from_iommu() for type1 to call from within its callback? They
> seem about equal (but opposite) in terms of the simplicity vs. impact
> tradeoff to me, so I can't quite decide conclusively...
Ah, I've been away and only just saw this..
Given Alex's remarks and the need to re-get the vfio_group in the
helper, it may be very slightly nicer to pass in the vfio_device as an
argument. But either works for me.
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: kvm@vger.kernel.org, cohuck@redhat.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
alex.williamson@redhat.com
Subject: Re: [PATCH 1/2] vfio/type1: Simplify bus_type determination
Date: Fri, 24 Jun 2022 11:14:09 -0300 [thread overview]
Message-ID: <20220624141409.GR4147@nvidia.com> (raw)
In-Reply-To: <4bc34090-249a-c505-3d90-f75a7fe7c17d@arm.com>
On Tue, Jun 21, 2022 at 08:09:20PM +0100, Robin Murphy wrote:
> Quick consensus then: does anyone have a particular preference between
> changing the .attach_group signature vs. adding a helper based on
> vfio_group_get_from_iommu() for type1 to call from within its callback? They
> seem about equal (but opposite) in terms of the simplicity vs. impact
> tradeoff to me, so I can't quite decide conclusively...
Ah, I've been away and only just saw this..
Given Alex's remarks and the need to re-get the vfio_group in the
helper, it may be very slightly nicer to pass in the vfio_device as an
argument. But either works for me.
Jason
next prev parent reply other threads:[~2022-06-24 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 14:25 [PATCH 1/2] vfio/type1: Simplify bus_type determination Robin Murphy
2022-06-08 14:25 ` Robin Murphy
2022-06-08 14:25 ` [PATCH 2/2] vfio: Use device_iommu_capable() Robin Murphy
2022-06-08 14:25 ` Robin Murphy
2022-06-10 0:03 ` [PATCH 1/2] vfio/type1: Simplify bus_type determination Jason Gunthorpe via iommu
2022-06-10 0:03 ` Jason Gunthorpe
2022-06-21 19:09 ` Robin Murphy
2022-06-21 19:09 ` Robin Murphy
2022-06-24 14:14 ` Jason Gunthorpe via iommu [this message]
2022-06-24 14:14 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624141409.GR4147@nvidia.com \
--to=iommu@lists.linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.