All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sathvika Vasireddy <sv@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
	aik@ozlabs.ru, mingo@redhat.com, sv@linux.ibm.com,
	rostedt@goodmis.org, jpoimboe@redhat.com, paulus@samba.org,
	naveen.n.rao@linux.vnet.ibm.com, mbenes@suse.cz
Subject: [RFC PATCH v3 08/12] objtool: Add arch specific function arch_ftrace_match()
Date: Sat, 25 Jun 2022 00:02:34 +0530	[thread overview]
Message-ID: <20220624183238.388144-9-sv@linux.ibm.com> (raw)
In-Reply-To: <20220624183238.388144-1-sv@linux.ibm.com>

Add architecture specific function to look for
relocation records pointing to arch specific
symbols.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
 tools/objtool/arch/x86/decode.c      | 8 ++++++++
 tools/objtool/check.c                | 2 +-
 tools/objtool/include/objtool/arch.h | 2 ++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index 8b990a52aada..6a66b0c0dd2c 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -23,6 +23,14 @@
 #include <objtool/builtin.h>
 #include <arch/elf.h>
 
+bool arch_ftrace_match(char *name)
+{
+	if (!strcmp(func->name, "__fentry__"))
+		return true;
+
+	return false;
+}
+
 static int is_x86_64(const struct elf *elf)
 {
 	switch (elf->ehdr.e_machine) {
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 88f68269860e..51b6dcec8d6a 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2185,7 +2185,7 @@ static int classify_symbols(struct objtool_file *file)
 			if (arch_is_retpoline(func))
 				func->retpoline_thunk = true;
 
-			if (!strcmp(func->name, "__fentry__"))
+			if (arch_ftrace_match(func->name))
 				func->fentry = true;
 
 			if (is_profiling_func(func->name))
diff --git a/tools/objtool/include/objtool/arch.h b/tools/objtool/include/objtool/arch.h
index 9b19cc304195..99d0c8ba1b69 100644
--- a/tools/objtool/include/objtool/arch.h
+++ b/tools/objtool/include/objtool/arch.h
@@ -69,6 +69,8 @@ struct stack_op {
 
 struct instruction;
 
+bool arch_ftrace_match(char *name);
+
 void arch_initial_func_cfi_state(struct cfi_init_state *state);
 
 int arch_decode_instruction(struct objtool_file *file, const struct section *sec,
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Sathvika Vasireddy <sv@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: jpoimboe@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, aik@ozlabs.ru, mpe@ellerman.id.au,
	christophe.leroy@csgroup.eu, mingo@redhat.com,
	rostedt@goodmis.org, naveen.n.rao@linux.vnet.ibm.com,
	sv@linux.ibm.com, mbenes@suse.cz, benh@kernel.crashing.org,
	paulus@samba.org
Subject: [RFC PATCH v3 08/12] objtool: Add arch specific function arch_ftrace_match()
Date: Sat, 25 Jun 2022 00:02:34 +0530	[thread overview]
Message-ID: <20220624183238.388144-9-sv@linux.ibm.com> (raw)
In-Reply-To: <20220624183238.388144-1-sv@linux.ibm.com>

Add architecture specific function to look for
relocation records pointing to arch specific
symbols.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
 tools/objtool/arch/x86/decode.c      | 8 ++++++++
 tools/objtool/check.c                | 2 +-
 tools/objtool/include/objtool/arch.h | 2 ++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index 8b990a52aada..6a66b0c0dd2c 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -23,6 +23,14 @@
 #include <objtool/builtin.h>
 #include <arch/elf.h>
 
+bool arch_ftrace_match(char *name)
+{
+	if (!strcmp(func->name, "__fentry__"))
+		return true;
+
+	return false;
+}
+
 static int is_x86_64(const struct elf *elf)
 {
 	switch (elf->ehdr.e_machine) {
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 88f68269860e..51b6dcec8d6a 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2185,7 +2185,7 @@ static int classify_symbols(struct objtool_file *file)
 			if (arch_is_retpoline(func))
 				func->retpoline_thunk = true;
 
-			if (!strcmp(func->name, "__fentry__"))
+			if (arch_ftrace_match(func->name))
 				func->fentry = true;
 
 			if (is_profiling_func(func->name))
diff --git a/tools/objtool/include/objtool/arch.h b/tools/objtool/include/objtool/arch.h
index 9b19cc304195..99d0c8ba1b69 100644
--- a/tools/objtool/include/objtool/arch.h
+++ b/tools/objtool/include/objtool/arch.h
@@ -69,6 +69,8 @@ struct stack_op {
 
 struct instruction;
 
+bool arch_ftrace_match(char *name);
+
 void arch_initial_func_cfi_state(struct cfi_init_state *state);
 
 int arch_decode_instruction(struct objtool_file *file, const struct section *sec,
-- 
2.25.1


  parent reply	other threads:[~2022-06-24 18:38 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 18:32 [RFC PATCH v3 00/12] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-06-24 18:32 ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 01/12] objtool: Fix SEGFAULT Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-07-08 15:10   ` Christophe Leroy
2022-07-08 15:10     ` Christophe Leroy
2022-06-24 18:32 ` [RFC PATCH v3 02/12] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 03/12] objtool: Use target file class size " Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-07-08 17:35   ` Christophe Leroy
2022-07-08 17:35     ` Christophe Leroy
2022-06-24 18:32 ` [RFC PATCH v3 04/12] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 05/12] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 06/12] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 07/12] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-07-04 11:14   ` Peter Zijlstra
2022-07-04 11:14     ` Peter Zijlstra
2022-07-04 15:53     ` Christophe Leroy
2022-07-04 15:53       ` Christophe Leroy
2022-07-04 16:18       ` Peter Zijlstra
2022-07-04 16:18         ` Peter Zijlstra
2022-06-24 18:32 ` Sathvika Vasireddy [this message]
2022-06-24 18:32   ` [RFC PATCH v3 08/12] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 09/12] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 10/12] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-24 18:32 ` [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-06-25  6:46   ` Christophe Leroy
2022-06-25  6:46     ` Christophe Leroy
2022-06-27 15:21     ` Sathvika Vasireddy
2022-06-27 15:35     ` Sathvika Vasireddy
2022-06-27 15:35       ` Sathvika Vasireddy
2022-06-27 15:46       ` Christophe Leroy
2022-06-27 15:46         ` Christophe Leroy
2022-06-29 18:30       ` Christophe Leroy
2022-06-29 18:30         ` Christophe Leroy
2022-06-29 18:30         ` Christophe Leroy
2022-06-30  8:05         ` Naveen N. Rao
2022-06-30  8:05           ` Naveen N. Rao
2022-06-30  8:05           ` Naveen N. Rao
2022-06-30  9:58           ` Christophe Leroy
2022-06-30  9:58             ` Christophe Leroy
2022-06-30  9:58             ` Christophe Leroy
2022-06-30 10:33             ` Christophe Leroy
2022-06-30 10:33               ` Christophe Leroy
2022-06-30 10:33               ` Christophe Leroy
2022-06-30 10:37             ` Naveen N. Rao
2022-06-30 10:37               ` Naveen N. Rao
2022-06-30 10:37               ` Naveen N. Rao
2022-06-30 15:58               ` Segher Boessenkool
2022-06-30 15:58                 ` Segher Boessenkool
2022-06-30 15:58                 ` Segher Boessenkool
2022-07-04 12:01                 ` Peter Zijlstra
2022-07-04 12:01                   ` Peter Zijlstra
2022-07-04 12:01                   ` Peter Zijlstra
2022-07-04 11:43               ` Peter Zijlstra
2022-07-04 11:43                 ` Peter Zijlstra
2022-07-04 11:43                 ` Peter Zijlstra
2022-07-01  2:13           ` Chen Zhongjin
2022-07-01  2:13             ` Chen Zhongjin
2022-07-01  2:13             ` Chen Zhongjin
2022-07-01  6:56             ` Sathvika Vasireddy
2022-07-01  6:56               ` Sathvika Vasireddy
2022-07-01  6:56               ` Sathvika Vasireddy
2022-07-01 11:40               ` [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() (gcc issue ?) Christophe Leroy
2022-07-01 11:40                 ` Christophe Leroy
2022-07-01 11:40                 ` Christophe Leroy
2022-07-04 11:45         ` [RFC PATCH v3 11/12] powerpc: Remove unreachable() from WARN_ON() Peter Zijlstra
2022-07-04 11:45           ` Peter Zijlstra
2022-07-04 11:45           ` Peter Zijlstra
2022-07-04 12:34           ` Christophe Leroy
2022-07-04 12:34             ` Christophe Leroy
2022-07-04 12:34             ` Christophe Leroy
2022-07-05 15:48             ` Segher Boessenkool
2022-07-05 15:48               ` Segher Boessenkool
2022-07-05 15:48               ` Segher Boessenkool
2022-07-04 12:05     ` Peter Zijlstra
2022-07-04 12:05       ` Peter Zijlstra
2022-07-04 12:44       ` Christophe Leroy
2022-07-04 12:44         ` Christophe Leroy
2022-07-04 14:19         ` Peter Zijlstra
2022-07-04 14:19           ` Peter Zijlstra
2022-06-24 18:32 ` [RFC PATCH v3 12/12] objtool/powerpc: Fix unannotated intra-function call warnings Sathvika Vasireddy
2022-06-24 18:32   ` Sathvika Vasireddy
2022-07-08 15:06 ` [RFC PATCH v3 00/12] objtool: Enable and implement --mcount option on powerpc Christophe Leroy
2022-07-08 15:06   ` Christophe Leroy
2022-07-08 15:42   ` Christophe Leroy
2022-07-08 15:42     ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624183238.388144-9-sv@linux.ibm.com \
    --to=sv@linux.ibm.com \
    --cc=aik@ozlabs.ru \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mbenes@suse.cz \
    --cc=mingo@redhat.com \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.