From: Miles Chen <miles.chen@mediatek.com>
To: <angelogioacchino.delregno@collabora.com>
Cc: <bgolaszewski@baylibre.com>, <chun-jie.chen@mediatek.com>,
<ck.hu@mediatek.com>, <devicetree@vger.kernel.org>,
<fparent@baylibre.com>, <ikjn@chromium.org>,
<jason-jh.lin@mediatek.com>, <kernel@collabora.com>,
<konrad.dybcio@somainline.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<marijn.suijten@somainline.org>, <martin.botka@somainline.org>,
<matthias.bgg@gmail.com>, <miles.chen@mediatek.com>,
<mturquette@baylibre.com>, <p.zabel@pengutronix.de>,
<paul.bouchara@somainline.org>, <phone-devel@vger.kernel.org>,
<rex-bc.chen@mediatek.com>, <robh+dt@kernel.org>,
<sam.shih@mediatek.com>, <sboyd@kernel.org>,
<tinghan.shen@mediatek.com>, <weiyi.lu@mediatek.com>,
<wenst@chromium.org>, <y.oudjana@protonmail.com>,
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH v3 5/7] clk: mediatek: clk-apmixed: Remove unneeded __init annotation
Date: Sat, 25 Jun 2022 08:07:16 +0800 [thread overview]
Message-ID: <20220625000716.12272-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220624093525.243077-6-angelogioacchino.delregno@collabora.com>
> Remove an unneeded __init annotation from the declaration of function
> mtk_clk_register_ref2usb_tx(): this avoids section mismatch warnings
> during modpost phase when called from functions that have no such
> annotation (useful when clocks are platform drivers).
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/clk/mediatek/clk-apmixed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-apmixed.c b/drivers/clk/mediatek/clk-apmixed.c
> index fc3d4146f482..6b0ab0a346e8 100644
> --- a/drivers/clk/mediatek/clk-apmixed.c
> +++ b/drivers/clk/mediatek/clk-apmixed.c
> @@ -70,7 +70,7 @@ static const struct clk_ops mtk_ref2usb_tx_ops = {
> .unprepare = mtk_ref2usb_tx_unprepare,
> };
>
> -struct clk_hw * __init mtk_clk_register_ref2usb_tx(const char *name,
> +struct clk_hw *mtk_clk_register_ref2usb_tx(const char *name,
> const char *parent_name, void __iomem *reg)
> {
> struct mtk_ref2usb_tx *tx;
> --
> 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Miles Chen <miles.chen@mediatek.com>
To: <angelogioacchino.delregno@collabora.com>
Cc: <bgolaszewski@baylibre.com>, <chun-jie.chen@mediatek.com>,
<ck.hu@mediatek.com>, <devicetree@vger.kernel.org>,
<fparent@baylibre.com>, <ikjn@chromium.org>,
<jason-jh.lin@mediatek.com>, <kernel@collabora.com>,
<konrad.dybcio@somainline.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<marijn.suijten@somainline.org>, <martin.botka@somainline.org>,
<matthias.bgg@gmail.com>, <miles.chen@mediatek.com>,
<mturquette@baylibre.com>, <p.zabel@pengutronix.de>,
<paul.bouchara@somainline.org>, <phone-devel@vger.kernel.org>,
<rex-bc.chen@mediatek.com>, <robh+dt@kernel.org>,
<sam.shih@mediatek.com>, <sboyd@kernel.org>,
<tinghan.shen@mediatek.com>, <weiyi.lu@mediatek.com>,
<wenst@chromium.org>, <y.oudjana@protonmail.com>,
<~postmarketos/upstreaming@lists.sr.ht>
Subject: Re: [PATCH v3 5/7] clk: mediatek: clk-apmixed: Remove unneeded __init annotation
Date: Sat, 25 Jun 2022 08:07:16 +0800 [thread overview]
Message-ID: <20220625000716.12272-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220624093525.243077-6-angelogioacchino.delregno@collabora.com>
> Remove an unneeded __init annotation from the declaration of function
> mtk_clk_register_ref2usb_tx(): this avoids section mismatch warnings
> during modpost phase when called from functions that have no such
> annotation (useful when clocks are platform drivers).
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> ---
> drivers/clk/mediatek/clk-apmixed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/mediatek/clk-apmixed.c b/drivers/clk/mediatek/clk-apmixed.c
> index fc3d4146f482..6b0ab0a346e8 100644
> --- a/drivers/clk/mediatek/clk-apmixed.c
> +++ b/drivers/clk/mediatek/clk-apmixed.c
> @@ -70,7 +70,7 @@ static const struct clk_ops mtk_ref2usb_tx_ops = {
> .unprepare = mtk_ref2usb_tx_unprepare,
> };
>
> -struct clk_hw * __init mtk_clk_register_ref2usb_tx(const char *name,
> +struct clk_hw *mtk_clk_register_ref2usb_tx(const char *name,
> const char *parent_name, void __iomem *reg)
> {
> struct mtk_ref2usb_tx *tx;
> --
> 2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-25 0:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 9:35 [PATCH v3 0/7] MediaTek Helio X10 MT6795 - Clock drivers AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-24 9:35 ` [PATCH v3 1/7] dt-bindings: mediatek: Document MT6795 system controllers bindings AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-24 9:35 ` [PATCH v3 2/7] dt-bindings: clock: Add MediaTek Helio X10 MT6795 clock bindings AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-25 20:30 ` Krzysztof Kozlowski
2022-06-25 20:30 ` Krzysztof Kozlowski
2022-06-27 8:49 ` AngeloGioacchino Del Regno
2022-06-27 8:49 ` AngeloGioacchino Del Regno
2022-06-27 8:59 ` Krzysztof Kozlowski
2022-06-27 8:59 ` Krzysztof Kozlowski
2022-06-24 9:35 ` [PATCH v3 3/7] dt-bindings: reset: Add bindings for MT6795 Helio X10 reset controllers AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-25 20:30 ` Krzysztof Kozlowski
2022-06-25 20:30 ` Krzysztof Kozlowski
2022-06-24 9:35 ` [PATCH v3 4/7] dt-bindings: clock: mediatek: Add clock driver bindings for MT6795 AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-24 17:26 ` Rob Herring
2022-06-24 17:26 ` Rob Herring
2022-06-25 20:29 ` Krzysztof Kozlowski
2022-06-25 20:29 ` Krzysztof Kozlowski
2022-06-26 9:47 ` David Heidelberg
2022-06-26 9:47 ` David Heidelberg
2022-06-26 10:31 ` Krzysztof Kozlowski
2022-06-26 10:31 ` Krzysztof Kozlowski
2022-06-27 7:44 ` AngeloGioacchino Del Regno
2022-06-27 7:44 ` AngeloGioacchino Del Regno
2022-06-24 9:35 ` [PATCH v3 5/7] clk: mediatek: clk-apmixed: Remove unneeded __init annotation AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-25 0:07 ` Miles Chen [this message]
2022-06-25 0:07 ` Miles Chen
2022-06-24 9:35 ` [PATCH v3 6/7] clk: mediatek: Export required symbols to compile clk drivers as module AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-24 9:35 ` [PATCH v3 7/7] clk: mediatek: Add MediaTek Helio X10 MT6795 clock drivers AngeloGioacchino Del Regno
2022-06-24 9:35 ` AngeloGioacchino Del Regno
2022-06-25 0:07 ` Miles Chen
2022-06-25 0:07 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220625000716.12272-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bgolaszewski@baylibre.com \
--cc=chun-jie.chen@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=ikjn@chromium.org \
--cc=jason-jh.lin@mediatek.com \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.bouchara@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sam.shih@mediatek.com \
--cc=sboyd@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=weiyi.lu@mediatek.com \
--cc=wenst@chromium.org \
--cc=y.oudjana@protonmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.